Re: wiringX-git PKGBUILD Review Request

2024-01-06 Thread David C. Rankin
On 1/6/24 09:35, Polarian wrote: The nature of static linking is for portability, and although reading about it there is some use cases for static libraries [2], most programs which static link will compile the program from source by default. Secondly this is slightly out of the scope of Arch Li

Re: wiringX-git PKGBUILD Review Request

2024-01-06 Thread Doug Newgard
In addition to things others have said. > url="httpx://wiringx.org/" Typo > pkgver() { >cd "${srcdir}/$_gitname" >echo $(git rev-list --count HEAD).$(git rev-parse --short HEAD) > } This will cause problems if there is ever a release. See https://wiki.archlinux.org/title/VCS_package_gui

Re: wiringX-git PKGBUILD Review Request

2024-01-06 Thread Aaron Liu
Hi, According to manual.wiringx.org , wiringX is only a library and nothing else. I don't think the splitting into two packages part applies here, as there is nothing to install other than the library. -- Cheers, Aᴀʀᴏɴ OpenPGP_0x4E85967FC7C436BE.asc Description: OpenPGP public key OpenPG

Re: wiringX-git PKGBUILD Review Request

2024-01-06 Thread Jakub Klinkovský
You might also want to look at the CMake package guidelines [1]. In particular, cmake should be called from build(), not prepare(). [1] https://wiki.archlinux.org/title/CMake_package_guidelines signature.asc Description: PGP signature

Re: wiringX-git PKGBUILD Review Request

2024-01-06 Thread David C. Rankin
On 1/6/24 01:22, Jean-Claude wrote: In addition to what has been said, do not include the package name in the description in a self-referencing way.[1] [1] https://wiki.archlinux.org/title/Arch_package_guidelines#Package_etiquette Thanks Aaron and Jean-Claude, I'll fix those items and put i