Re: Upcoming PHP 8.2 update and introduction of legacy packages

2023-01-16 Thread Pierre Schmitz
Ill look into this. Unfortunately this slipped through as I did only use the cli and fpm sapis. Bug thanks for providing the patch! I have seen others use the patchelf tool to rewrite the sonames. I'll check if that would make the solution more reliable. On Sun, Jan 15, 2023 at 12:25 PM David Rung

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2023-01-16 Thread David Runge
On 2023-01-15 12:25:36 (+0100), David Runge wrote: > There has been a problem [1] introduced by not renaming the soname of > libphp-legacy.so. The soname was still libphp.so, so linking against > libphp-legacy.so led to dependents requiring libphp.so instead (this was > also the case for the apache

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2023-01-15 Thread David Runge
On 2022-12-20 11:49:28 (+0100), Pierre Schmitz wrote: > On Tue, Dec 20, 2022 at 11:25 AM David Runge wrote: > > Hm, I'm not so happy about this removing the checks and hardcoding > > php-legacy though. > > The check is done by calling versioncheck.php directly as it fails > when version constrain

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-20 Thread Pierre Schmitz
On Tue, Dec 20, 2022 at 11:25 AM David Runge wrote: > Hm, I'm not so happy about this removing the checks and hardcoding > php-legacy though. The check is done by calling versioncheck.php directly as it fails when version constraints are not met. You are correct, if we want users to be able to u

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-20 Thread David Runge
On 2022-12-20 11:09:15 (+0100), Pierre Schmitz wrote: > On Tue, Dec 20, 2022 at 10:44 AM Pierre Schmitz wrote: > >(I can do the required changes if you like) > > As some code is probably easier to talk about here is my idea in patch > from: https://gist.github.com/pierres/227602544b54a1b027471b6c

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-20 Thread Pierre Schmitz
On Tue, Dec 20, 2022 at 10:44 AM Pierre Schmitz wrote: >(I can do the required changes if you like) As some code is probably easier to talk about here is my idea in patch from: https://gist.github.com/pierres/227602544b54a1b027471b6ccdab36c1 -- Pierre Schmitz, https://pierre-schmitz.com

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-20 Thread Pierre Schmitz
On Tue, Dec 20, 2022 at 10:12 AM David Runge wrote: > Please rebuild nextcloud packages and see if they work before moving php > to outside of staging. This is what I introduced the php-interpreter > virtual provides for! :) > > Package builds should fail right away in check() if it is not > compa

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-20 Thread David Runge
On 2022-12-20 10:00:09 (+0100), Pierre Schmitz wrote: > The rebuild for modules and anything that links against PHP went quite > well and I have moved the packages into [testing]. Even uwsgi did > build with a simple patch. I did notice that this project is in > maintenance mode according to upstre

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-20 Thread Pierre Schmitz
The rebuild for modules and anything that links against PHP went quite well and I have moved the packages into [testing]. Even uwsgi did build with a simple patch. I did notice that this project is in maintenance mode according to upstream; so I am not that optimistic we can provide the PHP plugin

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-19 Thread Pierre Schmitz
On Mon, Dec 19, 2022 at 3:40 PM Jelle van der Waa wrote: > I don't object against providing an older PHP but why is it named > php-legacy? We don't really have a policy for this, but it feels > inconsistent versus the current php7, ruby2.7 package. (Ofcourse > nodejs-lts-gallium is then also incon

Re: Upcoming PHP 8.2 update and introduction of legacy packages

2022-12-19 Thread Jelle van der Waa
Hey, On 17/12/2022 11:13, Pierre Schmitz wrote: With the release to PHP 8.2 I will introduce a new set of packages to solve most of the issues with PHP updates. There are two valid requirements: On one hand people need the latest version to use its features or to develop new applications. And on