Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-14 Thread Faith Ekstrand
On January 14, 2025 03:39:45 Marek Olšák wrote: I would keep the existing modifier interfaces, API extensions, and expectations the same as today for simplicity. The new linear modifier definition (proposal) will have these fields: 5 bits for log2 pitch alignment in bytes 5 bits for log2 h

Re: [RFC] amdgpu: Add a context flag to disable implicit sync

2024-08-19 Thread Faith Ekstrand
On Mon, Aug 19, 2024 at 10:00 AM Bas Nieuwenhuizen wrote: > > > On Mon, Aug 19, 2024 at 4:51 PM Christian König < > ckoenig.leichtzumer...@gmail.com> wrote: > >> Am 07.08.24 um 22:33 schrieb Bas Nieuwenhuizen: >> >> On Wed, Aug 7, 2024 at 10:25 PM Faith E

Re: [PATCH 0/6] Add submission flag to disable implicit sync.

2024-08-09 Thread Faith Ekstrand
I don't see anything wrong with it Reviewed-by: Faith Ekstrand However, I'm not an AMDGPU developer so you probably want someone who knows the amdgpu sync stuff to review as well. On Wed, Aug 7, 2024 at 8:09 PM Bas Nieuwenhuizen wrote: > For the rationale see the earlier

Re: [PATCH 4/6] drm/amdgpu: Add UAPI for disabling implicit sync per submission.

2024-08-09 Thread Faith Ekstrand
isable implicit sync on BOs wrt other > + * submissions. */ > +#define AMDGPU_CS_NO_IMPLICIT_SYNC 1 > In my UAPI patch, I also threw a comment on the BO flag documenting that it's not a great thing to use. Some sort of documentation for future generations would be nice Oth

Re: [RFC] amdgpu: Add a context flag to disable implicit sync

2024-08-07 Thread Faith Ekstrand
I think I am OK with this approach, even though I think mixing > implicit and explicit sync is gross, and I want the pain that is implicit > sync to just go away forever. :-) > So say we all... ~Faith > - Joshie 🐸✨ > > > On August 7, 2024 4:39:32 PM GMT+01:00, Faith E

[RFC] amdgpu: Add a context flag to disable implicit sync

2024-08-07 Thread Faith Ekstrand
OP would make more sense if we want to back-port it but the create flag made more sense to me from an API design PoV. Signed-off-by: Faith Ekstrand Cc: Alex Deucher Cc: Christian König Cc: David Airlie Cc: Michel Dänzer Cc: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 +