Re: [PATCH RESEND] drm/amd/display: Initialize return value in dm_cache_state()

2025-10-09 Thread Eslam Khafagy
On 10/8/25 05:15, Mario Limonciello wrote: On 10/7/2025 5:45 PM, Eslam Khafagy wrote: Initialize the return variable "r" to 0 in dm_cache_state() to fix a potential use of uninitialized variable warning. The return value for this function might not be a PTR_ERR, in casse if condition fails.

[PATCH v5 3/4] drm/amd: Save and restore all limit types

2025-10-09 Thread Mario Limonciello
Vangogh has separate limits for default PPT and fast PPT. Add infrastructure to save both of these limits and restore both of them. Reviewed-by: Lijo Lazar Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 19 --- drivers/gpu/drm/amd/pm/swsmu/i

[PATCH v5 0/4] Adjustment to power limit setting

2025-10-09 Thread Mario Limonciello
Lijo pointed out to me that commit ed4efe426a49 ("drm/amd: Restore cached power limit during resume") commit 796ff8a7e01b ("drm/amd: Restore cached manual clock settings during resume") both should be unnecessary because smu_restore_dpm_user_profile() already restores them. However in looking at

Re: [PATCH] drm/amd: Permit DC_FP_START/END only in non-FP compilation units

2025-10-09 Thread Harry Wentland
On 2025-10-09 12:19, Christian König wrote: > On 09.10.25 17:06, Ard Biesheuvel wrote: >> From: Ard Biesheuvel >> >> Test the existing CPP macro _LINUX_FPU_COMPILATION_UNIT, which is set >> when building source files that are permitted to use floating point, >> in the implementation of DC_FP_ST

Re: [PATCH 2/6] drm/amdgpu: fix initialization of doorbell array for detect and hang

2025-10-09 Thread Alex Deucher
On Thu, Oct 9, 2025 at 2:50 PM Jonathan Kim wrote: > > Initialized doorbells should be set to invalid rather than 0 to prevent > driver from over counting hung doorbells since it checks against the > invalid value to begin with. > > Signed-off-by: Jonathan Kim Reviewed-by: Alex Deucher > --- >

[PATCH 4/6] drm/amdgpu: enable suspend/resume all for gfx 12

2025-10-09 Thread Jonathan Kim
Suspend/resume all gangs has been available for GFX12 for a while now so enable it. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/a

[PATCH 1/6] drm/amdgpu: fix gfx12 mes packet status return check

2025-10-09 Thread Jonathan Kim
GFX12 MES uses low 32 bits of status return for success (1 or 0) and high bits for debug information if low bits are 0. GFX11 MES doesn't do this so checking full 64-bit status return for 1 or 0 is still valid. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 2 +- 1 fil

Re: [PATCH 4/6] drm/amdgpu: Reuse fw_vram_usage_* for dynamic critical region in SRIOV

2025-10-09 Thread Alex Deucher
On Wed, Oct 8, 2025 at 11:46 PM Ellen Pan wrote: > > - During guest driver init, asa VFs receive PF msg to > init dynamic critical region(v2), VFs reuse fw_vram_usage_* > from ttm to store critical region tables in a 5MB chunk. > > Signed-off-by: Ellen Pan > --- > drivers/gpu/dr

Re: [PATCH 1/2] drm/amdgpu: Add kiq hdp flush callbacks

2025-10-09 Thread Alex Deucher
On Wed, Oct 8, 2025 at 10:48 PM Victor Zhao wrote: > > Add kiq hdp flush callbacks for gfx ips to support gpu hdp flush when no > ring presents > > Signed-off-by: Victor Zhao This patch is: Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 1 + > drivers/gpu/drm/amd/amd

Re: [PATCH] Revert "drm/amd/display: Only restore backlight after amdgpu_dm_init or dm_resume"

2025-10-09 Thread Greg KH
On Thu, Oct 09, 2025 at 11:23:01AM +0200, Matthew Schwartz wrote: > This fix regressed the original issue that commit d83c747a1225 > ("drm/amd/display: Fix brightness level not retained over reboot") solved, > so revert it until a different approach to solve the regression that > it caused with AMD

[PATCH v2] Revert "drm/amd/display: Only restore backlight after amdgpu_dm_init or dm_resume"

2025-10-09 Thread Matthew Schwartz
This fix regressed the original issue that commit d83c747a1225 ("drm/amd/display: Fix brightness level not retained over reboot") solved, so revert it until a different approach to solve the regression that it caused with AMD_PRIVATE_COLOR is found. Fixes: a490c8d77d50 ("drm/amd/display: Only rest

[PATCH v3 05/19 5.15.y] minmax: avoid overly complicated constant expressions in VM code

2025-10-09 Thread Eliav Farber
From: Linus Torvalds [ Upstream commit 3a7e02c040b130b5545e4b115aada7bacd80a2b6 ] The minmax infrastructure is overkill for simple constants, and can cause huge expansions because those simple constants are then used by other things. For example, 'pageblock_order' is a core VM constant, but bec

[PATCH v3 02/19 5.15.y] minmax: Introduce {min,max}_array()

2025-10-09 Thread Eliav Farber
From: Herve Codina [ Upstream commit c952c748c7a983a8bda9112984e6f2c1f6e441a5 ] Introduce min_array() (resp max_array()) in order to get the minimal (resp maximum) of values present in an array. Signed-off-by: Herve Codina Reviewed-by: Andy Shevchenko Reviewed-by: Christophe Leroy Link: http

[PATCH v3 18/19 5.15.y] minmax.h: simplify the variants of clamp()

2025-10-09 Thread Eliav Farber
From: David Laight [ Upstream commit 495bba17cdf95e9703af1b8ef773c55ef0dfe703 ] Always pass a 'type' through to __clamp_once(), pass '__auto_type' from clamp() itself. The expansion of __types_ok3() is reasonable so it isn't worth the added complexity of avoiding it when a fixed type is used fo

[PATCH v3 00/19 5.15.y] Backport minmax.h updates from v6.17-rc7

2025-10-09 Thread Eliav Farber
This series backports 19 patches to update minmax.h in the 5.15.y branch, aligning it with v6.17-rc7. The ultimate goal is to synchronize all longterm branches so that they include the full set of minmax.h changes. 6.12.y was already backported and changes are part of v6.12.49. 6.6.y was already