Re: [PATCH] drm/radeon: use dev_warn_once() in CS parsers

2025-09-06 Thread Alex Deucher
On Fri, Sep 5, 2025 at 6:54 AM Borislav Petkov wrote: > > On Tue, Sep 02, 2025 at 12:53:32PM -0400, Alex Deucher wrote: > > Older GPUs did not support memory protection, so the kernel > > driver would validate the command submissions (CS) from userspace > > to avoid the GPU accessing any memory it

[PATCH v6 RESEND 03/11] usb: sl811-hcd: Add PM_EVENT_POWEROFF into suspend callbacks

2025-09-06 Thread Mario Limonciello (AMD)
When the ACPI core uses hibernation callbacks for shutdown drivers will receive PM_EVENT_POWEROFF and should handle it the same as PM_EVENT_HIBERNATE would have been used. Tested-by: Eric Naim Signed-off-by: Mario Limonciello (AMD) --- drivers/usb/host/sl811-hcd.c | 1 + 1 file changed, 1 inser

Re: [PATCH] drm/radeon: use dev_warn_once() in CS parsers

2025-09-06 Thread Borislav Petkov
On Tue, Sep 02, 2025 at 12:53:32PM -0400, Alex Deucher wrote: > Older GPUs did not support memory protection, so the kernel > driver would validate the command submissions (CS) from userspace > to avoid the GPU accessing any memory it shouldn't. > > Change any error messages in that validatio to d

[PATCH 1/3] drm/amdgpu: adjust MES API used for suspend and resume

2025-09-06 Thread Jesse . Zhang
Use the suspend and resume API rather than remove queue and add queue API. The former just preempts the queue while the latter remove it from the scheduler completely. There is no need to do that, we only need preemption in this case. V2: replace queue_active with queue state v3: set the suspend_

[PATCH v6 RESEND 09/11] PCI: Put PCIe bridges with downstream devices into D3 at hibernate

2025-09-06 Thread Mario Limonciello (AMD)
For the suspend flow PCIe bridges that have downstream devices are put into the appropriate low power state (D3hot or D3cold depending upon specific devices). For the hibernate flow, PCIe bridges with downstream devices stay in D0 however. This can lead to PCIe bridges that are remained powered on

[PATCH v6 RESEND 11/11] PM: Use hibernate flows for system power off

2025-09-06 Thread Mario Limonciello (AMD)
When the system is powered off the kernel will call device_shutdown() which will issue callbacks into PCI core to wake up a device and call it's shutdown() callback. This will leave devices in ACPI D0 which can cause some devices to misbehave with spurious wakeups and also leave some devices on wh

[PATCH v6 RESEND 04/11] USB: Pass PMSG_POWEROFF event to suspend_common() for poweroff with S4 flow

2025-09-06 Thread Mario Limonciello (AMD)
If powering off the system with the S4 flow USB wakeup sources should be ignored. Add a new callback hcd_pci_poweroff() which will differentiate whether target state is S5 and pass PMSG_POWEROFF as the message so that suspend_common() will avoid doing wakeups. Signed-off-by: Mario Limonciello (AMD

[PATCH v6 RESEND 07/11] PCI: PM: Run bridge power up actions as part of restore phase

2025-09-06 Thread Mario Limonciello (AMD)
Suspend resume actions will check the state of the device and whether bus PM should be skipped. These same actions make sense during hibernation image restore. Apply them there as well. Tested-by: Eric Naim Signed-off-by: Mario Limonciello (AMD) --- drivers/pci/pci-driver.c | 5 + 1 file

[PATCH v6 RESEND 01/11] PM: Introduce new PMSG_POWEROFF event

2025-09-06 Thread Mario Limonciello (AMD)
PMSG_POWEROFF will be used for the PM core to allow differentiating between an S4 or S5 shutdown sequence when re-using callbacks. This event should not have wakeups enabled so update PMSG_NO_WAKEUP() to match it as well. Tested-by: Eric Naim Signed-off-by: Mario Limonciello (AMD) --- drivers/

[PATCH v6 RESEND 02/11] scsi: Add PM_EVENT_POWEROFF into suspend callbacks

2025-09-06 Thread Mario Limonciello (AMD)
When the ACPI core uses hibernation callbacks for shutdown drivers will receive PM_EVENT_POWEROFF and should handle it the same as PM_EVENT_HIBERNATE would have been used. Tested-by: Eric Naim Signed-off-by: Mario Limonciello (AMD) --- drivers/scsi/mesh.c | 1 + drivers/scsi/stex.c | 1 + 2 fil

[PATCH v6 RESEND 00/11] Improvements to S5 power consumption

2025-09-06 Thread Mario Limonciello (AMD)
A variety of issues both in function and in power consumption have been raised as a result of devices not being put into a low power state when the system is powered off. There have been some localized changes[1] to PCI core to help these issues, but they have had various downsides. This series i