Re: [PATCH] drm/amd/display: Align hwss_wait_for_all_blank_complete descriptor with implementation

Reviewed-by: Tom Chung On 8/12/2024 6:40 PM, Srinivasan Shanmugam wrote: The descriptor for `hwss_wait_for_all_blank_complete` was previously misaligned with the actual implementation. This commit refines the descriptor to reflect the implementation of `hwss_wait_for_all_blank_complete` Fixes

[PATCH] drm/amdgpu: fixing rlc firmware loading failure issue

Skip rlc firmware validation to ignore firmware header size mismatch issues. Refs: 49e133c973ce ("drm/amdgpu: Fix the null pointer when load rlc firmware") Fixes: e1c6c2c1099f ("drm/amdgpu: refine gfx10 firmware loading") Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 5 +

Re: [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

On Mon, Aug 12, 2024 at 3:05 PM Alex Deucher wrote: > > On Mon, Aug 12, 2024 at 4:30 AM Thomas Zimmermann wrote: > > > > Remove the implementation of struct drm_driver.lastclose. The hook > > was only necessary before in-kernel DRM clients existed, but is now > > obsolete. The code in amdgpu_driv

Re: [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

On Mon, Aug 12, 2024 at 4:30 AM Thomas Zimmermann wrote: > > Remove the implementation of struct drm_driver.lastclose. The hook > was only necessary before in-kernel DRM clients existed, but is now > obsolete. The code in amdgpu_driver_lastclose_kms() is performed by > drm_lastclose(). > > v2: > -

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

On Mon, Aug 12, 2024 at 4:30 AM Thomas Zimmermann wrote: > > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > their lastclose callbacks. Call it from drm_lastclose(), so that the > driver functions can finally be removed. Only PCI devices with enabled > switcheroo do the dela

Re: [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

On 8/12/24 2:34 PM, Thomas Zimmermann wrote: Hi Am 12.08.24 um 14:17 schrieb Danilo Krummrich: On 8/12/24 10:28 AM, Thomas Zimmermann wrote: Replace the call to drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It is equivalent in functionality, but uses the DRM clie

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

On Mon, Aug 12, 2024 at 10:40 AM Daniel Vetter wrote: > > On Mon, Aug 12, 2024 at 12:41:39PM +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 12.08.24 um 12:18 schrieb Daniel Vetter: > > > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > > > > On Mon, Aug 12, 2024 at 10:28:22AM +0

Re: [PATCH v2 4/4] drm/amdgpu: add cp queue registers print for gfx9_4_3

Series is: Reviewed-by: Alex Deucher On Fri, Aug 9, 2024 at 8:54 AM Sunil Khatri wrote: > > Add gfx9_4_3 print support of CP queue registers > for all queues to be used by devcoredump. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 42 +++-

RE: [PATCH] drm/amdgpu: fix KFDMemoryTest.PtraceAccessInvisibleVram fail on SRIOV

[Public] > -Original Message- > From: Kuehling, Felix > Sent: Friday, August 9, 2024 7:49 PM > To: amd-gfx@lists.freedesktop.org; Zhang, GuoQing (Sam) > ; Kim, Jonathan > Subject: Re: [PATCH] drm/amdgpu: fix > KFDMemoryTest.PtraceAccessInvisibleVram fail on SRIOV > > > On 2024-08-07 04:3

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

On Mon, Aug 12, 2024 at 12:41:39PM +0200, Thomas Zimmermann wrote: > Hi > > Am 12.08.24 um 12:18 schrieb Daniel Vetter: > > On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > > > On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > > > > Amdgpu and nouveau call vga_sw

Re: [PATCH v3] drm/amdgpu: Disable dpm_enabled flag while VF is in reset

On 8/12/2024 7:53 PM, Victor Skvortsov wrote: > VFs do not perform HW fini/suspend in FLR, so the dpm_enabled > is incorrectly kept enabled. Add interface to disable it in > virt_pre_reset call. > > v2: Made implementation generic for all asics > v3: Re-order conditionals so PP_MP1_STATE_FLR is

[PATCH v3] drm/amdgpu: Disable dpm_enabled flag while VF is in reset

VFs do not perform HW fini/suspend in FLR, so the dpm_enabled is incorrectly kept enabled. Add interface to disable it in virt_pre_reset call. v2: Made implementation generic for all asics v3: Re-order conditionals so PP_MP1_STATE_FLR is only evaluated on VF Signed-off-by: Victor Skvortsov ---

RE: [PATCH v2] drm/amdgpu: Disable dpm_enabled flag while VF is in reset

[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Lazar, Lijo > Sent: Monday, August 12, 2024 9:46 AM > To: Skvortsov, Victor ; amd- > g...@lists.freedesktop.org; Luo, Zhigang > Subject: Re: [PATCH v2] drm/amdgpu: Disable dpm_enabled flag while VF is i

Re: [PATCH v2] drm/amdgpu: Disable dpm_enabled flag while VF is in reset

On 8/12/2024 6:39 PM, Victor Skvortsov wrote: > VFs do not perform HW fini/suspend in FLR, so the dpm_enabled > is incorrectly kept enabled. Add interface to disable it in > virt_pre_reset call. > > v2: Made implementation generic for all asics > > Signed-off-by: Victor Skvortsov > --- > dri

Re: [PATCH] drm/amdgpu: Reorder to read EFI exported ROM first

On Mon, Aug 12, 2024 at 12:50 AM Lijo Lazar wrote: > > On EFI BIOSes, PCI ROM may be exported through EFI_PCI_IO_PROTOCOL and > expansion ROM BARs may not be enabled. Choose to read from EFI exported > ROM data before reading PCI Expansion ROM BAR. > > Signed-off-by: Lijo Lazar Reviewed-by: Alex

[PATCH v2] drm/amdgpu: Disable dpm_enabled flag while VF is in reset

VFs do not perform HW fini/suspend in FLR, so the dpm_enabled is incorrectly kept enabled. Add interface to disable it in virt_pre_reset call. v2: Made implementation generic for all asics Signed-off-by: Victor Skvortsov --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ drivers/gpu

[RESEND 1/3] drm/mst: switch to guid_t type for GUID

The kernel has a guid_t type for GUIDs. Switch to using it, but avoid any functional changes here. Signed-off-by: Jani Nikula --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/display/drm_dp_mst_topology.c | 67 +++ include/drm/display/drm_dp_mst_helper.h

[PATCH] amd/gpu: drm/hisilicon: Remove unused declarations

amdgpu_gart_table_vram_pin() and amdgpu_gart_table_vram_unpin() has been removed since commit 575e55ee4fbc ("drm/amdgpu: recover gart table at resume") remain the declarations untouched in the header files. Besides, amdgpu_dm_display_resume() has also beed removed since commit a80aa93de1a0 ("drm/a

[RESEND 2/3] drm/mst: switch to guid_gen() to generate valid GUIDs

Instead of just smashing jiffies into a GUID, use guid_gen() to generate RFC 4122 compliant GUIDs. Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_mst_topolog

[RESEND 3/3] drm/amd/display: switch to guid_gen() to generate valid GUIDs

Instead of just smashing jiffies into a GUID, use guid_gen() to generate RFC 4122 compliant GUIDs. Signed-off-by: Jani Nikula --- Side note, it baffles me why amdgpu has a copy of this instead of plumbing it into drm mst code. --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 ++--

Re: [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

Hi Am 12.08.24 um 14:17 schrieb Danilo Krummrich: On 8/12/24 10:28 AM, Thomas Zimmermann wrote: Replace the call to drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It is equivalent in functionality, but uses the DRM client infrastructure. v2: - fix commit descripti

Re: [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

On 8/12/24 10:28 AM, Thomas Zimmermann wrote: Replace the call to drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It is equivalent in functionality, but uses the DRM client infrastructure. v2: - fix commit description Signed-off-by: Thomas Zimmermann Reviewed-by: D

Re: [PATCH v2 4/9] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed

On 8/12/24 10:28 AM, Thomas Zimmermann wrote: The output_poll_changed hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The client code handles display hotplugging internally. v2: - fix commit description Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vet

Re: [PATCH] video/aperture: match the pci device when calling sysfb_disable()

Hi Am 10.08.24 um 13:44 schrieb kernel test robot: Hi Alex, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.11-rc2 next-20240809] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v2 3/9] drm/nouveau: Do not set struct drm_driver.lastclose

On 8/12/24 10:28 AM, Thomas Zimmermann wrote: Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code in nouveau_vga_lastclose() is performed by drm_lastclose(). v2: - update commit description Sig

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

Hi Am 12.08.24 um 12:18 schrieb Daniel Vetter: On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from their lastclose callbacks. Call it from drm_last

[PATCH] drm/amd/display: Align hwss_wait_for_all_blank_complete descriptor with implementation

The descriptor for `hwss_wait_for_all_blank_complete` was previously misaligned with the actual implementation. This commit refines the descriptor to reflect the implementation of `hwss_wait_for_all_blank_complete` Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_hw_s

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

On Mon, Aug 12, 2024 at 11:23:44AM +0200, Daniel Vetter wrote: > On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > > their lastclose callbacks. Call it from drm_lastclose(), so that the > > driver functions

Re: [PATCH v2 7/9] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()

On Mon, Aug 12, 2024 at 10:28:28AM +0200, Thomas Zimmermann wrote: > The function is unused. Remove it. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_fb_helper.c | 15 --- > include/drm/drm_fb_helper.h | 6 -- > 2 files change

Re: [PATCH v2 6/9] drm/fbdev-helper: Update documentation on obsolete callbacks

On Mon, Aug 12, 2024 at 10:28:27AM +0200, Thomas Zimmermann wrote: > The old callbacks lastclose and output_poll_changed are deprecated and > unused. Remove them from the documentation. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_fb_helper.c | 2

Re: [PATCH v2 3/9] drm/nouveau: Do not set struct drm_driver.lastclose

On Mon, Aug 12, 2024 at 10:28:24AM +0200, Thomas Zimmermann wrote: > Remove the implementation of struct drm_driver.lastclose. The hook > was only necessary before in-kernel DRM clients existed, but is now > obsolete. The code in nouveau_vga_lastclose() is performed by > drm_lastclose(). > > v2: >

Re: [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

On Mon, Aug 12, 2024 at 10:28:23AM +0200, Thomas Zimmermann wrote: > Remove the implementation of struct drm_driver.lastclose. The hook > was only necessary before in-kernel DRM clients existed, but is now > obsolete. The code in amdgpu_driver_lastclose_kms() is performed by > drm_lastclose(). > >

Re: [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

On Mon, Aug 12, 2024 at 10:28:22AM +0200, Thomas Zimmermann wrote: > Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from > their lastclose callbacks. Call it from drm_lastclose(), so that the > driver functions can finally be removed. Only PCI devices with enabled > switcheroo do t

[PATCH v2 9/9] drm: Remove struct drm_mode_config_funcs.output_poll_changed

The output_poll_changed hook in struct drm_mode_config_funcs is unused. Remove it. The helper drm_client_dev_hotplug() implements the callback's functionality. Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_probe_helper.c | 10 +- include/drm/drm_mod

[PATCH v2 8/9] drm: Remove struct drm_driver.lastclose

The lastclose callback in struct drm_driver is unused. Remove it. Also update documentation. v2: - update to use drm_lastclose() - fix typo in documentation Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_file.c | 28 ++-- drivers

[PATCH v2 7/9] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed()

The function is unused. Remove it. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 15 --- include/drm/drm_fb_helper.h | 6 -- 2 files changed, 21 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index fe5667

[PATCH v2 6/9] drm/fbdev-helper: Update documentation on obsolete callbacks

The old callbacks lastclose and output_poll_changed are deprecated and unused. Remove them from the documentation. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_

[PATCH v2 4/9] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed

The output_poll_changed hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The client code handles display hotplugging internally. v2: - fix commit description Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/nouveau/dispnv50/disp.

[PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug()

Replace the call to drm_fb_helper_output_poll_changed() with a call to drm_client_dev_hotplug(). It is equivalent in functionality, but uses the DRM client infrastructure. v2: - fix commit description Signed-off-by: Thomas Zimmermann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouve

[PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose

Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code in amdgpu_driver_lastclose_kms() is performed by drm_lastclose(). v2: - update commit message Signed-off-by: Thomas Zimmermann --- drivers/gp

[PATCH v2 0/9] drm/{amdgpu,nouveau}: Remove old fbdev hooks

After switching all drivers' fbdev emulation to DRM client, the old fbdev hooks are now obsolete. Only amgdpu and nouveau still use them in a several places. Remove the hooks from the drivers and the DRM core. The series would ideally be merged at once via drm-misc-next. v2: - call vga_switcheroo

[PATCH v2 3/9] drm/nouveau: Do not set struct drm_driver.lastclose

Remove the implementation of struct drm_driver.lastclose. The hook was only necessary before in-kernel DRM clients existed, but is now obsolete. The code in nouveau_vga_lastclose() is performed by drm_lastclose(). v2: - update commit description Signed-off-by: Thomas Zimmermann --- drivers/gpu/

[PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose()

Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from their lastclose callbacks. Call it from drm_lastclose(), so that the driver functions can finally be removed. Only PCI devices with enabled switcheroo do the delayed switching. The call has no effect on other hardware. v2: - move

Re: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

On Tue, Jul 30, 2024 at 08:53:39PM +0200, Kevin Holm wrote: > From: Wayne Lin > > [ Upstream commit fa57924c76d995e87ca3533ec60d1d5e55769a27 ] > > [Why] > dm_dp_mst_is_port_support_mode() is a bit not following the original design > rule and cause > light up issue with multiple 4k monitors afte

[PATCH 1/4] new helper: drm_gem_prime_handle_to_dmabuf()

Once something had been put into descriptor table, the only thing you can do with it is returning descriptor to userland - you can't withdraw it on subsequent failure exit, etc. You certainly can't count upon it staying in the same slot of descriptor table - another thread could've played with clo

[PATCH 2/4] amdgpu: fix a race in kfd_mem_export_dmabuf()

Using drm_gem_prime_handle_to_fd() to set dmabuf up and insert it into descriptor table, only to have it looked up by file descriptor and remove it from descriptor table is not just too convoluted - it's racy; another thread might have modified the descriptor table while we'd been going through tha

Re: [PATCH] drm/amdgpu: add dce6 drm_panic support

On Thu, Aug 8, 2024 at 13:24 PM Alex Deucher wrote: > > On Thu, Aug 8, 2024 at 12:43 PM Alex Deucher wrote: > > > > On Thu, Aug 8, 2024 at 2:35 AM Lu Yao wrote: > > > > > > On 2024/8/5 17:25, Jocelyn Falempe wrote: > > > > > > > > > > > > On 02/08/2024 11:39, Christian König wrote: > > > >> Am 0

[REGRESSION] amdgpu enables DSC unnecessarily over MST hubs on kernel 6.11+

Hi, I have been using a DisplayPort MST hub with a AMD Ryzen 6800U laptop (GPD Win Max 2) for a while. The hub exposes 2 downstream ports, both of which are connected to 4K (3840x2160) displays. Recently I was hit with another regression in Linux 6.10 (link: https://lore.kernel.org/stable/d74

[PATCH v2] drm/amdgpu: add dce6 drm_panic support

Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao --- Changes in v2: 1. Drop include "drm_internal.h" 2. Add disabling DC tiling ops. Per suggestion from previous thread: https://patchwork.fre

[PATCH 3/4] amdkfd CRIU fixes

Instead of trying to use close_fd() on failure exits, just have criu_get_prime_handle() store the file reference without inserting it into descriptor table. Then, once the callers are past the last failure exit, they can go and either insert all those file references into the corresponding slots o

[PATCHES] [drm] file descriptor fixes

Resurrecting the stuff from last cycle. Context: several places in drm have racy uses of close_fd(). Not hard to fix, thankfully. Changed since the last posting: as requested, KFD fix had been split in two commits - introduction of helper (drm_gem_prime_handle_to_dmabuf()) and swit

[PATCH 4/4] amdgpu: get rid of bogus includes of fdtable.h

Signed-off-by: Al Viro --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c

Re: [PATCH] drm/amdgpu: fix KFDMemoryTest.PtraceAccessInvisibleVram fail on SRIOV

[AMD Official Use Only - AMD Internal Distribution Only] Hi @Kuehling, Felix, Thank you for review. I agree with you that we need to adjust the priority of each access method here. Hi @Kim, Jonathan, I also find a new issue in amdgpu_tt