Re: Review Request 112706: Allow to use Wikipedia over SSL

2014-05-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112706/#review58229 --- This review has been submitted with commit b773bc838147a45c8c

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- (Updated Sept. 13, 2013, 8:38 p.m.) Status -- This change has been ma

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/#review39993 --- This review has been submitted with commit 284342b48dc32341c35

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-13 Thread Frank Meerkoetter
> On Sept. 12, 2013, 9:04 p.m., Matěj Laitl wrote: > > Ship it! (and no, I think HTTPS should be the default, let's heat those NSA > > supercomputers a bit. > > Frank Meerkoetter wrote: > I have to recall this patch. I noticed that there is still some HTTP > traffic. I will look into it to

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-13 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- (Updated Sept. 13, 2013, 8:32 p.m.) Review request for Amarok. Descripti

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/#review39923 --- Ship it! Ship it! (and no, I think HTTPS should be the default

Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- Review request for Amarok. Description --- Allow to use wikipedia ove

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
> On Sept. 12, 2013, 9:04 p.m., Matěj Laitl wrote: > > Ship it! (and no, I think HTTPS should be the default, let's heat those NSA > > supercomputers a bit. I have to recall this patch. I noticed that there is still some HTTP traffic. I will look into it tomorrow. - Frank -

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- (Updated Sept. 12, 2013, 9:20 p.m.) Status -- This change has been di

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/#review39920 --- Looks good to me (with a few style comments). Please don't forg

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112706/ --- (Updated Sept. 12, 2013, 8:44 p.m.) Review request for Amarok. Changes -

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Frank Meerkoetter
> On Sept. 12, 2013, 8:17 p.m., Matěj Laitl wrote: > > Looks good to me (with a few style comments). Please don't forget to add > > BUG, FIXED-IN tags and ChangeLog entry when comitting. > > > > The only reason why we should not hard-code https is that it is blocked by > > in some circumstance