Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/#review36554 --- This review has been submitted with commit 5bfcf25fa06fc09c9bc

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 26, 2013, 4:19 p.m.) Status -- This change has been mar

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-26 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 26, 2013, 10:02 a.m.) Review request for Amarok. Changes -

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-26 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 26, 2013, 9:34 a.m.) Review request for Amarok. Changes --

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-26 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 26, 2013, 9:24 a.m.) Review request for Amarok. Changes --

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-26 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/#review36526 --- Ship it! Ship It! - Mark Kretschmann On July 24, 2013, 2:55

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-24 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 24, 2013, 2:55 p.m.) Review request for Amarok. Changes --

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-24 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 24, 2013, 10:09 a.m.) Review request for Amarok. Changes -

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 23, 2013, 8:21 p.m.) Review request for Amarok. Descriptio

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Konrad Zemek
> On July 23, 2013, 7:40 p.m., Matěj Laitl wrote: > > src/context/widgets/RecentlyPlayedListWidget.cpp, line 218 > > > > > > Hmm, const-ref -> by-value change doesn't seem really needed, but this > > is sooo un

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/#review36412 --- Ship it! Looks nice to me. I unfortunately don't have time to

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 23, 2013, 7:21 p.m.) Review request for Amarok. Changes --

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/#review36373 --- Ship it! Although I don't really know the old code and haven't

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- (Updated July 23, 2013, 10:36 a.m.) Review request for Amarok. Changes -

Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Konrad Zemek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111655/ --- Review request for Amarok. Description --- Reimplement RecentlyPlayed