Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review31120 --- Ship it! Good to go, but it seems that no phonon equalizer eff

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated April 15, 2013, 8:09 p.m.) Status -- This change has been ma

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review31119 --- This review has been submitted with commit e344f608faf236e8faa

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On April 14, 2013, 1:38 p.m., Matěj Laitl wrote: > > src/dialogs/EqualizerDialog.cpp, lines 100-102 > > > > > > code style: no space between if and ( > > Harsh Gupta wrote: > ooppss !!! > > Matěj Laitl wro

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On April 14, 2013, 7:08 p.m., Matěj Laitl wrote: > > src/dialogs/EqualizerDialog.cpp, lines 100-102 > > > > > > code style: no space between if and ( > > Harsh Gupta wrote: > ooppss !!! > > Matěj Laitl wro

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On April 14, 2013, 1:38 p.m., Matěj Laitl wrote: > > src/dialogs/EqualizerDialog.cpp, lines 100-102 > > > > > > code style: no space between if and ( > > Harsh Gupta wrote: > ooppss !!! I'll fix it while c

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then ge

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On April 14, 2013, 7:08 p.m., Matěj Laitl wrote: > > src/dialogs/EqualizerDialog.cpp, lines 100-102 > > > > > > code style: no space between if and ( ooppss !!! - Harsh -

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated April 15, 2013, 9:25 p.m.) Review request for Amarok. Changes -

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 28, 2013, 6:33 p.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then get

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review31016 --- src/EngineController.cpp

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated April 13, 2013, 9:44 p.m.) Review request for Amarok. Changes -

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then ge

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review30951 --- Ping.. While it may seem confusing, remarks for the latest vers

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 28, 2013, 6:33 p.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then get

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then ge

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated April 1, 2013, 5:10 a.m.) Review request for Amarok. Changes --

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 28, 2013, 6:33 p.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then get

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On March 29, 2013, 12:03 a.m., Harsh Gupta wrote: > > src/EngineController.cpp, line 793 > > > > > > How am I suppose to stage changes in a line ( line 791 ) in which a > > variable is first renamed and then ge

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review30021 --- src/EngineController.cpp

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review29959 --- Looks good, thanks! Just a remark or 2 below. Thanks also for t

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated March 14, 2013, 11 p.m.) Review request for Amarok. Changes ---

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

> On Feb. 26, 2013, 4:25 p.m., Matěj Laitl wrote: > > src/dialogs/EqualizerDialog.cpp, lines 99-119 > > > > > > Ugly. Instead please: > > a) check whether meqBandFrq (horrible variable name btw, not your > > f

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review28117 --- Hi, thanks for the patch and sorry for delays while reviewing i

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/#review28114 --- Could a developer please look at this? - Myriam Schweingruber

Re: Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- (Updated Feb. 18, 2013, 11:38 a.m.) Review request for Amarok. Descripti

Review Request 108995: FIX Pre-amplifier in equalizer doesn't work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108995/ --- Review request for Amarok. Description --- 1. Disabled Pre-amplifier