Re: Review Request: visualization: it works

2011-08-10 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/#review5564 --- src/audiodatacenter/CMakeLists.txt

Re: Review Request: visualization: it works

2011-08-10 Thread Alessandro Siniscalchi
> On Aug. 10, 2011, 12:02 a.m., Harald Sitter wrote: > > plenty of full path usage, which is not scalable on linux and particularly > > not in xplatform context + wrong code style Hi Harald, tell me more about the wrong code style please. - Alessandro ---

Re: Review Request: visualization: it works

2011-08-10 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- (Updated Aug. 10, 2011, 2:55 a.m.) Review request for Amarok and Phonon.

Re: Review Request: visualization: it works

2011-08-09 Thread Sam Lade
> On Aug. 10, 2011, 12:02 a.m., Harald Sitter wrote: > > plenty of full path usage, which is not scalable on linux and particularly > > not in xplatform context + wrong code style > > Alessandro Siniscalchi wrote: > Hi Harald, > tell me more about the wrong code style please. > > Haral

Re: Review Request: visualization: it works

2011-08-09 Thread Harald Sitter
> On Aug. 10, 2011, 12:02 a.m., Harald Sitter wrote: > > plenty of full path usage, which is not scalable on linux and particularly > > not in xplatform context + wrong code style > > Alessandro Siniscalchi wrote: > Hi Harald, > tell me more about the wrong code style please. look at t

Re: Review Request: visualization: it works

2011-08-09 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/#review5558 --- plenty of full path usage, which is not scalable on linux and pa

Re: Review Request: visualization: it works

2011-08-09 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- (Updated Aug. 8, 2011, 1:26 p.m.) Review request for Amarok and Phonon.

Re: Review Request: visualization: it works

2011-08-09 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- (Updated Aug. 8, 2011, 11:56 a.m.) Review request for Amarok and Phonon.

Re: Review Request: visualization: it works

2011-08-09 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- (Updated Aug. 8, 2011, 11:28 a.m.) Review request for Amarok and Phonon.

Re: Review Request: visualization: it works

2011-08-09 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- (Updated Aug. 8, 2011, 11:29 a.m.) Review request for Amarok and Phonon.

Re: Review Request: visualization: it works

2011-08-07 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- (Updated Aug. 7, 2011, 2:40 p.m.) Review request for Amarok and Phonon.

Review Request: visualization: it works

2011-08-07 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- Review request for Amarok and Phonon. Summary --- I added two modules

Re: Review Request: visualization: it works

2011-08-07 Thread Alessandro Siniscalchi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102243/ --- (Updated Aug. 7, 2011, 12:34 p.m.) Review request for Amarok and Phonon.