Re: Review Request: phonon phive core frontend api

2012-11-08 Thread Harald Sitter
> On Sept. 29, 2012, 12:26 p.m., Matěj Laitl wrote: > > core/Player.h, lines 42-44 > > > > > > aboutToFinish() gone? > > > > I wanted to comment on aboutToFinish() - it is currently very tricky to > > use t

Re: Review Request: phonon phive core frontend api

2012-10-12 Thread Harald Sitter
> On Sept. 26, 2012, 7:42 p.m., Bart Cerneels wrote: > > core/Player.h, line 52 > > > > > > no. Total can be unknown and it's a one line calculation. > > Matěj Laitl wrote: > But Phonon may know the length bette

Re: Review Request: phonon phive core frontend api

2012-09-30 Thread Bart Cerneels
> On Sept. 26, 2012, 7:42 p.m., Bart Cerneels wrote: > > core/Player.h, line 39 > > > > > > Should be addAudioOutput and addVideoOutput if you want to keep them > > separate. > > Matěj Laitl wrote: > Why? The

Re: Review Request: phonon phive core frontend api

2012-09-29 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106566/#review19569 --- core/Player.h

Re: Review Request: phonon phive core frontend api

2012-09-29 Thread Matěj Laitl
> On Sept. 26, 2012, 7:42 p.m., Bart Cerneels wrote: > > core/Player.h, line 39 > > > > > > Should be addAudioOutput and addVideoOutput if you want to keep them > > separate. Why? > On Sept. 26, 2012, 7:42 p.m.,

Re: Review Request: phonon phive core frontend api

2012-09-26 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106566/#review19473 --- Live review at Randa by Harald, Mark and me. Some comments mine

Review Request: phonon phive core frontend api

2012-09-25 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106566/ --- Review request for Amarok and Phonon. Description --- phonon phive co