Re: Review Request: mysql embedded default options

2012-08-16 Thread Ralf Engels
> On May 25, 2011, 7:30 p.m., Ralf Engels wrote: > > A summary of this discussion. Please check the correct answer. > > A: this patch is still fine and should be shipped > > B: this patch is working around a known bug and should be shipped > > C: this patch is working around a known bug, which is

Re: Review Request: mysql embedded default options

2012-02-28 Thread Myriam Schweingruber
> On May 25, 2011, 7:30 p.m., Ralf Engels wrote: > > A summary of this discussion. Please check the correct answer. > > A: this patch is still fine and should be shipped > > B: this patch is working around a known bug and should be shipped > > C: this patch is working around a known bug, which is

Re: Review Request: mysql embedded default options

2011-05-25 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100345/#review3523 --- A summary of this discussion. Please check the correct answer. A

Re: Review Request: mysql embedded default options

2011-03-05 Thread Jeff Mitchell
> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent. > > > > Surely there is a

Re: Review Request: mysql embedded default options

2011-03-05 Thread Ian Monroe
> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent. > > > > Surely there is a

Re: Review Request: mysql embedded default options

2011-03-05 Thread Ian Monroe
> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent. > > > > Surely there is a

Re: Review Request: mysql embedded default options

2011-03-05 Thread Ian Monroe
> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent. > > > > Surely there is a

Re: Review Request: mysql embedded default options

2011-01-11 Thread Jeff Mitchell
> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent. > > > > Surely there is a

Re: Review Request: mysql embedded default options

2011-01-10 Thread Ian Monroe
> On Jan. 11, 2011, 5 a.m., Ian Monroe wrote: > > The current way we do it is because if you have a MySQL that randomly > > doesn't support whatever argument you are trying to use, Bad Things Happen. > > If you look at the history of this code it is quite turbulent. > > > > Surely there is a

Re: Review Request: mysql embedded default options

2011-01-10 Thread Ian Monroe
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100345/#review829 --- The current way we do it is because if you have a MySQL that rand

Re: Review Request: mysql embedded default options

2011-01-10 Thread Mark Kretschmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100345/#review825 --- Have not yet tested, will do later. In general it sounds like a g

Review Request: mysql embedded default options

2011-01-10 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100345/ --- Review request for Amarok. Summary --- The mysql embedded library doe