Re: Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107161/#review21726 --- Ship it! Ship it. Just please convert "else return false;" in

Re: Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107161/ --- (Updated Nov. 9, 2012, 4 p.m.) Review request for Amarok, Edward Hades Tor

Re: Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107161/#review21714 --- The code looks good, altough I'm against copying documentation

Re: Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

> On Nov. 6, 2012, 3:58 a.m., Vishesh Handa wrote: > > src/core-impl/collections/nepomukcollection/NepomukCollection.cpp, line 117 > > > > > > In the Nepomuk code I generally prefer a 'using namespace > > Nepomuk::

Re: Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107161/ --- (Updated Nov. 9, 2012, 2:24 p.m.) Review request for Amarok, Edward Hades

Re: Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107161/#review21472 --- src/core-impl/collections/nepomukcollection/NepomukCollection.

Review Request: TrackProvider non virtual functions implemented for Nepomuk Collection

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107161/ --- Review request for Amarok, Edward Hades Toroshchin and Vishesh Handa. Desc