Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104213/#review11494 --- This review has been submitted with commit 1a0287f7925d92a05a5

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-16 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104213/ --- (Updated March 16, 2012, 4:01 p.m.) Review request for Amarok and Teo Mrnj

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-15 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104213/#review11442 --- Ship it! I believe it is completely justified to introduce a c

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-15 Thread Teo Mrnjavac
> On March 14, 2012, 11:10 a.m., Bart Cerneels wrote: > > Screenshot: Revamped Transcode dialog > > > > > > This is hard to understand and contains some language errors. Perhaps > > "Use this for next tracks" ? > > Matěj Laitl wrote: > I particularly suc

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-14 Thread Bart Cerneels
> On March 14, 2012, 11:10 a.m., Bart Cerneels wrote: > > Screenshot: Changes to the Configure Collection dialog > > > > > > If there are <= 3 options, don't use a combobox. > > Matěj Laitl wrote: > Yup, there are 2 or 3. Should I use radio buttons? Use

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-14 Thread Matěj Laitl
> On March 14, 2012, 11:10 a.m., Bart Cerneels wrote: > > I think in this case the use of a Capability is completely justified. It's > > the Capabilities that just add complexity that are problematic. Thanks for review! > On March 14, 2012, 11:10 a.m., Bart Cerneels wrote: > > Screenshot: Cha

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-14 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104213/#review11394 --- Ship it! I think in this case the use of a Capability is compl

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-11 Thread Matěj Laitl
On 10. 3. 2012 Julian Simioni wrote: > Hi Matěj, > Side question: you refer to an "in-the-works" ipod collection. Is this work > in the main amarok git repository? If not, can you tell me where to find > it? You can find it in the ipod-rewrite branch (which contains reworked transcoding) of my Am

Re: Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-11 Thread Julian Simioni
Hi Matěj*, *Side question: you refer to an "in-the-works" ipod collection. Is this work in the main amarok git repository? If not, can you tell me where to find it? Thanks, Julian On Fri, Mar 9, 2012 at 3:31 PM, Matěj Laitl wrote: >This is an automatically generated e-mail. To reply, visit:

Review Request: Rework transcoding: remember encoder, transcode on move, cleaner code

2012-03-09 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104213/ --- Review request for Amarok and Teo Mrnjavac. Description --- Rework tr