Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

2012-08-16 Thread Matěj Laitl
> On April 22, 2012, 5:28 p.m., Matěj Laitl wrote: > > This makes sense, give me some time to test it and think about it. > > Ralf Engels wrote: > Thought about it? > Should we ship it? The #include fixes are definitly right, including completely circumvents CMake taglib detection. In

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

2012-08-16 Thread Ralf Engels
> On April 22, 2012, 5:28 p.m., Matěj Laitl wrote: > > This makes sense, give me some time to test it and think about it. Thought about it? Should we ship it? - Ralf --- This is an automatically generated e-mail. To reply, visit: http:/

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

2012-05-31 Thread Mathias Stephan Panzenböck
> On May 26, 2012, 3:21 p.m., Ralf Engels wrote: > > src/CMakeLists.txt, line 1015 > > > > > > There is a block linking the taglib just a few lines previously. > > Around 922 > > > > Why do you need th

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

2012-05-26 Thread Ralf Engels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104693/#review14179 --- src/CMakeLists.txt

Re: Review Request: Make Amarok compile and link with TagLib installed in $HOME

2012-04-22 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104693/#review12799 --- This makes sense, give me some time to test it and think about

Review Request: Make Amarok compile and link with TagLib installed in $HOME

2012-04-22 Thread Mathias Stephan Panzenböck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104693/ --- Review request for Amarok. Description --- I installed TagLib 1.8-GIT