Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review993 --- Ship it! The release is out, so now we can commit it. - Ralf

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review918 --- Still works, and still has functional advantages over current Met

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated Jan. 12, 2011, 1:58 p.m.) Review request for Amarok. Changes --

Re: Review Request: File tag handler refactoring

2011/1/8 Lukas <1luk...@gmail.com> > Great work :) > > But the yellow and green hurts my eyes a bit. You could try to get some > matching, still dark enough colors with the help of > http://kuler.adobe.com or http://colorschemedesigner.com. Also *bold*could > help :) > > Well, these colors where

Re: Review Request: File tag handler refactoring

Great work :) But the yellow and green hurts my eyes a bit. You could try to get some matching, still dark enough colors with the help of http://kuler.adobe.comor http://colorschemedesigner.com. Also *bold* could help :) On 7 January 2011 22:29, Sergey Ivanov <123k...@gmail.com> wrote: >Thi

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2011-01-07 20:29:46.128664) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-21 13:21:19.978675) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-20 15:05:55.778862) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-18 13:55:38.595673) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

> On 2010-12-14 14:49:42, Stefan Derkits wrote: > > shared/FileType.h, line 42 > > > > > > RealAudio is missing ... maybe some other Types > > Sergey Ivanov wrote: > A lot of them. Added only types supported by ta

Re: Review Request: File tag handler refactoring

> On 2010-12-14 14:49:42, Stefan Derkits wrote: > > shared/FileType.h, line 42 > > > > > > RealAudio is missing ... maybe some other Types A lot of them. Added only types supported by taglib, but not listed before.

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review555 --- shared/FileType.h

Re: Review Request: File tag handler refactoring

> On 2010-12-13 12:13:59, Ralf Engels wrote: > > Looks nice, > > can we delay the integration until Amarok 2.4 is out? > > Stefan Derkits wrote: > The additional Filetypes in Filetype.h and Filetype.cpp could be cool if > they are already in 2.4, cause in 2.4 the Display of the Filetypes is

Re: Review Request: File tag handler refactoring

> On 2010-12-13 12:13:59, Ralf Engels wrote: > > Looks nice, > > can we delay the integration until Amarok 2.4 is out? > > Stefan Derkits wrote: > The additional Filetypes in Filetype.h and Filetype.cpp could be cool if > they are already in 2.4, cause in 2.4 the Display of the Filetypes is

Re: Review Request: File tag handler refactoring

> On 2010-12-13 12:13:59, Ralf Engels wrote: > > Looks nice, > > can we delay the integration until Amarok 2.4 is out? The additional Filetypes in Filetype.h and Filetype.cpp could be cool if they are already in 2.4, cause in 2.4 the Display of the Filetypes is taken from the Database (and als

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review517 --- Looks nice, can we delay the integration until Amarok 2.4 is out?

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-11 11:52:39.805321) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-08 22:15:26.453918) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- (Updated 2010-12-06 19:39:13.412353) Review request for Amarok. Changes

Re: Review Request: File tag handler refactoring

> On 2010-12-06 12:50:51, Jeff Mitchell wrote: > > I can't tell from the diff if charset detector is on by default with your > > new patch, but it shouldn't be. > > > > It causes far more problems than it solves, which is why people have to > > explicitly request it now. Nope, there is no cha

Re: Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/#review458 --- I can't tell from the diff if charset detector is on by default w

Review Request: File tag handler refactoring

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ --- Review request for Amarok. Summary --- Rewrite tag reading stuff to m