Re: Review Request: Do not return collectionFolders() unless ready.

2012-06-14 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105246/#review14732 --- Ship it! Go for it then. - Matěj Laitl On June 13, 2012, 8:

Re: Review Request: Do not return collectionFolders() unless ready.

2012-06-14 Thread Matěj Laitl
> On June 14, 2012, 11:06 a.m., Matěj Laitl wrote: > > src/MountPointManager.cpp, line 331 > > > > > > Hmmm, IMO this can be a source of subtle bugs where calling this > > important method is dependent on when it i

Re: Review Request: Do not return collectionFolders() unless ready.

2012-06-14 Thread Edward Hades Toroshchin
> On June 14, 2012, 11:06 a.m., Matěj Laitl wrote: > > src/MountPointManager.cpp, line 331 > > > > > > Hmmm, IMO this can be a source of subtle bugs where calling this > > important method is dependent on when it i

Re: Review Request: Do not return collectionFolders() unless ready.

2012-06-14 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105246/#review14729 --- src/MountPointManager.cpp