Re: Review Request: Add composer button to wikipedia applet

2012-03-26 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327/#review11865 --- Just found out about the Wikipedia applet having separate langu

Re: Review Request: Add composer button to wikipedia applet

2012-03-26 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327/ --- (Updated March 26, 2012, 6:50 a.m.) Review request for Amarok. Changes -

Re: Review Request: Add composer button to wikipedia applet

2012-03-26 Thread Matěj Laitl
> On March 18, 2012, 10:22 a.m., Matěj Laitl wrote: > > src/context/engines/wikipedia/WikipediaEngine.cpp, line 462 > > > > > > Hmm, why don't we use i18nc() for creating the pattern here? Something > > with a very

Re: Review Request: Add composer button to wikipedia applet

2012-03-20 Thread Ryan McCoskrie
> On March 18, 2012, 10:22 a.m., Matěj Laitl wrote: > > src/context/engines/wikipedia/WikipediaEngine.cpp, line 462 > > > > > > Hmm, why don't we use i18nc() for creating the pattern here? Something > > with a very

Re: Review Request: Add composer button to wikipedia applet

2012-03-20 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327/ --- (Updated March 19, 2012, 8:55 p.m.) Review request for Amarok. Changes -

Re: Review Request: Add composer button to wikipedia applet

2012-03-18 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327/#review11530 --- The patch looks good, thanks for it! There are 2 smaller issues

Review Request: Add composer button to wikipedia applet

2012-03-18 Thread Ryan McCoskrie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104327/ --- Review request for Amarok. Description --- Adds a new composer button