Re: Review Request: Add a CMake switch for building playground

2011-08-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102077/#review5670 --- This review has been submitted with commit b7a6d93096361e55895b

Re: Review Request: Add a CMake switch for building playground

2011-08-10 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102077/#review5574 --- Ship it! Looks fine, I don't see any reasons against this. And

Re: Review Request: Add a CMake switch for building playground

2011-08-09 Thread Martin Blumenstingl
> On Aug. 8, 2011, 6:14 p.m., Martin Blumenstingl wrote: > > Sorry, it seems that reviewboard ate my comment :( Here's the original text: Please speak up in the next few days if something speaks AGAINST committing this (otherwise I'll commit next week). The patch itself is pretty straight forw

Re: Review Request: Add a CMake switch for building playground

2011-08-09 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102077/#review5520 --- - Martin On July 24, 2011, 6:29 p.m., Martin Blumenstingl wrot

Review Request: Add a CMake switch for building playground

2011-07-24 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102077/ --- Review request for Amarok. Summary --- It seems that up to now everyo