Re: Review Request 130142: AAC support was broken due to ffmpeg deprecating the currently-used libfaac transcoder. Reworked to test for the new one.

2018-02-04 Thread Russell Andres
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 83c7357f0712aeeccbf083bc9462865f6acecf9e by Stefano Pettini to branch master. Repository: amarok Description --- Working AAC format detection and transcoding option. I have to admit that most of this

Re: Review Request 130142: AAC support was broken due to ffmpeg deprecating the currently-used libfaac transcoder. Reworked to test for the new one.

2018-02-04 Thread Stefano Pettini
org/r/130142/ > --- > > (Updated May 26, 2017, 2:22 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Working AAC format detection and transcoding option. I have to admit that > most of this work was done by a helpf

Re: Review Request 129237: [amarok] Try port services to KF5

2017-09-26 Thread Anthony Fieroni
been discarded. Review request for Amarok. Repository: amarok Description --- I try to enable services in KF5 branch, amarok to be usable, but problems still present Diffs - src/CMakeLists.txt e777540 src/MainWindow.cpp c8ca2fe src/main.cpp c7e235b src/services/ampache

Re: Review Request 130232: Fix crash during musicbrainz search

2017-08-23 Thread Sergey Ivanov
il. To reply, visit: > https://git.reviewboard.kde.org/r/130232/ > ----------- > > (Updated Авг. 23, 2017, 3:40 п.п.) > > > Review request for Amarok. > > > Bugs: 328359 > https://bugs.kde.org/show_bug.cgi?id=328359 > > > Repository:

Re: Review Request 130232: Fix crash during musicbrainz search

2017-08-23 Thread Christoph Feck
anov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130232/ > --- > > (Updated Aug. 23, 2017, 5:40 p

Re: Review Request 130232: Fix crash during musicbrainz search

2017-08-23 Thread Sergey Ivanov
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 88ee85a8333cf54dc123fef5e07a1c92ab9f7261 by Sergey Ivanov to branch master. Bugs: 328359 https://bugs.kde.org/show_bug.cgi?id=328359 Repository: amarok Description --- + Fixed search result

Re: Review Request 130232: Fix crash during musicbrainz search

2017-08-22 Thread Myriam Schweingruber
Updated Aug. 19, 2017, 1:06 p.m.) > > > Review request for Amarok. > > > Bugs: 328359 > https://bugs.kde.org/show_bug.cgi?id=328359 > > > Repository: amarok > > > Description > --- > > + Fixed search result appending process to

Re: Review Request 130232: Fix crash during musicbrainz search

2017-08-19 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130232/ --- (Updated Авг. 19, 2017, 11:06 д.п.) Review request for Amarok. Summary

Review Request 130232: Fix crush during musicbrainz search

2017-08-19 Thread Sergey Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130232/ --- Review request for Amarok. Bugs: 328359 https://bugs.kde.org

Re: Review Request 130142: AAC support was broken due to ffmpeg deprecating the currently-used libfaac transcoder. Reworked to test for the new one.

2017-05-31 Thread Russell Andres
automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130142/ > --- > > (Updated May 26, 2017, 12:22 a.m.) > > > Review request for Amarok. > > > Repository: amarok > >

Re: Review Request 130142: AAC support was broken due to ffmpeg deprecating the currently-used libfaac transcoder. Reworked to test for the new one.

2017-05-30 Thread Myriam Schweingruber
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130142/ > --- > > (Updated May 26, 2017, 2:22 a.m.) > > > Review request for Amarok. > > >

Review Request 130142: AAC support was broken due to ffmpeg deprecating the currently-used libfaac transcoder. Reworked to test for the new one.

2017-05-25 Thread Russell Andres
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130142/ --- Review request for Amarok. Repository: amarok Description

Re: Review Request 129192: Add namespace to desktop and appdata files

2017-02-26 Thread Luigi Toscano
marked as submitted. Review request for Amarok and Matthias Klumpp. Changes --- Submitted with commit 22e0ac2baf0975a1dabbfa7892f8c52c38990235 by Luigi Toscano to branch master. Repository: amarok Description --- - add the organization namespace to the desktop and then appdata

Re: Review Request 129192: Add namespace to desktop and appdata files

2017-02-26 Thread Matěj Laitl
-- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Říj. 16, 2016, 4:12 odp.) > > > Review request for Amarok and Matthias Klu

Re: Review Request 129192: Add namespace to desktop and appdata files

2017-02-26 Thread Matthias Klumpp
--- On Oct. 16, 2016, 2:12 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ >

Re: Review Request 129192: Add namespace to desktop and appdata files

2017-02-26 Thread Luigi Toscano
rated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > ------- > > (Updated Ott. 16, 2016, 4:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > --- > > - add the organizatio

Re: Review Request 113386: GSoC 2013 Revamping Scripting - Part 3/6 : Scripts

2017-02-25 Thread Albert Astals Cid
pdated Oct. 22, 2013, 4:07 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Changes made to bundled scripts. > > > Diffs > - > > src/scripts/librivox_service/main.js 06035af >

Re: Review Request 129192: Add namespace to desktop and appdata files

2017-02-23 Thread Matěj Laitl
scano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Říj. 16, 2016, 4:12 od

Re: Review Request 129192: Add namespace to desktop and appdata files

2017-02-23 Thread Luigi Toscano
de.org/r/129192/ > --- > > (Updated Oct. 16, 2016, 4:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > --- > > - add the org

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2017-02-17 Thread Heiko Becker
This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126682/ > --- > > (Updated Jan. 9, 2016, 7:24 vorm.) > > > Review request for Amarok. > > > Repository: am

Re: Review Request 122797: Fix Gpodder credential service without kwallet

2017-02-17 Thread Heiko Becker
viewboard.kde.org/r/122797/ > --- > > (Updated Feb. 17, 2017, 8:46 nachm.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Before to fix this bu

Re: Review Request 122797: Fix Gpodder credential service without kwallet

2017-02-17 Thread Giuseppe Silletti
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 32de657700902551f600de836021361ef965bb36 by Heiko Becker on behalf of Giuseppe Silletti to branch master. Repository: amarok Description --- Before to fix this bug, the gpodder plugin had problems

Re: Review Request 129626: Fix amarok build with ffmpeg 3+.

2017-02-12 Thread Alexis BALLIER
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 5535be8635d3f74ccc774ee28e0804d7aaeeec41 by Andreas Sturmlechner on behalf of Alexis BALLIER to branch master. Repository: amarok Description --- Fix amarok build with ffmpeg 3+. Diffs - src

Re: Review Request 129920: Replace Deprecated AV Functions (fix bug 362409)

2017-02-05 Thread Dominik Waurenschk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129920/ --- (Updated Feb. 5, 2017, 8:16 p.m.) Review request for Amarok. Summary

Review Request 129926: Add nullptr check to prevent possible crash when getting MusicBrianz tags

2017-02-05 Thread Dominik Waurenschk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129926/ --- Review request for Amarok. Repository: amarok Description

Review Request 129920: Replace Deprecated AV Functions

2017-02-04 Thread Dominik Waurenschk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129920/ --- Review request for Amarok. Repository: amarok Description

Re: Review Request 100176: Fetch cover for DAAP Albums #240060

2017-02-04 Thread Albert Astals Cid
> On April 5, 2013, 8:33 p.m., Albert Astals Cid wrote: > > If this doesn't get any action before my next janitorial round I'll discard > > the Review Request understanding nooone cares enough to push this forward. > > Matěj Laitl wrote: > Looking at the c

Re: Review Request 123635: Fix minor typo in PlaylistLengthEditWidget.ui

2017-02-04 Thread Robert Marshall
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 0feb6251925fe049c46ccf5153db4b467f3544fb by Albert Astals Cid on behalf of Robert Marshall to branch master. Repository: amarok Description --- add the word 'specify' to text Diffs --

Re: Review Request 116641: Fixes Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track

2017-02-04 Thread yash ladia
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 2a8cb3785e50ccb0d551442e3133ac1cc6c2e8f7 by Albert Astals Cid on behalf of Yash Ladia to branch master. Bugs: 302299 https://bugs.kde.org/show_bug.cgi?id=302299 Repository: amarok Description

Re: Review Request 123635: Fix minor typo in PlaylistLengthEditWidget.ui

2017-02-04 Thread Albert Astals Cid
generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123635/ > ----------- > > (Updated May 4, 2015, 8:15 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description

Re: Review Request 126195: fix filename colouring in the tag guessing dialog

2017-01-22 Thread Albert Astals Cid
> On Feb. 2, 2016, 6:34 a.m., Matthias Berndt wrote: > > Ship It! > > Myriam Schweingruber wrote: > erm, you can't call ship it on your own requests, that would counteract > the sense of the review request :-) > > Albert Astals Cid wrote: > I sugg

Re: Review Request 126195: fix filename colouring in the tag guessing dialog

2017-01-22 Thread Matthias Berndt
discarded. Review request for Amarok. Repository: amarok Description --- Currently in the tag guessing dialog a coloured version of the file name is shown. The colours indicate where the individual tag values are taken from. If any of the tag values appears twice in the file name, both

Re: Review Request 126195: fix filename colouring in the tag guessing dialog

2017-01-22 Thread Matthias Berndt
> On Feb. 2, 2016, 6:34 vorm., Matthias Berndt wrote: > > Ship It! > > Myriam Schweingruber wrote: > erm, you can't call ship it on your own requests, that would counteract > the sense of the review request :-) > > Albert Astals Cid wrote: > I sugg

Re: Review Request 122797: Fix Gpodder credential service without kwallet

2017-01-20 Thread Albert Astals Cid
d.kde.org/r/122797/ > ----------- > > (Updated March 3, 2015, 9:14 p.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Before to fix this bug, the gpod

Re: Review Request 126195: fix filename colouring in the tag guessing dialog

2017-01-20 Thread Albert Astals Cid
> On Feb. 2, 2016, 6:34 a.m., Matthias Berndt wrote: > > Ship It! > > Myriam Schweingruber wrote: > erm, you can't call ship it on your own requests, that would counteract > the sense of the review request :-) I suggest you create a new review request, reviewer

Re: Review Request 129633: Bug 335217 means that show in media sources doesn't expand trees, this patch adds a user option

2016-12-09 Thread Robert Marshall
discarded. Review request for Amarok. Repository: amarok Description --- Allow the user to expand and collapse selections - this is an attempt to put back functionality lost by [Bug 335217]. I reused an existing icon which probably isn't ideal! Diffs - src/bro

Review Request 129633: Bug 335217 means that show in media sources doesn't expand trees, this patch adds a user option

2016-12-09 Thread Robert Marshall
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129633/ --- Review request for Amarok. Repository: amarok Description

Review Request 129626: Fix amarok build with ffmpeg 3+.

2016-12-08 Thread Alexis BALLIER
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129626/ --- Review request for Amarok. Repository: amarok Description --- Fix

Re: Review Request 129237: [amarok] Try port services to KF5

2016-11-25 Thread Anthony Fieroni
gt; https://git.reviewboard.kde.org/r/129237/ > --- > > (Updated Окт. 21, 2016, 5:01 след обяд) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > I

Re: Review Request 129237: [amarok] Try port services to KF5

2016-11-25 Thread Anthony Fieroni
wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129237/ > --- > > (Updated Окт. 21, 2016, 5:01 след обяд) > &

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-11-07 Thread Luigi Toscano
-- On Ott. 16, 2016, 4:12 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > ------

Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).

2016-10-23 Thread Alexandr Akulich
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 0b2b243b2b70471c32d282157624379da5214051 by Alexandr Akulich to branch kf5. Repository: amarok Description --- There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569dee8b4725 : ```diff

Review Request 129237: [amarok] Try port services to KF5

2016-10-21 Thread Anthony Fieroni
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129237/ --- Review request for Amarok. Repository: amarok Description --- I

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matthias Klumpp
> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > ------- > > (Updated Oct. 16, 2016, 2:12 p.m.) > > > Review request for Amarok and Matth

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
--- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > ------- > > (Updated Ott. 16, 2016, 4:12 p.m.) > > >

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matthias Klumpp
gt; https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Oct. 16, 2016, 2:12 p.m.) > > > Review request for Amarok and Matthias Klumpp. > > > Repository: amarok > > > Description > --- > > - add the organization

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matthias Klumpp
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated Oct. 16, 2016, 2:12 p.m.) > > > Review request for Amarok and Matthias Klum

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:12 p.m.) Review request for Amarok and

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:10 p.m.) Review request for Amarok and

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Luigi Toscano
-- On Ott. 15, 2016, 9:44 p.m., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --

Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).

2016-10-16 Thread Alexandr Akulich
ttps://git.reviewboard.kde.org/r/129055/ > --- > > (Updated Сен. 28, 2016, 1:13 д.п.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > There is a change at commit c3c4c7b8ebc4bc9ec94394f5d3a5569

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matěj Laitl
6, 9:44 odp., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129192/ > --- > > (Updated

Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).

2016-10-16 Thread Matěj Laitl
: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129055/ > --- > > (Updated Zář. 27, 2016, 10:13 odp.) > > > Review request for Amar

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matěj Laitl
d.kde.org/r/129192/ > --- > > (Updated Říj. 15, 2016, 9:44 odp.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > - add the organization namespace to the desktop and then appdata files, > a

Review Request 129192: Add namespace to desktop and appdata files

2016-10-15 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- Review request for Amarok. Repository: amarok Description

Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).

2016-09-27 Thread Alexandr Akulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129055/ --- Review request for Amarok. Repository: amarok Description

Re: Review Request 128418: Fix MPRIS2 DesktopEntry value

2016-08-20 Thread Antonio Rojas
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 9449ec56d1fd77a0bfa1f7134a2bf4f91ffd14d3 by Mat?j Laitl on behalf of Antonio Rojas to branch master. Bugs: 365275 https://bugs.kde.org/show_bug.cgi?id=365275 Repository: amarok Description

Re: Review Request 127458: Fix for warnings, one of them a probable bug

2016-08-20 Thread Stefano Pettini
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 970e985d6100070aa105dd602da8c294687385ac by Mat?j Laitl on behalf of Stefano Pettini to branch master. Repository: amarok Description --- This fixes some minor C++ warnings: one unused variable and

Re: Review Request 128565: Presets persisted properly for "Organize tracks" and "Guess tags" dialogs

2016-08-20 Thread Stefano Pettini
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 0e760e5f8d06d00e084c14b64875f58bb42bd8f1 by Mat?j Laitl on behalf of Stefano Pettini to branch master. Bugs: 226144 https://bugs.kde.org/show_bug.cgi?id=226144 Repository: amarok Description

Re: Review Request 128565: Presets persisted properly for "Organize tracks" and "Guess tags" dialogs

2016-08-16 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128565/ --- (Updated Aug. 16, 2016, 4:31 p.m.) Review request for Amarok. Changes

Re: Review Request 128565: Organize tracks and Guess tags presets persisted properly

2016-08-11 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128565/ --- (Updated Aug. 11, 2016, 10:50 p.m.) Review request for Amarok. Changes

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-08-07 Thread Stefano Pettini
marked as submitted. Review request for Amarok. Changes --- Submitted with commit bdbb3a27f556c41910d3b814e5a4c73a2a93362f by Mat?j Laitl on behalf of Stefano Pettini to branch master. Bugs: 314854 https://bugs.kde.org/show_bug.cgi?id=314854 Repository: amarok Description

Re: Review Request 128245: Length, but also any other numeric field, not properly handled in filter dialogs

2016-08-07 Thread Stefano Pettini
marked as submitted. Review request for Amarok. Changes --- Submitted with commit 6c49cfdfd97faa146ce7b0d8e95ce2bf596f2b0d by Mat?j Laitl on behalf of Stefano Pettini to branch master. Bugs: 341661 https://bugs.kde.org/show_bug.cgi?id=341661 Repository: amarok Description

Re: Review Request 128157: Handle removed --myisam-recover option in MySQL 5.7

2016-08-07 Thread Stefano Pettini
marked as submitted. Review request for Amarok. Changes --- Submitted with commit a07f44ddcd61bac1bb2f1e17cfc07d40a940bb5a by Mat?j Laitl on behalf of Terje Rosten to branch master. Bugs: 354255 https://bugs.kde.org/show_bug.cgi?id=354255 Repository: amarok Description

Re: Review Request 128565: Organize tracks and Guess tags presets persisted properly

2016-08-03 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128565/ --- (Updated Aug. 4, 2016, 2:08 a.m.) Review request for Amarok. Changes

Review Request 128565: Organize tracks and Guess tags presets persisted properly

2016-07-31 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128565/ --- Review request for Amarok. Bugs: 226144 https://bugs.kde.org

Re: Review Request 128418: Fix MPRIS2 DesktopEntry value

2016-07-30 Thread Rex Dieter
-- > > (Updated July 10, 2016, 10:12 a.m.) > > > Review request for Amarok. > > > Bugs: 365275 > https://bugs.kde.org/show_bug.cgi?id=365275 > > > Repository: amarok > > > Description > --- > > According to the MPRIS2 spec, the Deskt

Re: Review Request 128418: Fix MPRIS2 DesktopEntry value

2016-07-30 Thread Rex Dieter
y 10, 2016, 10:12 a.m.) > > > Review request for Amarok. > > > Bugs: 365275 > https://bugs.kde.org/show_bug.cgi?id=365275 > > > Repository: amarok > > > Description > --- > > According to the MPRIS2 spec, the DesktopEntry value should b

Re: Review Request 128418: Fix MPRIS2 DesktopEntry value

2016-07-17 Thread Kai Uwe Broulik
visit: > https://git.reviewboard.kde.org/r/128418/ > --- > > (Updated Juli 10, 2016, 10:12 vorm.) > > > Review request for Amarok. > > > Bugs: 365275 > https://bugs.kde.org/show_bug.cgi?id=365275

Review Request 128468: Allow BPM to be used by the track (re)naming tool (collection management).

2016-07-16 Thread Michel Hermier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128468/ --- Review request for Amarok. Repository: amarok Description

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2016-07-12 Thread Aditya Dev Sharma
discarded. Review request for Amarok, Olivier Churlaud, Myriam Schweingruber, and Bart Cerneels. Bugs: 300979 https://bugs.kde.org/show_bug.cgi?id=300979 Repository: amarok Description --- JJ : Bug - 300979 : Patch to add some shortcuts for various actions in createActions() in

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2016-07-12 Thread Aditya Dev Sharma
viewboard.kde.org/r/124773/ > --- > > (Updated Sept. 15, 2015, 5:18 p.m.) > > > Review request for Amarok, Olivier Churlaud, Myriam Schweingruber, and Bart > Cerneels. > > > Bugs: 300979 > https://bugs.kde.org/show_bug.cgi?id=300979 > > > Rep

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2016-07-12 Thread Olivier Churlaud
.kde.org/r/124773/ > --- > > (Updated Sept. 15, 2015, 7:18 p.m.) > > > Review request for Amarok, Olivier Churlaud, Myriam Schweingruber, and Bart > Cerneels. > > > Bugs: 300979 > https://bugs.kde.org/show_bug.cgi?id=300979 > > > Repository:

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-07-12 Thread Myriam Schweingruber
viewboard.kde.org/r/128246/ > --- > > (Updated July 10, 2016, 11:13 p.m.) > > > Review request for Amarok. > > > Bugs: 314854 > https://bugs.kde.org/show_bug.cgi?id=314854 > > > Repository: amarok

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-07-11 Thread Matěj Laitl
Čec. 10, 2016, 11:13 odp.) > > > Review request for Amarok. > > > Bugs: 314854 > https://bugs.kde.org/show_bug.cgi?id=314854 > > > Repository: amarok > > > Description > --- > > This makes the lyrics browser similar to every other

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-07-10 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/ --- (Updated July 10, 2016, 11:13 p.m.) Review request for Amarok. Changes

Re: Review Request 128245: Length, but also any other numeric field, not properly handled in filter dialogs

2016-07-10 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128245/ --- (Updated July 10, 2016, 11:04 p.m.) Review request for Amarok. Changes

Review Request 128418: Fix MPRIS2 DesktopEntry value

2016-07-10 Thread Antonio Rojas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128418/ --- Review request for Amarok. Bugs: 365275 https://bugs.kde.org

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2016-06-21 Thread Olivier Churlaud
--- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126682/ > ------- > > (Updated Jan. 9, 2016, 7:24 a.m.) > > > Review request for Amarok. > > > Repository: amar

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2016-06-20 Thread Sergey Ivanov
. 9, 2016, 6:24 д.п., Diane Trout wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126682/ > --- > > (Updated Янв. 9, 2016, 6:24 д.п.) > > > Revi

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2016-06-20 Thread Olivier Churlaud
, Diane Trout wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126682/ > --- > > (Updated Jan. 9, 2016, 7:24 a.m.) > > > Revi

Re: Review Request 128265: Fix compilation with ffmpeg 3.0

2016-06-20 Thread Olivier Churlaud
discarded. Review request for Amarok. Repository: amarok Description --- Change deprecated code See: https://ffmpeg.org/pipermail/ffmpeg-cvslog/2013-December/071930.html Diffs - src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b Diff: https://git.reviewboard.kde.org/r/128265

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2016-06-20 Thread Olivier Churlaud
an. 9, 2016, 7:24 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > See API change documentation: > https://anonscm.debian.org/cgit/collab-maint/ffmpeg.git/tree/doc/APIchanges > https://wiki.liba

Re: Review Request 128265: Fix compilation with ffmpeg 3.0

2016-06-20 Thread Olivier Churlaud
: > https://git.reviewboard.kde.org/r/128265/ > --- > > (Updated June 21, 2016, 12:32 a.m.) > > > Review request for Amarok. > > > Repository: amarok > > > Description > --- > > Change deprecated code &

Review Request 128265: Fix compilation with ffmpeg 3.0

2016-06-20 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128265/ --- Review request for Amarok. Repository: amarok Description

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128248/ > ------- > > (Updated June 21, 2016, 12:17 a.m.) > > > Review request for Amarok

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
marked as submitted. Review request for Amarok and Myriam Schweingruber. Changes --- Submitted with commit 8c15258b28870b6d9990b24f87ce913e2049bac8 by Olivier CHURLAUD to branch master. Bugs: 349313 https://bugs.kde.org/show_bug.cgi?id=349313 Repository: amarok Description

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
> https://git.reviewboard.kde.org/r/128248/ > --- > > (Updated June 19, 2016, 11:44 a.m.) > > > Review request for Amarok and Myriam Schweingruber. > > > Bugs: 349313 > https://bugs.kde.org/show_bug.cgi?id=349313 > > > Repository:

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
bly post as > > a separate patch. Applies also to the change few lines below. Do I commit separately or do i open a review request? - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.re

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Matěj Laitl
d.kde.org/r/128248/ > --- > > (Updated Čer. 19, 2016, 11:44 dop.) > > > Review request for Amarok and Myriam Schweingruber. > > > Bugs: 349313 > https://bugs.kde.org/show_bug.cgi?id=349313 > > > Reposi

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Stefano Pettini
o reply, visit: > https://git.reviewboard.kde.org/r/128248/ > --- > > (Updated June 19, 2016, 11:44 a.m.) > > > Review request for Amarok and Myriam Schweingruber. > > > Bugs: 349313 > https://bugs.kd

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-06-19 Thread Matěj Laitl
p., Stefano Pettini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128246/ > --- > > (Updated Čer. 19, 2016, 3:01 dop.) > > > Revi

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-06-19 Thread Matěj Laitl
.reviewboard.kde.org/r/128246/ > --- > > (Updated Čer. 19, 2016, 3:01 dop.) > > > Review request for Amarok. > > > Bugs: 314854 > https://bugs.kde.org/show_bug.cgi?id=314854 > > > Repository: am

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Olivier Churlaud
., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128248/ > --- > > (Updated June 19, 2016, 11:

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Stefano Pettini
ply, visit: > https://git.reviewboard.kde.org/r/128248/ > --- > > (Updated June 19, 2016, 11:44 a.m.) > > > Review request for Amarok and Myriam Schweingruber. > > > Bugs: 349313 > https://bugs.kde.org/show_bug.cgi?id=3

Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/ --- Review request for Amarok and Myriam Schweingruber. Bugs: 349313

Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-06-18 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/ --- Review request for Amarok. Bugs: 314854 https://bugs.kde.org

Review Request 128245: Length, but also any other numeric field, not properly handled in filter dialogs

2016-06-18 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128245/ --- Review request for Amarok. Bugs: 341661 https://bugs.kde.org

Re: Review Request 127458: Fix for warnings, one of them a probable bug

2016-06-17 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127458/ --- (Updated June 18, 2016, 12:08 a.m.) Review request for Amarok. Summary

Re: Review Request 127458: Fix for 2 warnings, one of them a probable bug

2016-06-17 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127458/ --- (Updated June 17, 2016, 11:46 p.m.) Review request for Amarok. Changes

  1   2   3   4   5   6   7   8   9   10   >