Re: Patch for Bug 213074

2012-08-05 Thread Matthias Berndt
Hi Myriam, > Could you please provide a link to it? It doesn't show up in the list > of the Amarok reviews at all https://git.reviewboard.kde.org/r/105875/ Sorry, I hadn't published it yet. Cheers Matthias ___ Amarok-devel mailing list Amarok-devel@kde.

Re: Patch for Bug 213074

2012-08-05 Thread Myriam Schweingruber
On Sun, Aug 5, 2012 at 2:20 PM, Matthias Berndt wrote: > Hi Sam, > >> It's an unhelpful error message, but you need to squash the two >> commits to a single commit before uploading the patch to reviewboard. > Thank you, the patch is now in the reviewboard. Could you please provide a link to it? I

Re: Patch for Bug 213074

2012-08-05 Thread Matthias Berndt
Hi Sam, > It's an unhelpful error message, but you need to squash the two > commits to a single commit before uploading the patch to reviewboard. Thank you, the patch is now in the reviewboard. Cheers Matthias ___ Amarok-devel mailing list Amarok-devel

Re: Patch for Bug 213074

2012-08-04 Thread Sam
On 4 August 2012 14:03, Matthias Berndt wrote: > Hi, >> Please submit your patch to the reviewboard: > I've tried, it fails with this error message: > The file 'src/dialogs/TagDialog.cpp' (rf306473) could not be found in the > repository. > > Cheers > Matthias It's an unhelpful error message, but

Re: Patch for Bug 213074

2012-08-04 Thread Matthias Berndt
Hi, > Please submit your patch to the reviewboard: I've tried, it fails with this error message: The file 'src/dialogs/TagDialog.cpp' (rf306473) could not be found in the repository. Cheers Matthias ___ Amarok-devel mailing list Amarok-devel@kde.org ht

Re: Patch for Bug 213074

2012-08-04 Thread Sam
On 4 August 2012 09:53, Matthias Berndt wrote: > Hi, > > I've written a Patch to fix this bug: > http://bugs.kde.org/213074 > I've also refactored the code in order to reuse some of the code originally > intended for the MusicBrainz tag guesser. I'd like to know what you think. > > Cheers > Matthi

Re: patch

2011-05-24 Thread Bart Cerneels
On Sun, May 22, 2011 at 12:27, raminder sodhi wrote: > I was thinking of of a patch in amarok in which we add an auto complete in > the address bar used in amarok (beneath the paly/pause button) > could somebody guide me for the same. > I was thinking of doing the same as dolphin does > Hey Ramin

Re: patch

2011-05-23 Thread Valorie Zimmerman
On Sun, May 22, 2011 at 9:50 PM, raminder sodhi wrote: > Can somebody point out to me if it is possible in amarok . Hi raminder, Please submit your patches and code contributions to git.reviewboard.kde.org, see also http://blogs.fsfe.org/myriam/2010/09/how-to-submit-patches-for-amarok/ Hope th

Re: patch

2011-05-23 Thread raminder sodhi
Can somebody point out to me if it is possible in amarok . ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel