Re: Review Request 125872: threadweaver issue solved

2015-10-30 Thread rishabh gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/ --- (Updated Oct. 30, 2015, 8:13 p.m.) Status -- This change has been ma

Re: Review Request 125872: threadweaver issue solved

2015-10-30 Thread Aroonav Mishra
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87726 --- Ship it! Ship It! - Aroonav Mishra On Oct. 30, 2015, 6:34

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/ --- (Updated Oct. 30, 2015, 6:34 a.m.) Review request for Amarok, Stefan Derk

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
> On Oct. 29, 2015, 6:39 p.m., Aroonav Mishra wrote: > > In line 160-164, I will suggest you to not completely remove those > > lines(Memory leaks maybe?) but instead revert it to the way it was before I > > edited it(I don't remember why I changed it). That is, put > > d->worker->deleteLater(

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/ --- (Updated Oct. 30, 2015, 5:56 a.m.) Review request for Amarok, Stefan Derk

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87691 --- Ship it! Ship It! - Olivier Churlaud On oct. 29, 2015, 6:1

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread Aroonav Mishra
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87689 --- In line 160-164, I will suggest you to not completely remove t

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread Aroonav Mishra
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87688 --- In line 160-164, I will suggest you to not completely remove t