Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/ --- (Updated April 28, 2013, 10:33 a.m.) Status -- This change has been m

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31695 --- This review has been submitted with commit 17f3e7a9cd2dbb201df

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

> On April 25, 2013, 10:39 a.m., Matěj Laitl wrote: > > src/core-impl/collections/daap/daapreader/authentication/md5.c, line 172 > > > > > > Nice catch. Wouldn't be sizeof(*ctx) more future-proof? (think of > > c

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/ --- (Updated April 27, 2013, 10:11 p.m.) Review request for Amarok. Changes

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31543 --- Nice cleanups, I agree with Edward's comments plus I have one m

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

> On April 25, 2013, 9:27 a.m., Edward Hades Toroshchin wrote: > > Looks good, except for the enums in "switch". I would personally list all > > the missing enum values explicitly. > > > > Thanks! That's actually quite a good point. I'll modify it to list enums explicitly. :-) - Konrad ---

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31541 --- Looks good, except for the enums in "switch". I would personall

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

> On April 24, 2013, 12:47 p.m., Myriam Schweingruber wrote: > > Which exact bugs does that fix? are those reported on http://bugs.kde.org? > > Then please add the "BUG: " handler and "FIXED-IN: 2.8" handler > > to it as well :) > > Konrad Zemek wrote: > None of these bugs are reported in

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

> On April 24, 2013, 12:47 p.m., Myriam Schweingruber wrote: > > Which exact bugs does that fix? are those reported on http://bugs.kde.org? > > Then please add the "BUG: " handler and "FIXED-IN: 2.8" handler > > to it as well :) None of these bugs are reported in bugs.kde.org (at least I could

Re: Review Request 110139: Small bugfixes. Fixes clang warnings.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110139/#review31493 --- Which exact bugs does that fix? are those reported on http://bu