D11192: Ported playdar collection away from qjson

2018-03-13 Thread Mark Kretschmann
This revision was automatically updated to reflect the committed changes. Closed by commit R181:16d4997c3792: Ported playdar collection away from qjson (authored by malteveerman, committed by markey). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11192?vs

D11192: Ported playdar collection away from qjson

2018-03-13 Thread Mark Kretschmann
markey accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11192 To: malteveerman, #amarok, markey Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar

D11192: Ported playdar collection away from qjson

2018-03-10 Thread Malte Veerman
malteveerman updated this revision to Diff 29167. malteveerman added a comment. Fixed hang on shutdown REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11192?vs=29115&id=29167 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11192 AFFECTED FIL

D11192: Ported playdar collection away from qjson

2018-03-09 Thread Malte Veerman
malteveerman created this revision. malteveerman added a reviewer: Amarok. malteveerman added a project: Amarok. malteveerman requested review of this revision. REVISION SUMMARY This ports the playdar collection from qjson to QJsonDocument and QJsonObject. Also removes the unneeded dependency

Re: Playdar Collection

2010-12-16 Thread Leo Franchi
On Thursday, December 16, 2010 01:44:15 PM Bart Cerneels wrote: > On Thu, Dec 16, 2010 at 11:51, Mark Kretschmann wrote: > > Hey all, > > > > recently several people have noticed that our new "Playdar Collection" > > is causing a slowdown in startup time. I&#

Re: Playdar Collection

2010-12-16 Thread Bart Cerneels
On Thu, Dec 16, 2010 at 11:51, Mark Kretschmann wrote: > Hey all, > > recently several people have noticed that our new "Playdar Collection" > is causing a slowdown in startup time. I'm wondering, should we not > default-disable this feature? > > 1) It cause

Playdar Collection

2010-12-16 Thread Mark Kretschmann
Hey all, recently several people have noticed that our new "Playdar Collection" is causing a slowdown in startup time. I'm wondering, should we not default-disable this feature? 1) It causes unnecessary slowdown. 2) Playdar itself is still Vaporware (as I hear), the original