D24135: Fix missing directory separators when saving podcasts to disk

This revision was automatically updated to reflect the committed changes. Closed by commit R181:982772be0d06: Fix missing directory separators when saving podcasts to disk (authored by yurchor). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24135?vs=66626&id=6

D24135: Fix missing directory separators when saving podcasts to disk

jyasi added a comment. In D24135#541657 , @heikobecker wrote: > Do you have commit access or should I push this for you? I don't have commit access. Please push for me. Thanks! REPOSITORY R181 Amarok REVISION DETAIL https://phabrica

D24135: Fix missing directory separators when saving podcasts to disk

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. Do you have commit access or should I push this for you? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok, heikobecker Cc: heikobe

D24135: Fix missing directory separators when saving podcasts to disk

wbauer added a subscriber: Amarok. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok Cc: #amarok, wbauer, yurchor, amarok-devel

D24135: Fix missing directory separators when saving podcasts to disk

wbauer added a comment. +1 from me now as well. The KDE4 code uses `KUrl::toLocalFile( KUrl::AddTrailingSlash )` here, so the additional slash should be correct (and necessary). REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok Cc: wbauer,

D24135: Fix missing directory separators when saving podcasts to disk

jyasi updated this revision to Diff 66626. jyasi added a comment. Update based on feedback. Just use '/' instead of QDir::separator() REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24135?vs=66591&id=66626 REVISION DETAIL https://phabricator.kde.org/D24135

D24135: Fix missing directory separators when saving podcasts to disk

wbauer added a comment. You should add '/' instead of QDir::separator()... https://agateau.com/2015/qdir-separator-considered-harmful/ REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok Cc: wbauer, yurchor, amarok-devel

D24135: Fix missing directory separators when saving podcasts to disk

yurchor added a comment. +1 Tested to work as expected. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok Cc: yurchor, amarok-devel

D24135: Fix missing directory separators when saving podcasts to disk

jyasi created this revision. jyasi added a reviewer: Amarok. jyasi added a project: Amarok. Herald removed a project: Amarok. Herald added a subscriber: amarok-devel. jyasi requested review of this revision. REVISION SUMMARY `SqlPodcastProvider::checkEnclosureLocallyAvailable()` and `SqlPodcast