Re: [amarok] src: Fix DynamicModel test

2012-07-14 Thread Matěj Laitl
On 12. 7. 2012 Ralf Engels wrote: > On 07/12/2012 12:44 PM, ext Matěj Laitl wrote: > > On 11. 7. 2012 Ralf Engels wrote: > > > Git commit 0066525f8d299a22509818e3814eafd08202945d by Ralf Engels. > > > -Amarok::Components::logger()->longMessage( > > > +Amarok::Logger* logger

Re: [amarok] src: Fix DynamicModel test

2012-07-12 Thread Ralf Engels
Hi, the problem with our test running on Jenkins are that we have still less stuff that we are currently assuming. For example phonon might not really work as expected. Also not we get a big hit from our habit of creating the singleton objects in the Amarok object. The comments for e.g. Amaro

Re: [amarok] src: Fix DynamicModel test

2012-07-12 Thread Matěj Laitl
On 12. 7. 2012 Matěj Laitl wrote: > Again, place for hard-to-find bugs in future. You should > Amarok::Compontents::setEngineController( new EngineControllerMock() ) in > test's initTestCase() instead. And when https://git.reviewboard.kde.org/r/105524/ is merged, you even can use plain vanilla

Re: [amarok] src: Fix DynamicModel test

2012-07-12 Thread Matěj Laitl
On 11. 7. 2012 Ralf Engels wrote: > Git commit 0066525f8d299a22509818e3814eafd08202945d by Ralf Engels. > Committed on 10/07/2012 at 11:03. > Pushed by rengels into branch 'master'. > > Fix DynamicModel test > > Don't rely on engine controller to be there. > Don't create actions for a tty applica