Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-22 Thread Bart Cerneels
On Sat, Aug 18, 2012 at 12:13 PM, Matěj Laitl wrote: > On 17. 8. 2012 Edward Toroshchin wrote: >> > Don't take it personally, but if you don't revert I'm going to. >> >> Don't take it personally, but I believe you need at least someone else >> to back you up on this to revert anything. Currently,

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-18 Thread Matěj Laitl
On 17. 8. 2012 Edward Toroshchin wrote: > > Don't take it personally, but if you don't revert I'm going to. > > Don't take it personally, but I believe you need at least someone else > to back you up on this to revert anything. Currently, no one except us > has expressed their point of view :). M

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-17 Thread Edward Toroshchin
Well, first, I would like to point out, that I'm not opposed to the idea, that applications should not send anything anywhere without user's consent. Just in case anyone got a wrong impression. Then, On Fri, Aug 17, 2012 at 05:45:51PM +0200, Sven Krohlas wrote: > a lot changed. It's a serious reg

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-17 Thread Sven Krohlas
Hi, Edward Hades wrote: On Wed, Aug 15, 2012 at 02:17:34AM +0200, Sven Krohlas wrote: Before, the user had to explicitly share his location with Amarok for any data to leave his network. Not Amarok does it automatically on every startup without any warning. That's true, but the user did not k

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-15 Thread Edward Hades
On Wed, Aug 15, 2012 at 02:17:34AM +0200, Sven Krohlas wrote: > Before, the user had to explicitly share his location with Amarok > for any data to leave his network. Not Amarok does it automatically > on every startup without any warning. That's true, but the user did not know that. > > I agree

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Sven Krohlas
Hi, Edward Hades wrote: On Wed, Aug 15, 2012 at 01:18:42AM +0200, Sven Krohlas wrote: I'm very opposed to that solution, as now the plugin sends queries to the service even without having an explicit users consent. Sending data to a web service without the user knowing about it is a bad thing.

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Edward Hades
On Wed, Aug 15, 2012 at 01:18:42AM +0200, Sven Krohlas wrote: > I'm very opposed to that solution, as now the plugin sends queries > to the service even without having an explicit users consent. Sending > data to a web service without the user knowing about it is a bad thing. First, the commit in

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Sven Krohlas
Heya, Edward Hades wrote: Git commit 84c05d37ac5be1c836948ca5e41a0f824969544e by Edward Hades. Committed on 14/08/2012 at 21:49. Pushed by hades into branch 'master'. Detect Amazon country automatically. This uses KDE locale settings and avoids "choose your country" popup at first startup. BU