Re: Review Request 125872: threadweaver issue solved

2015-10-30 Thread rishabh gupta
ons/db/sql/SqlQueryMaker.cpp c73a551 Diff: https://git.reviewboard.kde.org/r/125872/diff/ Testing --- builds 100% testing done Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Changes in SqlQueryMaker.cpp

2015-10-29 Thread RISHABH GUPTA
From: Michael Pyne Date: Thu, Oct 29, 2015 at 7:23 AM Subject: Re: Debug ThreadWeaver::IdDecorator To: kde-de...@kde.org On Wed, October 28, 2015 18:45:40 Olivier Churlaud wrote: > Le 28/10/2015 16:08, Thomas Lübking a écrit : > > On Mittwoch, 28. Oktober 2015 14:33:02 CEST, Olivier Churlaud wro

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
ons/db/sql/SqlQueryMaker.cpp c73a551 Diff: https://git.reviewboard.kde.org/r/125872/diff/ Testing --- builds 100% testing done Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
dWeaver::JobPointer is a qsharedpointer ,so we don't have to delete it manually - rishabh --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87688 ------

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
llections/db/sql/SqlQueryMaker.cpp c73a551 Diff: https://git.reviewboard.kde.org/r/125872/diff/ Testing --- builds 100% testing done Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
Testing --- builds 100% testing done Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

segfault(kf5 port olivier )

2015-10-23 Thread RISHABH GUPTA
Message: 2Date: Tue, 20 Oct 2015 22:50:25 +0200 > From: Olivier Churlaud > To: Amarok > Subject: [Port KF5] Help to debug > Message-ID: <5626a911.1050...@churlaud.com> > Content-Type: text/plain; charset=utf-8; format=flowed > > Dear all, > > I'm trying to debug some part of Amarok, and I slowly

Port KF5 plugins

2015-10-17 Thread RISHABH GUPTA
hello, This is about the segmentation fault that we are recieving .The reason for the seg fault is ThreadWeaver::iddecorator::~iddecorator() is trying to read some memory which has been free'd. here's the valgrind output https://paste.kde.org/phbslccrh It says that invalid read of size 8 at 0x877

Re: Review Request 125593: removed the Line that deleted m_args

2015-10-12 Thread rishabh gupta
y now Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125593: removed the Line that deleted m_args

2015-10-12 Thread rishabh gupta
https://git.reviewboard.kde.org/r/125593/diff/ Testing --- builds 100% the reason it was recieving sigabrt was m_args was being deleted.Maybe not deleting is not the right option but it quits normally now Thanks, rishabh gupta ___ Amarok-

amarok kf5 port

2015-10-11 Thread RISHABH GUPTA
hello, I am experiencing an unsual behaviour while starting amarok with gdb .While starting amarok in gdb i.e when i give this command "gdb amarok" amarok's mainwindow is not loaded and gives a segmentation fault . If i start amarok outside gdb i.e just "amarok" the same thing happens and cras

Review Request 125593: removed the Line that deleted m_args

2015-10-11 Thread rishabh gupta
being deleted.Maybe not deleting is not the right option but it quits normally now Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re:kf5port(olivier)

2015-09-16 Thread RISHABH GUPTA
diff using the --full-index parameter." I have a .patch file which i created using git format-patch kf5 < segfault.patch > Cheers, > Olivier > > > cheers, rishabh > > Sur 16 sept. 2015 02:44, à 02:44, RISHABH GUPTA a > écrit: > >> > >> Message:

Re: Review Request 125258: changed kmessagebox to qmessagebox

2015-09-16 Thread rishabh gupta
No more errors in app.cpp File Attachments 0003-handlefirstrun.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/d359d46b-9aec-4b9d-a82a-3643503a213a__0003-handlefirstrun.patch Thanks, rishabh gupta ___ Amarok

Re: Review Request 125258: changed kmessagebox to qmessagebox

2015-09-16 Thread rishabh gupta
(updated) 0003-handlefirstrun.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/09/16/d359d46b-9aec-4b9d-a82a-3643503a213a__0003-handlefirstrun.patch Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel

Review Request 125258: changed kmessagebox to qmessagebox

2015-09-16 Thread rishabh gupta
Description --- changes in handlefirstrun() of app.cpp Diffs - src/patch2.txt 292542403181712a2398c1190cfc831190edb036 Diff: https://git.reviewboard.kde.org/r/125258/diff/ Testing --- built No more errors in app.cpp Thanks, rishabh gupta

kf5port(olivier)

2015-09-15 Thread RISHABH GUPTA
> > Message: 3 > Date: Mon, 14 Sep 2015 14:55:30 +0200 > From: Olivier Churlaud > To: amarok-devel@kde.org > Subject: Re: kf5port(olivier) > Message-ID: <55f6c3c2.8050...@churlaud.com> > Content-Type: text/plain; charset="utf-8"; Format="flowed&qu

Re: kf5port(olivier)

2015-09-14 Thread RISHABH GUPTA
Message: 2 > Date: Mon, 14 Sep 2015 11:01:21 +0200 > From: Olivier Churlaud > To: "amarok-devel@kde.org" > Subject: Re: Kf5 port(olivier) > Message-ID: > Content-Type: text/plain; charset="utf-8" > > > > > > This is what you should investigate. ContinueInit is done on my side. > So,i reapplied

Re:Kf5 port(olivier)

2015-09-14 Thread RISHABH GUPTA
> -- > > Message: 3 > Date: Sun, 13 Sep 2015 17:59:49 - > From: "Olivier Churlaud" > To: "Olivier Churlaud" , "Amarok" > > Subject: Re: Review Request 125126: Port of main.cpp and App class > Message-ID: <20150913175949.3546.2...@mimi.kde.org> > Content-Typ

Re: Kf5port(olivier) rishabh

2015-09-13 Thread RISHABH GUPTA
On Sun, Sep 13, 2015 at 5:30 PM, wrote: > >> Send Amarok-devel mailing list submissions to >> amarok-devel@kde.org >> >> To subscribe or unsubscribe via the World Wide Web, visit >> https://mail.kde.org/mailman/listinfo/amarok-devel >> or, via email, send a message with subject or

Re: Amarok-devel Digest, Vol 104, Issue 15

2015-09-13 Thread RISHABH GUPTA
On Sun, Sep 13, 2015 at 5:30 PM, wrote: > Send Amarok-devel mailing list submissions to > amarok-devel@kde.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://mail.kde.org/mailman/listinfo/amarok-devel > or, via email, send a message with subject or body 'h

kf5 port(olivier)

2015-09-13 Thread RISHABH GUPTA
Changes > --- > > Work more, and reduce segfaults > > > Repository: amarok > > > Description (updated) > --- > Port of main.cpp and App > > It compiles 100%, and there is a segmentation fault after the end of the > App::continueInit(). > I'm not able to trace it further. > > Please h

KF port continued

2015-09-09 Thread RISHABH GUPTA
> Message: 3 > Date: Mon, 7 Sep 2015 18:59:10 +0200 > From: Olivier Churlaud > To: amarok-devel@kde.org > Subject: Re: kf5 port continued(stefan derkits) > Message-ID: <55edc25e.3060...@churlaud.com> > Content-Type: text/plain; charset="utf-8"; Format="flowed" > > Hi Rishabh, > hello, > > If you

Re: kf5 port continued(stefan derkits)

2015-09-07 Thread RISHABH GUPTA
> > > Message: 1 > Date: Sun, 6 Sep 2015 02:22:43 +0200 > From: Stefan Derkits > To: amarok-devel@kde.org > Subject: KF5 port continued > Message-ID: <55eb8753.5080...@derkits.at> > Content-Type: text/plain; charset="utf-8" > > Hey, > > hello, > thanks Somsubhra for making the port compile. > >

Re: Amarok-devel Digest, Vol 104, Issue 4

2015-09-04 Thread RISHABH GUPTA
est..." > > > Today's Topics: > >1. amarok port to kf5 (RISHABH GUPTA) >2. Re: amarok port to kf5 (Olivier Churlaud) > > > ---------- > > Message: 1 > Date: Fri, 4 Sep 2015 16:40:2

amarok port to kf5

2015-09-04 Thread RISHABH GUPTA
hello, The error "undefined reference to vtable someclass" is generally produced because of not defining the virutal functions of that class. So maybe there is a virutal function in class "factory" which has not been defined .I tried looking up for the class "factory" but couldn't find it ris

amarok port to kf5

2015-08-18 Thread RISHABH GUPTA
hello, this is for aroonav and olivier who are working on the amarok port. I would like to help in the porting process. But to be able to help i would like to know about the way you guys have been working on this .I think this whole process would help me in understanding the structure of amarok .

Re: Review Request 124776: keyboard shortcut for the minimizing the mainwinodw

2015-08-16 Thread rishabh gupta
indow-with-ctrl-shift-m.patch Thanks, rishabh gupta ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 124776: keyboard shortcut for the minimizing the mainwinodw

2015-08-16 Thread rishabh gupta
0003-minimize-mainwindow-with-ctrl-shift-m.patch https://git.reviewboard.kde.org/media/uploaded/files/2015/08/16/69616616-e315-42fe-882a-1c848056747b__0003-minimize-mainwindow-with-ctrl-shift-m.patch Thanks, rishabh gupta ___ Amarok-devel

subscribed already

2015-08-05 Thread RISHABH GUPTA
hello Myriam, I have already subscribed to amrok-devel and recently subscribed to amarok-bugs-dist.Do I need to subscribe to any other mailing-list? Thanks, rishabh ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo

Bug 254404

2015-08-04 Thread RISHABH GUPTA
I would like to take up this bug https://bugs.kde.org/show_bug.cgi?id=254404 . Is anyone working on it right now? ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel