Re: Small summer status overview + request for some opinions

2024-06-27 Thread Sven Krohlas
Hi, Additionally, I'd maybe like to remove the donors tab altogether. It lists 3 people who contributed to Roktober 2012 or earlier. Maybe it would be time to. back then we promised the Roktober donors would be part of Amarok 3. We wrote lots of text about that in the campaign. So imho the Ro

getamarok.com mail forwarding broken

2013-07-16 Thread Sven Krohlas
Heya, I tried to contact eean but got no reply. It seems as if mail forwarding from our getamarok.com mail addresses is broken. There is no MX entry in DNS: dig -t MX getamarok.com ; <<>> DiG 9.9.2-P2 <<>> -t MX getamarok.com ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY,

Re: [amarok] /: Make playlist-related actions consistent throughout Amarok code (behaviour change)

2013-06-26 Thread Sven Krohlas
heya, Matěj Laitl wrote: > So what is your preference what should happen on double-click? a), b) or c), > or do you suggest some d)? How/if ever should we take KDE's settings (single > vs. double click) into account? imho: there are reasonable use cases for immediate playing, there are reasonab

Re: amarok-devel@kde.org

2013-04-02 Thread Sven Krohlas
Heya, Matěj Laitl wrote: > On 2. 4. 2013 Edward Toroshchin wrote: >> Well, I'm not a particular fan of bureaucracy myself, but why do we have >> a mailing list at all, if such a major thing is not even _announced_ >> there? > > First, I wouldn't consider this _major_ at all. Second: yes, I should

Re: Amazon mp3

2013-01-21 Thread Sven Krohlas
Heya, Amazons stupidity knows no limits... Sven Krohlas wrote: > Mark Fraser wrote: >> On Saturday 19 Jan 2013 18:46:41 Sven Krohlas wrote: >>> Mark Fraser wrote: >>> > I upgraded to Amarok 2.7 today and decided to try out the Amazon mp3 shop. >>> &

Re: [amarok] src: Translate more strings as string freeze is over!

2013-01-19 Thread Sven Krohlas
Heya, Matěj Laitl wrote: > Translate more strings as string freeze is over! the intend of string freeze is not to get nice statistics but to give translators the chance to translate as much as possible. Adding i18n() calls late or after the freeze contradicts that goal. ;-) So if a string needs

Re: Google - summer of code, Amarok unit testing (Teo Mrnjavac)

2012-12-29 Thread Sven Krohlas
Heya, Teo Mrnjavac wrote: > Any takers? Sven maybe? I would really love to, but I won't find the time for continious mentoring right now. I have an election campaign to run until September. :-/ Maybe you can invite him to ask his questions on the list, IRC, etc? _

Re: Authorship

2012-09-23 Thread Sven Krohlas
Heya, Bart Cerneels wrote: > The currently active Amarok team + ", at least the part who was able to attend Randa, " > As far as I can tell there is no legal reason to list all past contributors > as authors. It's not about legal reasons. For legal reasons the copyright headers in the source

Re: clamz as Amazon downloader in Amarok

2012-09-13 Thread Sven Krohlas
Hi, up2date screenshots: http://krohlas.de/blog/?eid=344 ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: clamz as Amazon downloader in Amarok

2012-09-12 Thread Sven Krohlas
Hi, Benjamin Moody wrote: > Well, good luck, and let me know if there's anything I can do to help. fyi: I just commited our downloader utility, which is basically a qt based gui for clamz, so it can also be used by other projects than Amarok: http://commits.kde.org/amarok/5df289172653cf97df48938

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-17 Thread Sven Krohlas
Hi, Edward Hades wrote: On Wed, Aug 15, 2012 at 02:17:34AM +0200, Sven Krohlas wrote: Before, the user had to explicitly share his location with Amarok for any data to leave his network. Not Amarok does it automatically on every startup without any warning. That's true, but the user di

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Sven Krohlas
Hi, Edward Hades wrote: On Wed, Aug 15, 2012 at 01:18:42AM +0200, Sven Krohlas wrote: I'm very opposed to that solution, as now the plugin sends queries to the service even without having an explicit users consent. Sending data to a web service without the user knowing about it is a bad

Re: [amarok] src/services/amazon: Detect Amazon country automatically.

2012-08-14 Thread Sven Krohlas
Heya, Edward Hades wrote: Git commit 84c05d37ac5be1c836948ca5e41a0f824969544e by Edward Hades. Committed on 14/08/2012 at 21:49. Pushed by hades into branch 'master'. Detect Amazon country automatically. This uses KDE locale settings and avoids "choose your country" popup at first startup. BU

Re: Review Request: Bug 292081 - JJ: Label about info at opendesktop.org is truncated

2012-06-24 Thread Sven Krohlas
? src/aboutdialog/AnimatedBarWidget.cpp <http://git.reviewboard.kde.org/r/104464/#comment11852> trivial coding style: space missing "0,0," - Sven Krohlas On April 2, 2012, 3:15 p.m., Lachlan Dufton wrote: > > --

Problem on Windows

2012-06-24 Thread Sven Krohlas
Heya, just found out that amarok wont start on some windows systems because of the UAC and some rightsmanagemend (tested on windows 8) because amarok tries to write the stuff directly to the installation folder/data http://paste.kde.org/~windows/506402/ and the apllication doesnt have the rig

Re: [amarok] src/playlistmanager/file: Don't hardcode / as directory separator

2012-06-22 Thread Sven Krohlas
Hey, Matěj Laitl wrote: > Sven, your fix is actually incorrect. From QDir::separator() documentation: >> Returns the native directory separator: "/" under Unix (including Mac OS X) >> and "\" under Windows. You do not need to use this function to build file >> paths. If you always use "/", Qt wil

Re: Review Request: SoK Unit test : core/collections/Collection

2012-06-22 Thread Sven Krohlas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105166/#review14994 --- Ship it! Ship It! - Sven Krohlas On June 22, 2012, 11:07

Re: Review Request: SoK Unit test : core/collections/Collection

2012-06-22 Thread Sven Krohlas
a subroutine associated with a class is usually called a "method". - Sven Krohlas On June 21, 2012, 10:20 p.m., Jasneet Bhatti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Sven Krohlas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105306/#review14913 --- Ship it! Ship It! - Sven Krohlas On June 20, 2012, 2:17

Re: Review Request: SoK - Unit test : core/playlists/PlaylistFormat

2012-06-20 Thread Sven Krohlas
ttp://git.reviewboard.kde.org/r/105306/#comment11705> You might also want to feed it a string without any . at all. Or several of them. - Sven Krohlas On June 20, 2012, 12:11 p.m., Jasneet Bhatti wrote: > > --- > This is an automati

Re: Review Request: SoK - Unit test : core/capabilities/ActionsCapability

2012-06-19 Thread Sven Krohlas
ctionscapability ${KDE4_KDECORE_LIBS} ${QT_QTGUI_LIBRARY} ${QT_QTTEST_LIBRARY} amarokcore amaroklib ) - Sven Krohlas On June 18, 2012, 8:15 p.m., Jasneet Bhatti wrote: > > --- > This is an automatically generated e-mail

Re: Jenkins build is still unstable: amarok_master #152

2012-06-19 Thread Sven Krohlas
Heya, testdynamicmodel is crashing upon removing the last playlist model->removeAt( model->index( model->activePlaylist() ) ); But I don't see what exactly is going wrong then. Anybody else? Here is a complete backtrace of a test run: PASS : TestDynamicModel::testDnD() Program received sign

Re: Review Request: SoK - Unit Test : core/meta/Meta (MetaCapability)

2012-06-19 Thread Sven Krohlas
eration collect2: ld returned 1 exit status make[2]: *** [tests/testmetacapability] Fehler 1 make[1]: *** [tests/core/meta/CMakeFiles/testmetacapability.dir/all] Fehler 2 And then ship it. :) - Sven Krohlas On June 18, 2012, 2:09 p.m.,

Re: Release plan for 2.6

2012-04-29 Thread Sven Krohlas
Heya, Matěj Laitl wrote: > Are 2 weeks enough for translators, testers & packagers to catch up? I > personally would give them a week or two more, but I have little experience > with releasing Amarok. iirc two weeks was the minimum required by translators. So a bit more might not hurt. -- Dark

Fwd: Re: qtscriptgenerator with Qt 4.8 / Amarok

2012-01-24 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - Original Message From: - Tue Jan 24 18:30:31 2012 Subject: Re: qtscriptgenerator with Qt 4.8 / Amarok From: Kent Hansen In-Reply-To: <4f16f9da.6060...@asbest-online.de> Date: Tue, 24 Jan 2012 18:34:27 +0100 To: Sven K

Re: qtscriptgenerator with Qt 4.8 / Amarok

2012-01-18 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Kent Hansen wrote: > Den Jan 3, 2012 kl. 3:10 PM skrev Sven Krohlas: As the bug report is already > relatively old and > very severe may I ask about the maintenance status of the project? Will it > still be maintained > in the

Re: 2.5.0 tarball problems

2012-01-03 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, has that patch already been committed to master? It should be part of 2.5.1. - -- Darkerradio Free Music Charts November 2011: http://www.darkerradio.com/news/free-music-charts-november-2011/ Klarmachen zum Ändern! -> http://www.piratenpartei.d

Bug 290123 - broken context view with KDE 4.8

2012-01-03 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, with the release of KDE 4.8 we are going to have a real problem: The context view is broken there and we need to fix Amarok. See https://bugs.kde.org/show_bug.cgi?id=290123 The good news is: A fix seems to be available. According to http

Re: Amarok installer size

2012-01-03 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, Bart Cerneels wrote: > Is this really so important w.r.t. all the other things on the TODO? I would > not spend any time > on a marginal (1.1/88) reduction of installer size if it take mare then half > an hour. We've got > plenty of bugs/featu

qtscriptgenerator with Qt 4.8 / Amarok

2012-01-03 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I'm Sven Krohlas from the Amarok project, which has several key features that depend on QtScript bindings. You might have noticed the bug report at: https://code.google.com/p/qtscriptgenerator/issues/detail?id=80 This one is a show st

Re: clamz as Amazon downloader in Amarok

2012-01-03 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Benjamin Moody wrote: >> Hi Benjamin, But one quite important piece of the puzzle is still missing: >> An integrated >> downloader for the MP3s. As clamz already seems to handle the job quite well >> I consider using >> clamz as a backend for .

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Sven Krohlas
X -> X Tracks, Episode Cunt: Y -> Y Episodes - Sven Krohlas On Jan. 2, 2012, 2:38 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Amarok installer size

2012-01-02 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, we should really try to reduce our Windows installer size. It is currently at 88MB. I guess I was able to cut about 1.1MB with the latest changes and some files to blacklist, but there is still a lot to do. While we are at it this could lead to

clamz as Amazon downloader in Amarok

2011-12-31 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Benjamin, as you might have heard Amarok now features an Amazon MP3 Store Plugin since version 2.5.0. I'm the guy responsible for that code. http://krohlas.de/blog/?eid=342 But one quite important piece of the puzzle is still missing: An integr

Re: Amarok out of string freeze, let's plan features

2011-12-21 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, Bart Cerneels wrote: > So what features do you have planned or would strongly suggest to make it > into 2.6? my top priority is the Amazon .amz downloader. Apart from that: Everything in the Amazon-Store component on Bugzilla. - -- Darkerrad

Re: Review Request: Amazon store WIP patch

2011-11-20 Thread Sven Krohlas
kde.org/r/102596/#review8325 --- On Oct. 19, 2011, 9:57 p.m., Sven Krohlas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewb

Re: [amarok] /: Maintain authors list.

2011-11-08 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, > Those removals should have been up for discussion. With all due respect for > your effort, I > don't think it's ok for any single person to single-handedly remove someone > from the authors > list however good the reason might be, without ha

Icons/artwork for the music store in Amarok

2011-11-05 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello Amarok community, as you might have seen in current git master, I'm currently implementing a music store plugin for Amarok. My main problem is: I'm not an artist at all. And I need some icons and one background graphic. Do we have any volunteer

Amazon store artwork

2011-10-21 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, we need some artwork for the new Amazon store: src/images/emblem-amazon.png Will be shown for track previews in the playlist. src/images/icons/hi16-action-view-services-amazon-amarok.png src/images/icons/hi22-action-view-services-amazon-amarok.p

Re: Review Request: Amazon store WIP patch

2011-10-19 Thread Sven Krohlas
wboard.kde.org/r/102596/s/311/ Thanks, Sven Krohlas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Amazon store WIP patch

2011-10-19 Thread Sven Krohlas
German Amazon store. works. Screenshots --- Search result for "cure" in the German store http://git.reviewboard.kde.org/r/102596/s/311/ Thanks, Sven Krohlas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Amazon store WIP patch

2011-10-19 Thread Sven Krohlas
ot; in the German store http://git.reviewboard.kde.org/r/102596/s/311/ Thanks, Sven Krohlas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Amazon store WIP patch

2011-10-19 Thread Sven Krohlas
src/services/amazon/amarok_service_amazonstore_config.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102596/diff/diff Testing --- only in the German Amazon store. works. Screenshots --- Search result for "cure" in the German store http://git.reviewboard.kde.org/r

Re: Review Request: Amazon store WIP patch

2011-10-18 Thread Sven Krohlas
src/services/amazon/amarok_service_amazonstore_config.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102596/diff/diff Testing --- only in the German Amazon store. works. Screenshots --- Search result for "cure" in the German store http://git.reviewboard.kde.org/r/102596/

Re: Review Request: Amazon store WIP patch

2011-10-18 Thread Sven Krohlas
Search result for "cure" in the German store http://git.reviewboard.kde.org/r/102596/s/311/ Thanks, Sven Krohlas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Amazon store WIP patch

2011-10-17 Thread Sven Krohlas
--- Search result for "cure" in the German store http://git.reviewboard.kde.org/r/102596/s/311/ Thanks, Sven Krohlas ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Amazon store WIP patch

2011-09-13 Thread Sven Krohlas
't pollute the already huge patch. Done and already checked in. I'm going to do the same for the changes to the SearchWidget. - Sven --- This is an automatically generated e-mail. To reply, visit: http://git.revie

Re: Review Request: Amazon store WIP patch

2011-09-13 Thread Sven Krohlas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102596/ --- (Updated Sept. 13, 2011, 4:36 p.m.) Review request for Amarok. Changes -

Re: Review Request: Amazon store WIP patch

2011-09-12 Thread Sven Krohlas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102596/ --- (Updated Sept. 13, 2011, 12:59 a.m.) Review request for Amarok. Changes

Review Request: Amazon store WIP patch

2011-09-12 Thread Sven Krohlas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102596/ --- Review request for Amarok. Summary --- Totally WIP! Many, many TODOs

Re: Fwd: Radio GFM integration in Amarok by default

2011-07-24 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Marco, > This is Marco from Switzerland. I'm member of the music editorial staff of > the non-commercial > german web-radio project called „Radio GFM“. > > Radio GFM plays „GEMA-FREIE MUSIK“ which means that we do only play music > which is rele

Re: Amarok GIT Segmentation Fault amarokcore_automoc.o

2011-07-07 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, > * Check that you're getting out of memory during compilation. (The OOM-Killer > might give you > segfaults) iirc the OOM killer should mention its activities in the kernel log. - -- Darkerradio Free Music Charts Juni 2011: http://www.darker

Bugs with PATCHes

2011-06-26 Thread Sven Krohlas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, I just shared a query in Bugzilla all Amarok PATCHes. Some of them have been there for years. :( Imho, if someone writes a patch they at least deserve an answer: [PATCH] queue tracks from collection browser [PATCH] To be able to transfer p

Re: [amarok] /: Switch MusicDNS decoder back from avcodec_decode_audio2 to avcodec_decode_audio3.

2011-05-17 Thread Sven Krohlas
Heya, > Also: Is this version bump ok? How old is 0.6? release date: June 17, 2010, acording to Wikipedia. So I'd say that's ok. -- Darkerradio Free Music Charts April 2011: http://www.darkerradio.com/news/free-music-charts-april-2011/ Klarmachen zum Ändern! -> http://www.piratenpartei.de/ _

Re: Regression Alert: Change in Playback Behavior

2011-01-06 Thread Sven Krohlas
Heya, > I just remembered that we have one regression left that I find very > major. The regression is: I'd also like to point one out: since one or two revisions some scripts (at least the BBC one and my Free Music Charts) are broken. A possible fix is in: http://git.reviewboard.kde.org/r/10