Thank you for taking case of the release!
Stefano
On Wed, Mar 7, 2018 at 8:49 PM, Heiko Becker wrote:
> Hello everybody,
>
> as it may be customary for the upcoming season the Amarok team did some
> spring cleaning and is proud to announce the immediate release of Amarok
> 2.9.0. While we reali
somebody from us will help. (people usually
> > procrastinate "big" tasks, but answering a concrete questions is much
> > easier)
>
> What I'm a bit unsure about is how to communicate the release. Something
> along the lines "This release might not be as
Can I suggest we release 2.9 as planned, with the current state and maybe
some more bugfixes, before integrating this patch? Once migration to kf5 is
complete, and new patches will be needed for that, we may start thinking
about a 3.0.
Stefano
On Thu, Feb 15, 2018 at 6:15 AM, Malte Veerman
wrote
spettini added a comment.
Can I suggest we release 2.9 as planned, with the current state and maybe
some more bugfixes, before integrating this patch? Once migration to kf5 is
complete, and new patches will be needed for that, we may start thinking
about a 3.0.
REPOSITORY
R181 Amarok
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130142/#review103864
---
Ship it!
I tested it and integrated it.
- Stefano
Hi,
it's many years now that Amarok 2.9 is about to be released. The
saturday-morning emails remember us weekly that there are still a couple of
regressions since years. In the meanwhile development almost stopped, but
not completely. I, like many, contributed with small but important patches
(oth
Hi Emily,
there are already many changes pipelined for 2.9 that I would even release
it as it is today. I also worked and dedicated some time in the past to
Amarok, seeing that the output of that work is just parked in a limbo is
also not nice.
Regards,
Stefano
On Thu, Feb 2, 2017 at 11:40 PM, E
marked as submitted.
Review request for Amarok.
Changes
---
Submitted with commit 970e985d6100070aa105dd602da8c294687385ac by Mat?j Laitl
on behalf of Stefano Pettini to branch master.
Repository: amarok
Description
---
This fixes some minor C++ warnings: one unused variable and
marked as submitted.
Review request for Amarok.
Changes
---
Submitted with commit 0e760e5f8d06d00e084c14b64875f58bb42bd8f1 by Mat?j Laitl
on behalf of Stefano Pettini to branch master.
Bugs: 226144
https://bugs.kde.org/show_bug.cgi?id=226144
Repository: amarok
Description
ot of testing was done, like:
- adding/updating/removing presets.
- if settings are persisted and shared when dialogs are cancelled or accepted.
- if custom patterns are persisted and not shared.
- resetting a modified pattern to its defualt.
- cancelling dialogs, modified presets are kept but custom patterns are not.
Thanks,
Stefano Pettini
ied presets are kept.
Thanks,
Stefano Pettini
marked as submitted.
Review request for Amarok.
Changes
---
Submitted with commit bdbb3a27f556c41910d3b814e5a4c73a2a93362f by Mat?j Laitl
on behalf of Stefano Pettini to branch master.
Bugs: 314854
https://bugs.kde.org/show_bug.cgi?id=314854
Repository: amarok
Description
marked as submitted.
Review request for Amarok.
Changes
---
Submitted with commit 6c49cfdfd97faa146ce7b0d8e95ce2bf596f2b0d by Mat?j Laitl
on behalf of Stefano Pettini to branch master.
Bugs: 341661
https://bugs.kde.org/show_bug.cgi?id=341661
Repository: amarok
Description
fixes the problem.
Thanks,
Stefano Pettini
ng dialogs, modified presets are kept.
Thanks,
Stefano Pettini
s.
- if settings are persisted and shared.
- if custom patterns are persisted and not shared.
- resetting a modified pattern to its defualt.
- cancelling dialogs, modified presets are kept.
Thanks,
Stefano Pettini
Tested use case of changing KDE color scheme while Amarok is running
Tested the edit lyrics mode
Thanks,
Stefano Pettini
both filter dialog and dynamic playlist dialog.
Thanks,
Stefano Pettini
field called useSSL left in
WikipediaApplet_p.h that should be removed, together with the MusicBrainz file.
- Stefano Pettini
On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail. T
file,
src/musicbrainz/MusicDNSAudioDecoder.cpp, that is not related to this patch.
- Stefano Pettini
On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote:
>
> ---
> This is an automatically generated e-mail. To re
://git.reviewboard.kde.org/r/128246/diff/
Testing
---
Tested ONLY in the following environment:
KDE Version: 4.14.16
Qt Version: 4.8.7
Tested with light and dark color scheme
Tested use case of changing KDE color scheme while Amarok is running
Tested the edit lyrics mode
Thanks,
Stefano
=, <, > and similar).
Diffs
-
src/widgets/MetaQueryWidget.cpp abce6b7
Diff: https://git.reviewboard.kde.org/r/128245/diff/
Testing
---
Verified in both filter dialog and dynamic playlist dialog.
Thanks,
Stefano Pettini
---
Thanks,
Stefano Pettini
/services/mp3tunes/libmp3tunes/harmony.c ead0345
src/statemanagement/DefaultApplicationController.cpp 5886789
Diff: https://git.reviewboard.kde.org/r/127458/diff/
Testing
---
Thanks,
Stefano Pettini
g
2.9.
- Stefano
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128157/#review96617
---
On June 12, 2016, 8:33 a.m., St
Kubuntu 16.04, that ships with MySQL 5.7,
I verified that the patch fixes the problem.
Thanks,
Stefano Pettini
marked as submitted.
Review request for Amarok.
Changes
---
Submitted with commit aaff3348862a1999069feff93d9e1e4d995b7225 by Heiko Becker
on behalf of Stefano Pettini to branch master.
Bugs: 339190
https://bugs.kde.org/show_bug.cgi?id=339190
Repository: amarok
Description
lly generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127468/#review94192
---
On March 23, 2016, 9:32 p.m., Stefano Pettini wrote:
>
> ---
> This is an autom
> On March 23, 2016, 3:15 p.m., Myriam Schweingruber wrote:
> > Ship It!
>
> Stefano Pettini wrote:
> Please wait, let me do some more tests this evening
What about reviewing and submitting this patch?
- Stefano
> On Mar. 30, 2016, 12:48 a.m., Myriam Schweingruber wrote:
> > hm, I fail to see why you would not build amarok with MySQL embedded, as
> > that is the default database. Could you please specify why this patch is
> > needed?
>
> Matt Whitlock wrote:
> Gentoo's philosophy is all about lean
av). Before it was not working, now
it does.
Thanks,
Stefano Pettini
Testing
---
First I reproduced the bug with an original CD 100% of the times. It was
triggered in case the CD didn't have any CDTEXT. Only in that case the
noInfoAvailable function was invoked.
After fixing it, I verified that it works as expected both with CDs with CDTEXT
and CDs
kde.org/r/127468/#review93899
---
On Mar. 22, 2016, 10:59 p.m., Stefano Pettini wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
function was invoked.
After fixing it, I verified that it works as expected both with CDs with CDTEXT
and CDs without it.
Thanks,
Stefano Pettini
/SqlScanResultProcessor.cpp ea9c911
Diff: https://git.reviewboard.kde.org/r/127458/diff/
Testing
---
Thanks,
Stefano Pettini
20234.random-OLe7wC54.m4a
INFO: File is a MP4 file, opening...
INFO: Found an existing AFT identifier: :com.apple.iTunes:Amarok 2 AFTv1 -
amarok.kde.org
INFO: AFT identifier is version 1
INFO: ID is current
INFO: Cleaning up...
INFO: All done, exiting...
Thanks,
Stefano Pe
id-20234.random-OLe7wC54.m4a
INFO: File is a MP4 file, opening...
INFO: Found an existing AFT identifier: :com.apple.iTunes:Amarok 2 AFTv1 -
amarok.kde.org
INFO: AFT identifier is version 1
INFO: ID is current
INFO: Cleaning up...
INFO: All done, exiting...
Thanks,
37 matches
Mail list logo
