Re: building amarok

On Fri, Jun 5, 2020 at 10:47 PM Myriam Schweingruber wrote: > > > > FYI, I think building from source should go to the devel mailing list, as > > it is not exactly basic user stuff > > > > Regards, Myriam > > > > -- Forwarded message -

Re: building amarok

confusion! (I don't think I'm on the -devel list let's see if this works...) Robert -- Robert Marshall twitter: @rajm Pedro de Carvalho Gomes writes: > Hi Robert, > > First of all, mysql deprecated its embedded library after version 5.7. > Thi

Re: Review Request 123635: Fix minor typo in PlaylistLengthEditWidget.ui

marked as submitted. Review request for Amarok. Changes --- Submitted with commit 0feb6251925fe049c46ccf5153db4b467f3544fb by Albert Astals Cid on behalf of Robert Marshall to branch master. Repository: amarok Description --- add the word 'specify' to text Diffs --

Re: Review Request 129633: Bug 335217 means that show in media sources doesn't expand trees, this patch adds a user option

wsers/CollectionTreeView.h fc9f732 src/browsers/CollectionTreeView.cpp 816d2e1 Diff: https://git.reviewboard.kde.org/r/129633/diff/ Testing --- Built amarok and used the functionality for a number of months Thanks, Robert Marshall

Review Request 129633: Bug 335217 means that show in media sources doesn't expand trees, this patch adds a user option

https://git.reviewboard.kde.org/r/129633/diff/ Testing --- Built amarok and used the functionality for a number of months Thanks, Robert Marshall

Re: Review Request 123635: Fix minor typo in PlaylistLengthEditWidget.ui

reply, visit: https://git.reviewboard.kde.org/r/123635/#review79895 --- On May 4, 2015, 8:15 p.m., Robert Marshall wrote: > > --- > This is an automatically generated e-ma

Review Request 123635: Fix minor typo in PlaylistLengthEditWidget.ui

ng word to whatsThis text the same change needs making to PlaylistLengthEditWidget.ui Thanks, Robert Marshall ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 122870: There are still places in the amarok code and documentation where 'song' is used rather than 'track'

.reviewboard.kde.org/r/122870/diff/ Testing --- Built and tested that the new strings are displayed correctly. Single review for all changes as discussed in https://bugs.kde.org/show_bug.cgi?id=343896 Thanks, Robert Marshall ___ Amarok-devel

Review Request 120073: Add a never played filter to the built in collection filters

https://git.reviewboard.kde.org/r/120073/diff/ Testing --- Built amarok Tested filter behaves as expected Thanks, Robert Marshall ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 119509: Don't clear the playlist if amarok is playing on generating an APG

playlist is cleared. Diffs - src/playlistgenerator/Preset.cpp f670647 Diff: https://git.reviewboard.kde.org/r/119509/diff/ Testing --- Built Tested with generation of APGs both amarok stopped and playing tracks. I've used this change for 6+months without any problems

Review Request 119509: Don't clear the playlist if amarok is playing on generating an APG

rc/playlistgenerator/Preset.cpp f670647 Diff: https://git.reviewboard.kde.org/r/119509/diff/ Testing --- Built Tested with generation of APGs both amarok stopped and playing tracks. I've used this change for 6+months without any problems

Re: Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist

ddition to a playlist displays correctly. Checked that on running the playlist it looks like random tracks are being added Thanks, Robert Marshall ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 118864: Don't prompt the user if the directories are not empty when moving tracks to trash

with my testing. Thanks, Robert Marshall ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 118864: Don't prompt the user if the directories are not empty when moving tracks to trash

ed Do I need a bug/enhancement report to tie to this? I wondered whether this change might be inefficient if the collection has many levels but seems to be ok at least with my testing. Thanks, Robert Marshall ___ Amarok-devel mailing list Amarok-deve

Re: Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist

t; Please don't forget to add relevant tags to commit: > > > > > REVIEW: ... > > BUG: ... > > FIXED-IN: ... > > > > - Matěj > > > On July 23rd, 2014, 5:07 p.m. CEST, Robert Marshall wrote: > > Review request for Amarok. > By Ro

Re: Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist

running the playlist it looks like random tracks are being added Thanks, Robert Marshall ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist

random tracks are being added Thanks, Robert Marshall ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel