Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-06 Thread Omar Plummer
marked as submitted. Review request for Amarok. Changes --- Submitted with commit fec8817c530ce42b6485fdabff6051784b8d9904 by Konrad Zemek on behalf of Omar Plummer to branch master. Bugs: https://bugs.kde.org/show_bug.cgi?id=351013 https://bugs.kde.org/show_bug.cgi?id=https

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-06 Thread Omar Plummer
> On Aug. 6, 2015, 9:52 p.m., Omar Plummer wrote: > > Ship It! Ok, I'm not sure what I did there with the "Ship It!" button. I'm new to this reviewborad thing so please forgive any hiccups while I familiarize myself with the rules and procedures. That said; Tha

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-06 Thread Omar Plummer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124639/#review83515 --- Ship it! Ship It! - Omar Plummer On Aug. 6, 2015, 9:45

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-06 Thread Omar Plummer
searched :1.7, found 1.10.0 Diffs (updated) - cmake/modules/FindTaglib.cmake 76b83ac Diff: https://git.reviewboard.kde.org/r/124639/diff/ Testing --- Thanks, Omar Plummer ___ Amarok-devel mailing list Amarok-devel@kde.org https

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-06 Thread Omar Plummer
STRLESS "1.7.0"` is true, `"1.7" > > VERSION_LESS "1.7.0"` is false. > > Omar Plummer wrote: > I'm not sure I follow, so please bear with me if I'm missing something > simple. > > Isn't "1.7" technically equivale

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-06 Thread Omar Plummer
STRLESS "1.7.0"` is true, `"1.7" > > VERSION_LESS "1.7.0"` is false. > > Omar Plummer wrote: > I'm not sure I follow, so please bear with me if I'm missing something > simple. > > Isn't "1.7" technically equivale

Re: Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-06 Thread Omar Plummer
"1.7.0" should in fact be false? - Omar --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124639/#review83480 --- On Aug. 6, 2015

Review Request 124639: Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7

2015-08-05 Thread Omar Plummer
: https://git.reviewboard.kde.org/r/124639/diff/ Testing --- Thanks, Omar Plummer ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel