Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2016-07-12 Thread Olivier Churlaud
where. - Olivier Churlaud On Sept. 15, 2015, 7:18 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2016-06-21 Thread Olivier Churlaud
> On June 21, 2016, 12:42 a.m., Olivier Churlaud wrote: > > Ship It! > > Olivier Churlaud wrote: > It should work with new version: it's a must. If people complain about > older version being broken, then we can see. But archlinux won't be able to

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2016-06-20 Thread Olivier Churlaud
> On June 21, 2016, 12:42 a.m., Olivier Churlaud wrote: > > Ship It! It should work with new version: it's a must. If people complain about older version being broken, then we can see. But archlinux won't be able to ship Amarok without th

Re: Review Request 128265: Fix compilation with ffmpeg 3.0

2016-06-20 Thread Olivier Churlaud
/diff/ Testing --- Compiles Thanks, Olivier Churlaud

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

2016-06-20 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126682/#review96762 --- Ship it! Ship It! - Olivier Churlaud On Jan. 9, 2016

Re: Review Request 128265: Fix compilation with ffmpeg 3.0

2016-06-20 Thread Olivier Churlaud
complete and detailed: https://git.reviewboard.kde.org/r/126682 - Olivier Churlaud On June 21, 2016, 12:32 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Review Request 128265: Fix compilation with ffmpeg 3.0

2016-06-20 Thread Olivier Churlaud
--- Change deprecated code See: https://ffmpeg.org/pipermail/ffmpeg-cvslog/2013-December/071930.html Diffs - src/musicbrainz/MusicDNSAudioDecoder.cpp ea39a1b Diff: https://git.reviewboard.kde.org/r/128265/diff/ Testing --- Compiles Thanks, Olivier Churlaud

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
> On June 20, 2016, 10:27 p.m., Matěj Laitl wrote: > > Looks well, one minor thing below - unrelated change. > > > > Also please mention: > > BUG: 348313 > > ..in the commit message and include a ChangeLog entry in the patch. > > Olivier Churlaud

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
marked as submitted. Review request for Amarok and Myriam Schweingruber. Changes --- Submitted with commit 8c15258b28870b6d9990b24f87ce913e2049bac8 by Olivier CHURLAUD to branch master. Bugs: 349313 https://bugs.kde.org/show_bug.cgi?id=349313 Repository: amarok Description

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
ard.kde.org/r/128248/#review96755 --- On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Olivier Churlaud
viewboard.kde.org/r/128248/#review96755 --- On June 19, 2016, 11:44 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Olivier Churlaud
econd review - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/#review96712 --- On June 19, 2016, 11:44 a.m

Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Olivier Churlaud
don't want to mess my install. Thanks, Olivier Churlaud

Port to KF5: Just bored

2015-12-02 Thread Olivier Churlaud
o tell you what is on my mind. Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http://olivi

Re: [KF5 Port] Threads don't exit with Application

2015-12-02 Thread Olivier Churlaud
Hi, I found the problem: m_directoryWatcher->abort(); is never triggered, because ~SqlCollection() is never called. I don't know why, and as usual, I have no idea of how the whole thing was thought. Can someone give some help on this? Thank you Olivier Le 29/11/2015 20:29,

Re: Review Request 126171: Compare directories finishing by trailing slash

2015-12-02 Thread Olivier Churlaud
marked as submitted. Review request for Amarok, Maximilian Kossick and Ralf Engels. Changes --- Submitted with commit 8c8392e95455bd9bf83fa4ddc910f9835351aa3b by Olivier CHURLAUD to branch kf5. Repository: amarok Description --- [This goes on the KF5 branch] After porting KUrl to

[KF5 Port] Threads don't exit with Application

2015-11-29 Thread Olivier Churlaud
I tried to find why Amarok does not exit without being killed. Here is the backtrace of the threads... I have no idea of how to solve this... There are several one but I put just a part, because all others repeat themselves like the 8th. Any input would be very welcomed Thx Thread 8 (

Fwd: [beta] Scripts: Any notable changes?

2015-11-28 Thread Olivier Churlaud
Hi, I'm wondering if there is no notable changes in the way Amarok handle scripts. On the beta version, AmaroKontrol is now crashing Amarok. I know that it's a third-party software, but I think the crash must be because of some changes in our scripts engin... Thanks Olivier __

Fwd: Re: Custom shell/container in plasma for applications

2015-11-26 Thread Olivier Churlaud
00 De :Olivier Churlaud Répondre à :kde-de...@kde.org Pour : kde-de...@kde.org I forgot to say: if you want to try it, please use the branch of plasma-framework mart/customShell Cheers Olivier Le 26/11/2015 22:07, Olivier Churlaud a écrit : Hi, with the help of notmart, I created c

Re: Review Request 126005: Began to port tests

2015-11-25 Thread Olivier Churlaud
> On nov. 15, 2015, 2:11 après-midi, Olivier Churlaud wrote: > > Any comments/reviews? > > Olivier Churlaud wrote: > ping ? I added some people who wrote the Tests... - Olivier --- This is an automatically ge

Review Request 126171: Compare directories finishing by trailing slash

2015-11-25 Thread Olivier Churlaud
November/013852.html Diffs - src/core-impl/collections/db/MountPointManager.cpp e14cb18 Diff: https://git.reviewboard.kde.org/r/126171/diff/ Testing --- Build, and folders saved in the database Thanks, Olivier Churlaud ___ Amarok-dev

Re: Review Request 126005: Began to port tests

2015-11-25 Thread Olivier Churlaud
> On nov. 15, 2015, 2:11 après-midi, Olivier Churlaud wrote: > > Any comments/reviews? ping ? - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126005/#re

Re: Review Request 126128: Port EqualizerDialog

2015-11-25 Thread Olivier Churlaud
marked as submitted. Review request for Amarok and Ralf Engels. Changes --- Submitted with commit b0fd33cf4a25d18364e7f6fb6fef5decae24c173 by Olivier CHURLAUD to branch kf5. Repository: amarok Description --- EqualizerDialog is now a QDialog Diffs - src/dialogs

[Port to KF5] Time to work on contexts

2015-11-25 Thread Olivier Churlaud
wer my question about how to replace QtScripts... But this is not for now :) Cheers! Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchu

Re: Review Request 126128: Port EqualizerDialog

2015-11-24 Thread Olivier Churlaud
automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126128/#review88772 ------- On nov. 21, 2015, 4:02 après-midi, Olivier Churlaud wrote: > > --- > This

Re: Review Request 126128: Port EqualizerDialog

2015-11-22 Thread Olivier Churlaud
nerated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126128/#review88699 --- On nov. 21, 2015, 4:02 après-midi, Olivier Churlaud wrote: > > --- > This is an automat

Re: [KF5 Port] Impossible to run since update to 5.16

2015-11-21 Thread Olivier Churlaud
I didn't know so I share with you (in case): ctest 31,31 -V (or -VV) is the command to run the test 31 and get the details of what failed and what not. I get a lot of errors with the bitrates: any ideas of why I get 257 instead of 256? Cheers Olivier Le 21/11/2015 16:36, Olivier Chu

Re: [KF5 Port] Impossible to run since update to 5.16

2015-11-21 Thread Olivier Churlaud
- Beginning to write QML code (I hope I can reach rengels...) Cheers Olivier Le 21/11/2015 10:22, Olivier Churlaud a écrit : I removed ~/.local/share/amarok and... I can't run anymore all the tests: tests/testsqlcollection: error while loading shared libraries: ../../../../../

Review Request 126128: Port EqualizerDialog

2015-11-21 Thread Olivier Churlaud
. Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

[KF5 Port] To the seniors: Path of directories

2015-11-21 Thread Olivier Churlaud
d (check that it's a directory, if no trailing slash, add one) in line 235 I would say. Please tell me what solution is better, else I'll try the 3rd one and see what happens. Cheers Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin

Re: [KF5 Port] Impossible to run since update to 5.16

2015-11-21 Thread Olivier Churlaud
I removed ~/.local/share/amarok and... I can't run anymore all the tests: tests/testsqlcollection: error while loading shared libraries: ../../../../../src/core-impl/storage/sql/mysqlestorage/amarok_storage-mysqlestorage.so: cannot open shared object file: No such file or directory ... I still

[KF5 Port] Impossible to run since update to 5.16

2015-11-20 Thread Olivier Churlaud
file or directory and the application crashes where it didn't before Can you check on your side please? -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linke

Deprecation of QtScript

2015-11-20 Thread Olivier Churlaud
rk is still hidden here" Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http://olivier.ch

Re: Review Request 126005: Began to port tests

2015-11-15 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126005/#review88383 --- Any comments/reviews? - Olivier Churlaud On nov. 9, 2015

Re: Review Request 126005: Began to port tests

2015-11-09 Thread Olivier Churlaud
) 45 - testtrackloader (Failed) 46 - testdynamicmodel (Failed) << Corrected but memory leak now. 49 - testplaylistfileprovider (Failed) Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/li

Re: Review Request 126005: Began to port tests

2015-11-09 Thread Olivier Churlaud
> On nov. 9, 2015, 1:12 après-midi, Olivier Churlaud wrote: > > src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp, line 401 > > <https://git.reviewboard.kde.org/r/126005/diff/1/?file=415876#file415876line401> > > > > This line doesn't concern

Re: Review Request 126005: Began to port tests

2015-11-09 Thread Olivier Churlaud
- testdynamicmodel (Failed) << Corrected but memory leak now. 49 - testplaylistfileprovider (Failed) Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125126: Port of main.cpp and App class

2015-11-09 Thread Olivier Churlaud
App::continueInit(). I'm not able to trace it further. Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 126005: Began to port tests

2015-11-09 Thread Olivier Churlaud
- testplsplaylist (Failed) 43 - testxspfplaylist (Failed) 45 - testtrackloader (Failed) 46 - testdynamicmodel (Failed) << Corrected but memory leak now. 49 - testplaylistfileprovider (Failed) Thanks, Olivier Churlaud ___ Amarok-devel mailin

Re: Review Request 126005: Beginned to port tests

2015-11-09 Thread Olivier Churlaud
- testdynamicmodel (Failed) << Corrected but memory leak now. 49 - testplaylistfileprovider (Failed) Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 126005: Beginned to port tests

2015-11-09 Thread Olivier Churlaud
476> This comment should be removed. tests/dynamic/TestDynamicModel.cpp <https://git.reviewboard.kde.org/r/126005/#comment60478> this caused a segfault. Removing it solve the issue but causes a memory leak - Olivier Churlaud On nov. 9, 2015, 1:08 après-midi,

Review Request 126005: Beginned to port tests

2015-11-09 Thread Olivier Churlaud
(Failed) 41 - testm3uplaylist (Failed) 42 - testplsplaylist (Failed) 43 - testxspfplaylist (Failed) 45 - testtrackloader (Failed) 46 - testdynamicmodel (Failed) << Corrected but memory leak now. 49 - testplaylistfileprovider (Failed) Thanks, Olivier Ch

Re: [Port KF5] Next steps: tests and context

2015-11-08 Thread Olivier Churlaud
49 - testplaylistfileprovider (Failed) 51 - testtimecodetrackprovider (Failed) Cheers Oliveir Le 08/11/2015 12:44, Olivier Churlaud a écrit : Hi, I still have a commit to send to fix the database (I'm waiting for your input for this). Now there are 3 things to do: - us

[Port KF5] Next steps: tests and context

2015-11-08 Thread Olivier Churlaud
works and how the classes interact, so that we gain time and port everything in the good order. The bonus is that it will be documented for the future. Cheers Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @:

Re: Porting to KF5: DBus policies

2015-11-07 Thread Olivier Churlaud
still relevant? Cheers Olivier Le 07/11/2015 23:00, Olivier Churlaud a écrit : Hi, Since there are some problem to quit the app, I dug a little in the DBus of Amarok. I have several questions: 1) Why are we using org.mpris.MediaPlayer2.amarok ? Should we go to org.kde.amarok? (To me it would

Porting to KF5: DBus policies

2015-11-07 Thread Olivier Churlaud
ris2( this ); and is the order important? Thx Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud web: http://olivier.ch

Re: [KF5Port] Next-bug: mysql ?

2015-11-07 Thread Olivier Churlaud
) As you can see the only difference comes from the last '/'. Solutions: What should I do? Do I hardcode 'm_foundDirectories.contains( path+'/') ? I tried and it works.. Do you have a better solution? I'll try to find the difference with 2.8, but I'd like to

[KF5Port] Next-bug: mysql ?

2015-11-03 Thread Olivier Churlaud
the end I still need to kill Amarok (for this I think that it's an issue in the way I used D-Bus in the porting). How is it on your side? Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com

Re: [Senior Devs] Amarok and SQL queries

2015-11-01 Thread Olivier Churlaud
Le 01/11/2015 18:15, Soren Harward a écrit : On Sun, Nov 1, 2015 at 6:15 AM, Olivier Churlaud wrote: I wonder: why are the mysql libraries directly used and not the Qt framework (QSqlQueries and so on)? IIRC, it's entirely historical. For a handful of reasons that were valid in 200

[Senior Devs] Amarok and SQL queries

2015-11-01 Thread Olivier Churlaud
? Not to add more dependencies? For something else? I was just surprised to see it, so I ask. Thank you :) Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87691 --- Ship it! Ship It! - Olivier Churlaud On oct. 29, 2015, 6

New branch KF5_Kuniqueapp

2015-10-26 Thread Olivier Churlaud
you want, play around with this new branch. We are still working on this with Rishabh Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in

Re: segfault

2015-10-25 Thread Olivier Churlaud
Hi, Here is the valgrind trace I get https://paste.kde.org/pf8mjfzr4 I don't understand well what it means... Thx Olivier Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in:

Re: Fwd: segfault(kf5 port olivier )

2015-10-25 Thread Olivier Churlaud
-- From: *RISHABH GUPTA* <mailto:rishabh9...@gmail.com>> Date: Fri, Oct 23, 2015 at 1:51 PM Subject: segfault(kf5 port olivier ) To: amarok-devel@kde.org <mailto:amarok-devel@kde.org> Message: 2Date: Tue, 20 Oct 2015 22:50:25 +0200 From: Olivier Churlaud mailto:oliv.

Re: [KF5 port] Source of sigfault found, not understood

2015-10-22 Thread Olivier Churlaud
Le 23/10/2015 01:32, Soren Harward a écrit : On Wed, Oct 21, 2015 at 7:42 AM Myriam Schweingruber mailto:myr...@pharma-traduction.ch>> wrote: UserRole and GroupRole are not exactly the same thing, will this not make the Playlist behave differently? Not sure if changing behavior is

Re: [Port KF5] Why we get so many segfault...

2015-10-22 Thread Olivier Churlaud
Hi, once again I was wrong. The issue is triggered according to what you comment in the listForLevel() function (the one I was talking about sooner)... But what exactly and why? I'm still searching... Olivier Le 22/10/2015 20:03, Olivier Churlaud a écrit : Hi, Le 22/10/2015 18:22, A

Re: [Port KF5] Why we get so many segfault...

2015-10-22 Thread Olivier Churlaud
Hi, Le 22/10/2015 18:22, Aditya Sharma a écrit : Hello, Sorry for not being able to get back to you on IRC. I have been busy with another project of mine at my university for quite some time now. If a method was virtual before and is pure virtual now then one can't cal

Re: [KF5 port] Source of sigfault found, not understood

2015-10-21 Thread Olivier Churlaud
Hi > Le 21 oct. 2015 à 13:42, Myriam Schweingruber a > écrit : > > Hi Olivier, > >> On Wed, Oct 21, 2015 at 12:39 PM, Olivier Churlaud >> wrote: >> I think I found the source of the error: >> >> TrackRole is defined as Qt::UserRole which

Re: [KF5 port] Source of sigfault found, not understood

2015-10-21 Thread Olivier Churlaud
? Cheers Olivier Le 21/10/2015 11:30, Olivier Churlaud a écrit : Hi, the error I was tracking occures in src/playlist/proxymodels/GroupingProxy.cpp Meta::TrackPtr prevTrack = prevIndex.data( TrackRole ).value();// Invalid index is OK: Meta::TrackPtr thisTrack = thisIndex.data

[KF5 port] Source of sigfault found, not understood

2015-10-21 Thread Olivier Churlaud
QCoreApplication::exec() () from /usr/lib/libQt5Core.so.5 ---Type to continue, or q to quit--- #39201 0x0040c202 in main (argc=1, argv=0x7fffe028) at /home/olivier/Projets/amarok/src/main.cpp:347 -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU

[Port KF5] Help to debug

2015-10-20 Thread Olivier Churlaud
annot trace the error in a good way. How would you do this? Thank you for your help Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.c

[Port KF5] Why we get so many segfault...

2015-10-20 Thread Olivier Churlaud
them with, before the line #pragma message("PORTKF5: X lines here") so that at compilation time we can easily find what still needs to be changed. After that, we'll have to either remove the lines or reimplement them. Cheers & Have fun! Olivier -- Olivier CHURLAUD Engine

[Port KF5] Aditya's commit

2015-10-13 Thread Olivier Churlaud
nough. Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: olivier.churl...@ecl2015.ec-lyon.fr tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivierchurlaud; web: http://olivier.churlau

[Port KF5] Plugins

2015-10-13 Thread Olivier Churlaud
rt QT_PLUGIN_PATH=/home/olivier/Projets/bin_amarok/lib64/plugins Then you get a segfault. backtrace : https://paste.kde.org/pudfq87od trace: https://paste.kde.org/p8huiotxh The next step is to correct this... Cheers! Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual

Fwd: [Port KF5] Aditya's commit

2015-10-13 Thread Olivier Churlaud
Please forget the message I sent (see below). I wasn't on the good branch. @Aditya: Just take in account my advice for the commits. Cheers, and keep up the good job! Olivier --- Hi, Aditya's commit prevent me to compile to 100%, which is a regression. Is it the same for you? Here is my output

Re: Review Request 125593: removed the Line that deleted m_args

2015-10-11 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125593/#review86663 --- Ship it! Ship It! - Olivier Churlaud On oct. 11, 2015, 3

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Olivier Churlaud
Hi, Ship It! Please commit on my behalf. I don't have a dev account :) Then request one ! https://techbase.kde.org/Contribute/Get_a_Contributor_Account#How_to_get_read-write_access_to_git.2Fsvn Cheers, Olivier ___ Amarok-devel mailing li

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125519/#review86342 --- Ship it! Ship It! - Olivier Churlaud On oct. 4, 2015, 7

Re: Applying Churlaud's patch - KF5/Qt5

2015-10-04 Thread Olivier Churlaud
I commit my patch now, please commit yours afterwards so that we don't mess up everything :) Olivier Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.c

Re: Applying Churlaud's patch - KF5/Qt5

2015-10-04 Thread Olivier Churlaud
Hi there, Le 03/10/2015 22:23, Aditya Sharma a écrit : I applied Olivier's patch from the Review Board. He has still not committed anything so I proceeded anyway with his patch. I'll commit anyway today, so that everyone can work from the same basis... If at the end, someone thinks it's not w

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Olivier Churlaud
. 25, 2015, 10:42 après-midi) > > > Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam > Schweingruber. > > > Repository: amarok > > > Description > --- > > We need the Qt5 version of LibLastFm (ie liblastfm5) . Even after installin

Re: KF5 Port Status

2015-09-26 Thread Olivier Churlaud
Hi, Le 25/09/2015 11:23, Myriam Schweingruber a écrit : Hi Aditya, On Thu, Sep 24, 2015 at 3:44 PM, Aditya Sharma wrote: So finally I am over with my University Exams and have a lot of time up my sleeve. Nice :) What's the current porting status ? Normally the latest porting status should

Re: kf5port(olivier)

2015-09-15 Thread Olivier Churlaud
; Message: 3 >> Date: Mon, 14 Sep 2015 14:55:30 +0200 >> From: Olivier Churlaud >> To: amarok-devel@kde.org >> Subject: Re: kf5port(olivier) >> Message-ID: <55f6c3c2.8050...@churlaud.com> >> Content-Type: text/plain; charset="utf-8"; Format="flo

Re: Playlists

2015-09-15 Thread Olivier Churlaud
Le 15/09/2015 17:12, Soren Harward a écrit : On Tue, Sep 15, 2015 at 10:14 AM, Olivier Churlaud wrote: 1) Does the Automatic Playlist Generator work on your system? Nothing happens here, it may be broken. I pushed some fixes a couple months ago, but the origin/kf5 branch hasn't been up

Playlists

2015-09-15 Thread Olivier Churlaud
le to choose fast there. (without having to type ' added:<4w ' ) Thank you ! Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivier

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-09-14 Thread Olivier Churlaud
> On sep. 13, 2015, 6:59 après-midi, Olivier Churlaud wrote: > > Regarding the code, everything seems fine. Now the real question is about > > the shortcuts. Are they really good? Logical? > > > > I'm not the one to judge on this. But a Shift+E for instance m

Re: kf5port(olivier)

2015-09-14 Thread Olivier Churlaud
ServiceQueryMaker.cpp 0c5913a >> src/services/opmldirectory/OpmlDirectoryInfoParser.cpp f6ac752 >> >> Diff: https://git.reviewboard.kde.org/r/125126/diff/ >> >> >> Testing >> --- &g

Re: kf5 port(olivier)

2015-09-14 Thread Olivier Churlaud
Can you go on #amarok.dev ? So that we can check your config ? Le 14/09/2015 13:36, Aditya Sharma a écrit : Hey ! Then apply the last diff from the review board and see if you can help me to cgo further and clean it up. ;) Applied your last diff, using patch -p1 < pa

Re: KF5 port continued

2015-09-14 Thread Olivier Churlaud
Le 14/09/2015 13:29, Aditya Sharma a écrit : thanks Somsubhra for making the port compile. I compiled it and got a segfault related to liblastfm. Please note that the Qt5 liblastfm is called liblastfm5.so, I changed this for lastfm & mygpo-qt in CMakeLists Exactly what ch

Re: kf5 port(olivier)

2015-09-14 Thread Olivier Churlaud
Le 14/09/2015 00:21, Aditya Sharma a écrit : Hi, Hey ! Then apply the last diff from the review board and see if you can help me to cgo further and clean it up. ;) Applied your last diff, using patch -p1 < patch.txt But the Segmentation fault remains the same. The same Q

Re: Kf5 port(olivier)

2015-09-14 Thread Olivier Churlaud
> Le 14 sept. 2015 à 10:51, RISHABH GUPTA a écrit : > > >> -- >> >> Message: 3 >> Date: Sun, 13 Sep 2015 17:59:49 - >> From: "Olivier Churlaud" >> To: "Olivier Churlaud" , "Amarok"

Re: kf5 port(olivier)

2015-09-13 Thread Olivier Churlaud
Hi, Then apply the last diff from the review board and see if you can help me to cgo further and clean it up. ;) Cheers Olivier Sur 13 sept. 2015 23:33, à 23:33, Aditya Sharma a écrit: >I'd like to add, this is what happens with me. >I haven't applied any diffs. Only the latest KF5 commits.

Re: Review Request 125126: Port of main.cpp and App class

2015-09-13 Thread Olivier Churlaud
https://git.reviewboard.kde.org/r/125126/diff/ Testing --- It compiles 100%, and there is a segmentation fault after the end of the App::continueInit(). I'm not able to trace it further. Thanks, Olivier Churlaud ___ Amarok-devel mailing l

Re: Port KF5

2015-09-13 Thread Olivier Churlaud
at the different parts of the project are not as independent as expected. Cheers. Olivier Le 13/09/2015 18:56, Olivier Churlaud a écrit : Here is my full log : http://pastebin.com/Z28JJERv I think you didn't apply the diff well Le 13/09/2015 18:52, Olivier Churlaud a écrit : Hi Ribash, How

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-09-13 Thread Olivier Churlaud
question is about the shortcuts. Are they really good? Logical? I'm not the one to judge on this. But a Shift+E for instance might have bad repercussions (if you type Editors in the search field, what happens? Is the slot triggered?) If Mamarok says it's ok, then ship it. - Olivier Chu

Re:Port KF5

2015-09-13 Thread Olivier Churlaud
Here is my full log : http://pastebin.com/Z28JJERv I think you didn't apply the diff well Le 13/09/2015 18:52, Olivier Churlaud a écrit : Hi Ribash, How come the line was missing? Did you apply the diff to the project ? Didi you use the second one (don't take care of the 1st)

Re: Amarok-devel Digest, Vol 104, Issue 15

2015-09-13 Thread Olivier Churlaud
Hi Ribash, How come the line was missing? Did you apply the diff to the project ? Didi you use the second one (don't take care of the 1st) Your log is very interesting, what debugger do you use? With gdb, I can't get such a deep description (but I may not know how to use it well). With such

Re: kf5 port(olivier)

2015-09-13 Thread Olivier Churlaud
here's the output http://pastebin.com/5StyEUth Huuu Wait, it's not possible. My segfault doesn't happen in handleCliArgs() but way after... It means that I left a bug, that works on my system but not yours OR that something is wrong on your side. Please investigate why this happen, I'll d

Re: kf5 port(olivier)

2015-09-13 Thread Olivier Churlaud
ours OR that something is wrong on your side. Please investigate why this happen, I'll do this on my side too. Cheers, Olivier Thanks, Olivier Churlaud thanks, rishabh ___ Amarok-deve

Re: Review Request 125126: Port of main.cpp and App class

2015-09-12 Thread Olivier Churlaud
g/r/125126/#comment58933> This should not be an option but a positionalArgument - Olivier Churlaud On sep. 12, 2015, 2:05 après-midi, Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Preparing to move to Phabricator

2015-09-12 Thread Olivier Churlaud
Hey, great news! Did you already request a Project repo / space for Amarok? It's way more user friendly than bugzilla :) Cheers, Olivier Le 12/09/2015 13:34, Myriam Schweingruber a écrit : Dear all, KDE is preparing to move to http://phabricator.kde.org to replace the current systems (pro

Re: Review Request 125076: fatal error: kdemacros.h: No such file or directory at 2%

2015-09-12 Thread Olivier Churlaud
> On sep. 11, 2015, 5:37 après-midi, Olivier Churlaud wrote: > > Ship It! > > Aditya Dev Sharma wrote: > I don't have a KDE developer account. Could you push it on my behalf ? > Thanks ! > > Olivier Churlaud wrote: > of course it's needed :)

Re: Review Request 125126: Port of main.cpp and App class

2015-09-12 Thread Olivier Churlaud
. Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125076: fatal error: kdemacros.h: No such file or directory at 2%

2015-09-12 Thread Olivier Churlaud
> On sep. 11, 2015, 5:37 après-midi, Olivier Churlaud wrote: > > Ship It! > > Aditya Dev Sharma wrote: > I don't have a KDE developer account. Could you push it on my behalf ? > Thanks ! of course

Time for QML

2015-09-11 Thread Olivier Churlaud
at the coding way is completely different since the view (QML) is totally separated from the functions. So there will be a lot of reprogramming to do... If you have some knowledge in qml, please let me know!! Have fun! Cheers, Olivier -- Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon

Re: Porting to KF5: help needed on KServiceTypeTrader

2015-09-11 Thread Olivier Churlaud
Sorry for this, the problem was due to the wrong kdemacros.h in headers (the KDE4 instead of KF5 one) Olivier Le 11/09/2015 17:41, Olivier Churlaud a écrit : Hi, I'm looking for the help of someone who is better than I am with the KDE libs. I began to port the main files out of KD

Porting to KF5: help needed on KServiceTypeTrader

2015-09-11 Thread Olivier Churlaud
Hi, I'm looking for the help of someone who is better than I am with the KDE libs. I began to port the main files out of KDE4. I now have this problem: /KServiceTypeTrader: serviceType "Amarok/Plugin" not found/ It happens in the file src/PluginManager, in findPlugins(). I'm quite discoverin

Re: Review Request 125076: fatal error: kdemacros.h: No such file or directory at 2%

2015-09-11 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125076/#review85199 --- Ship it! Ship It! - Olivier Churlaud On sep. 6, 2015, 7

Review Request 125126: Port of main.cpp and App class

2015-09-09 Thread Olivier Churlaud
correct or not. http://pastebin.com/naduYv8M There are still some small things that aren't port. (for instance calling a second instance to use the --play, -r,...) Thanks, Olivier Churlaud ___ Amarok-devel mailing list Amarok-devel@kde.org

Re: KF5 port continued

2015-09-09 Thread Olivier Churlaud
Hi, I'll send tomorrow the porting of main and App to KF5... I'll tell you if i have some troubles. Cheers Olivier Sur 7 sept. 2015 17:55, à 17:55, Olivier Churlaud a écrit: >Hi, > >First of all, I join Stefan to say thx to Somsubhra ! > >The next step is to

  1   2   >