Re: Review Request: Mark podcast episodes to keep

2012-09-25 Thread Lucas Gomes
lPodcastProvider.cpp 874738996d02970761d0701c0cd8634302659ed2 src/core/podcasts/PodcastMeta.h c2b5b2fe73295837c5e14fc3deb397208fecce1f src/playlistmanager/SyncedPodcast.h 5c270b1b2ca29a2226d79c4835c4a8c30a0d5fa3 Diff: http://git.reviewboard.kde.org/r/100998/diff/ Testing ---

Re: Review Request: GPodder Improvements Patch Rev2

2012-08-16 Thread Lucas Gomes
onal. - Lucas --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104335/#review17525 --- On March 25, 2012, 8:34 p.m., Lu

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes
On March 22, 2012, 10:04 p.m., Lucas Gomes wrote: > > Could you please explain what are the benefits (direct, current - not > > hypothetical or philosofical) of the TreeItem -> NormalTreeItem, > > MergedTreeItem split? Where exactly is avoids code duplication? > >

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-06-01 Thread Lucas Gomes
On March 22, 2012, 10:04 p.m., Lucas Gomes wrote: > > Could you please explain what are the benefits (direct, current - not > > hypothetical or philosofical) of the TreeItem -> NormalTreeItem, > > MergedTreeItem split? Where exactly is avoids code duplication? Ok, first

Re: Review Request: GPodder Improvements Patch Rev2

2012-03-25 Thread Lucas Gomes
/GpodderSortFilterProxyModel.cpp ed1e8301f6f415e86e5367b7827817fff45feb98 Diff: http://git.reviewboard.kde.org/r/104335/diff/ Testing --- This patch should build. Everything is working as expected and there aren't any known issues. Thanks, Lucas Gomes ___ Amarok-

Re: Review Request: GPodder Improvements Patch Rev1

2012-03-20 Thread Lucas Gomes
is working as expected and there aren't any known issues. Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: GPodder Improvements Patch Rev1

2012-03-20 Thread Lucas Gomes
as expected and there aren't any known issues. Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request: GPodder Service improvements

2012-03-19 Thread Lucas Gomes
. Everything is working as expected and there aren't any known issues. Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

2012-02-09 Thread Lucas Gomes
it.reviewboard.kde.org/r/100998/#review10413 ------- On Feb. 8, 2012, 11:15 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

2012-02-09 Thread Lucas Gomes
vider.h c3d5e56 src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f src/core/podcasts/PodcastMeta.h 679f7ac src/playlistmanager/SyncedPodcast.h c186df2 Diff: http://git.reviewboard.kde.org/r/100998/diff/diff Testing --- Thanks, Lucas Gomes

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

2012-02-07 Thread Lucas Gomes
/podcasts/sql/SqlPodcastProvider.cpp 183005f src/core/podcasts/PodcastMeta.h 679f7ac src/playlistmanager/SyncedPodcast.h c186df2 Diff: http://git.reviewboard.kde.org/r/100998/diff/diff Testing --- Thanks, Lucas Gomes ___ Amarok-devel mailin

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

2012-01-31 Thread Lucas Gomes
/sql/SqlPodcastProvider.h c3d5e56 src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f src/core/podcasts/PodcastMeta.h 679f7ac src/playlistmanager/SyncedPodcast.h c186df2 Diff: http://git.reviewboard.kde.org/r/100998/diff/diff Testing --- Thanks, Lucas Gomes ___

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-30 Thread Lucas Gomes
------- On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103603/ >

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

2012-01-30 Thread Lucas Gomes
casts/sql/SqlPodcastProvider.h c3d5e56 src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 183005f src/core/podcasts/PodcastMeta.h 679f7ac Diff: http://git.reviewboard.kde.org/r/100998/diff/diff Testing --- Thanks, Lucas Gomes ___ Amarok-

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-29 Thread Lucas Gomes
diff/diff Testing --- This patch should build. Everything is working as expected and there aren't any known issues. Screenshots (updated) --- CollectionBrowser http://git.reviewboard.kde.org/r/103603/s/420/ PodcastBrowser http://git.reviewboard.kde.org/r/103603/s/423/

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-27 Thread Lucas Gomes
creenshots (updated) --- CollectionBrowser http://git.reviewboard.kde.org/r/103603/s/420/ PodcastBrowser http://git.reviewboard.kde.org/r/103603/s/421/ Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-04 Thread Lucas Gomes
--- PodcastBrowser http://git.reviewboard.kde.org/r/103603/s/402/ CollectionBrowser http://git.reviewboard.kde.org/r/103603/s/401/ Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-04 Thread Lucas Gomes
and there aren't any known issues. Screenshots (updated) --- PodcastBrowser http://git.reviewboard.kde.org/r/103603/s/402/ CollectionBrowser http://git.reviewboard.kde.org/r/103603/s/401/ Thanks, Lucas Gomes ___ Amarok-devel maili

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes
.org/r/103603/s/390/ Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes
tMeta.cpp b9851f7 src/widgets/TrackSelectWidget.cpp 5bd5059 Diff: http://git.reviewboard.kde.org/r/103603/diff/diff Testing --- This patch should build. Everything is working as expected and there aren't any known issues. Thanks, Lucas Gomes

Review Request: Some changes to make Amarok appearance more pretty

2012-01-02 Thread Lucas Gomes
c/widgets/TrackSelectWidget.cpp 5bd5059 Diff: http://git.reviewboard.kde.org/r/103603/diff/diff Testing --- This patch should build. Everything is working as expected and there aren't any known issues. Thanks, Lucas Gomes ___ Amarok-devel mailing lis

Review Request: Some clean-up and sort

2011-11-21 Thread Lucas Gomes
dder/GpodderTreeItem.cpp a772e4a Diff: http://git.reviewboard.kde.org/r/103195/diff/diff Testing --- Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Important bugfixes to Gpodder Service

2011-11-13 Thread Lucas Gomes
Playlist.h 0e94576 src/playlistmanager/SyncedPlaylist.cpp eaa856f src/playlistmanager/SyncedPodcast.h 85c80fc src/playlistmanager/SyncedPodcast.cpp 92dd6f8 src/services/gpodder/GpodderProvider.cpp 2ba0bf3 Diff: http://git.reviewboard.kde.org/r/103122/diff/diff Testing --- Than

Review Request: Important bugfixes to Gpodder Service

2011-11-13 Thread Lucas Gomes
istmanager/SyncedPlaylist.cpp eaa856f src/playlistmanager/SyncedPodcast.h 85c80fc src/playlistmanager/SyncedPodcast.cpp 92dd6f8 src/services/gpodder/GpodderProvider.cpp 2ba0bf3 Diff: http://git.reviewboard.kde.org/r/103122/diff/diff Testing --- Thanks, L

Re: Review Request: Done some improvements on Gpodder Service

2011-11-07 Thread Lucas Gomes
e.cpp 9e04d38 src/services/gpodder/GpodderServiceConfig.cpp 5ff6dea src/services/gpodder/GpodderServiceModel.cpp ef35c2f src/services/gpodder/GpodderServiceSettings.cpp 51ab598 Diff: http://git.reviewboard.kde.org/r/103034/diff/diff Testing --- Thanks, Lucas

Re: Review Request: Done some improvements on Gpodder Service

2011-11-04 Thread Lucas Gomes
On Nov. 3, 2011, 8:34 a.m., Lucas Gomes wrote: > > I'll take a look at the provider not appearing at runtime, probably a > > QtGroupingProxy thing. Another problem is that the provider keep showing on PodcastBrowser even if I disable the gpodder s

Re: Review Request: Done some improvements on Gpodder Service

2011-11-04 Thread Lucas Gomes
ice.h 02ff539 src/services/gpodder/GpodderService.cpp 9e04d38 src/services/gpodder/amarok_service_gpodder.desktop 10661b7 Diff: http://git.reviewboard.kde.org/r/103034/diff/diff Testing --- Thanks, Lucas Gomes ___ Amarok-devel mailing list A

Review Request: Done some improvements on Gpodder Service

2011-11-03 Thread Lucas Gomes
ngs.h fa53387 src/services/gpodder/GpodderServiceSettings.cpp 51ab598 Diff: http://git.reviewboard.kde.org/r/103034/diff/diff Testing --- Thanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/lis

Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

2011-10-14 Thread Lucas Gomes
hanks, Lucas Gomes ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request: [GSoC] Amarok integration with gpodder.net (Playlist synchronisation stuff)

2011-10-14 Thread Lucas Gomes
--- This patch is the result of git diff for the range of several commits prior to HEAD, rebased on current master, and should build. Everything is working as expected and there aren't any known issues. Thanks, Lucas Gomes ___ Amarok-

Re: Review Request: [GSoC] Amarok integration with gpodder.net

2011-09-27 Thread Lucas Gomes
personal clone repository. http://quickgit.kde.org/?p=clones%2Famarok%2Fgomes%2Fmaskmaster-amarok.git&a=summary - Lucas Gomes On Sept. 24, 2011, 2:25 p.m., Lucas Gomes wrote: > > --- > This is an automatically generated e-m

Re: Review Request: [GSoC] Amarok integration with gpodder.net

2011-09-25 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102600/ --- (Updated Sept. 24, 2011, 2:25 p.m.) Review request for Amarok, Stefan Derk

Review Request: [GSoC] Amarok integration with gpodder.net

2011-09-14 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102600/ --- Review request for Amarok, Stefan Derkits and Bart Cerneels. Summary -

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

2011-04-02 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/ --- (Updated April 1, 2011, 2:59 p.m.) Review request for Amarok. Summary --

Review Request: Bug 261062 - JJ: Mark episodes to keep

2011-04-02 Thread Lucas Gomes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/ --- Review request for Amarok. Summary --- Now downloaded episodes are ke