Review Request 124197: Set initial preset in EqualizerDialog to currently active preset

pp 1c1bd67 Diff: https://git.reviewboard.kde.org/r/124197/diff/ Testing --- Changed the presets a few times and restarted amarok in between in order to see whether the correct presets would be shown when opening the EqualizerDialog. Thanks, Da

Re: Review Request: Some changes to the handling of cover art reading and writing

, right? - Daniel --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104513/#review12418 --- On April 13, 2012, 7:42 p.m.

Re: Review Request: Some changes to the handling of cover art reading and writing

size. I'm not a big fan of this. http://git.reviewboard.kde.org/r/104513/s/515/ Still not perfect but better, I hope http://git.reviewboard.kde.org/r/104513/s/527/ Thanks, Daniel Faust ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Some changes to the handling of cover art reading and writing

rs with flac, mp3, and wma files. Screenshots --- http://git.reviewboard.kde.org/r/104513/s/508/ Mockup of a possible gui for setting cover size. I must say I'm not a big fan of this. http://git.reviewboard.kde.org/r/104513/s/514/ Mockup of a possible GUI to configure c

Re: Review Request: Some changes to the handling of cover art reading and writing

ng features because the config dialog gets overcrowded. - Daniel --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104513/#review12303 --- O

Re: Review Request: Some changes to the handling of cover art reading and writing

re any caching of this cover higher up in the stack? What do you mean? - Daniel --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104513/#review12297

Review Request: Some changes to the handling of cover art reading and writing

ns/db/sql/SqlMeta.cpp e663adf src/dialogs/CollectionSetup.h 3146f17 src/dialogs/CollectionSetup.cpp f1b7850 Diff: http://git.reviewboard.kde.org/r/104513/diff/ Testing --- I have tested writing covers with flac, mp3, and wma files. Screenshots --- http://git.reviewboar

Re: Re: Review Request: Bump the taglib dependency to 1.7

Hi, actually taglib 1.7 is not needed, I just forgot to wrap the #include around the #ifdef ... So I could either fix that and we can go back to taglib 1.6 or I'll remove all the #ifdef ... that are already used. greetings Daniel Commit Hook am Mittwoch, 25. Januar 2012 > >

Re: Review Request: Add an absolute date filter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103546/#review9847 --- On Jan. 16, 2012, 4:21 p.m., Daniel Faust wrote: > >

Re: Review Request: Add an absolute date filter

s/EditFilterDialog.cpp 58c2956 src/widgets/MetaQueryWidget.h 3974fb7 src/widgets/MetaQueryWidget.cpp 57b622f src/widgets/TokenPool.cpp 2889442 Diff: http://git.reviewboard.kde.org/r/103546/diff/diff Testing --- I tested filtering the collection and editing the filters with the EditF

Re: Review Request: Add an absolute date filter

viewboard.kde.org/r/103546/#review9291 --- On Dec. 26, 2011, 8:50 p.m., Daniel Faust wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Review Request: Add an absolute date filter

f src/widgets/TokenPool.cpp 2889442 Diff: http://git.reviewboard.kde.org/r/103546/diff/diff Testing --- I tested filtering the collection and editing the filters with the EditFilterDialog. Thanks, Daniel Faust ___ Amarok-devel mailing l

Re: Review Request: Find field names (filter keywords) even if they are translated

On Nov. 6, 2011, 6:10 p.m., Daniel Faust wrote: > > Good work, Daniel! Please fix remaining minor fix and I'll be happy to > > merge this. (or, do you have commit access yourself?) I can commit myself once everything is

Re: Review Request: Find field names (filter keywords) even if they are translated

r/103014/diff/diff Testing --- Thanks, Daniel Faust ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Find field names (filter keywords) even if they are translated

ta/support/MetaConstants.cpp fabb146 Diff: http://git.reviewboard.kde.org/r/103014/diff/diff Testing --- Thanks, Daniel Faust ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add new collection filter to find exact matches

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102252/#review7864 ------- On Nov. 1, 2011, 3:02 p.m., Daniel Faust wrote: > >

Re: Review Request: Find field names (filter keywords) even if they are translated

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103014/#review7858 ------- On Nov. 1, 2011, 3:09 p.m., Daniel Faust wrote: > > --- > Th

Re: Review Request: make all like conditions case insensitive

02252/) But I would suggest using case insensitivity there, too. Diffs - src/core-impl/collections/db/sql/SqlQueryMaker.cpp 398bcdc Diff: http://git.reviewboard.kde.org/r/103015/diff/diff Testing --- Thanks, Daniel Faust ___ Amarok-devel ma

Review Request: make all like conditions case insensitive

case insensitivity there, too. Diffs - src/core-impl/collections/db/sql/SqlQueryMaker.cpp 398bcdc Diff: http://git.reviewboard.kde.org/r/103015/diff/diff Testing --- Thanks, Daniel Faust ___ Amarok-devel mailing list Amarok-devel@kde.org

Review Request: Find field names (filter keywords) even if they are translated

iffs - src/core/meta/support/MetaConstants.cpp fabb146 Diff: http://git.reviewboard.kde.org/r/103014/diff/diff Testing --- Thanks, Daniel Faust ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Add new collection filter to find exact matches

p 91628ff src/widgets/MetaQueryWidget.h 3db49d3 src/widgets/MetaQueryWidget.cpp 5db1ded Diff: http://git.reviewboard.kde.org/r/102252/diff/diff Testing --- I'm using this patch for a few weeks now without any problems. Screenshots ---

Re: Review Request: Add keyboard shortcut for collection search

> On Oct. 24, 2011, 4:56 p.m., Matěj Laitl wrote: > > Good, thanks for your work, Silver. > > > > I've found an interesting corner case - while the keyboard is always > > focused to collection search upon CTRL+F, the collection widget itself does > > not show itself if it was previously hidden

Review Request: Add new collection filter to find exact matches

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102252/ --- Review request for Amarok. Summary --- Since I use labels quite inten

Re: Review Request: Use QGraphicsScene::NoIndex instead of QGraphicsScene::BspTreeIndex (avoid Qt bug crashing amarok)

- On July 16, 2011, 12:41 p.m., Daniel Faust wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101966/ >

Review Request: Use QGraphicsScene::NoIndex instead of QGraphicsScene::BspTreeIndex (avoid Qt bug crashing amarok)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101966/ --- Review request for Amarok. Summary --- As currently discussed in the

Review Request: Update the albums applet on every song change

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100763/ --- Review request for Amarok. Summary --- If the currently playing song

Review Request: Show compilations in the albums applet

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100761/ --- Review request for Amarok. Summary --- Currently only albums are show

labels and last.fm integration

There are some users wishing amarok to submit labels to last.fm. Please tell me what you think about it. https://bugs.kde.org/show_bug.cgi?id=257037 Greetings Daniel Faust ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman

Re: Regression alert: Random freezing/crashing

I have a similar problem, amarok crashes at random. It always crashed when I was raising the main window or switching to the tabbed cv or the cv was visible and the current track changed. Here is a crash after a track change. last debug output: amarok: END__: void EngineController::slotMetaData

[PATCH] Align applets correctly after a collapse

our kde/qt version. greetings Daniel Faust From a6c026c6d879ce25f0b99e1f55dae4e0374b5811 Mon Sep 17 00:00:00 2001 From: Daniel Faust Date: Tue, 23 Nov 2010 17:48:36 +0100 Subject: [PATCH] Align applets correctly after a collapse --- src/context/Applet.cpp |4 1 files changed, 4 insert