D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner closed this revision. asturmlechner added a comment. Thanks for testing! This was pushed with final changes addressing @wbauer's comments in commits 4337b3ef, 03ef605c and 822eddec. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner marked an inline comment as done. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner updated this revision to Diff 78497. asturmlechner added a comment. re-add accidentally removed required includes to FindMySQLe.cmake REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28284?vs=78487&id=78497 BRANCH mysqle-split-for-phab REVISI

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, jfowkes, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner updated this revision to Diff 78487. asturmlechner added a comment. updated for the case when mysqle is shipped with mariadb REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28284?vs=78465&id=78487 BRANCH mysqle-split-for-phab REVISION DETAIL

D24817: Restore scripting functionalities and Qt bindings.

Herald added a project: Amarok. Herald removed a subscriber: Amarok. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24817 To: nicolamori, amarok-devel, heikobecker Cc: asturmlechner, malteveerman, heikobecker, amarok-devel, jfowkes, pgomes, nicolamori, jyasi, mfraser, r

D27949: Conclude porting of Last.fm to Amarok KF5

asturmlechner added a comment. scrobble it does 👍 REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27949 To: pgomes, amarok-devel, #amarok Cc: heikobecker, asturmlechner, amarok-devel, #amarok, jfowkes, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, erid

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

asturmlechner created this revision. asturmlechner added reviewers: Amarok, heikobecker, wbauer. Herald added a project: Amarok. Herald added a subscriber: amarok-devel. asturmlechner requested review of this revision. REVISION SUMMARY - Previously, MariaDB lib was only found w/ distro provided

D28165: Fix compatibility with modern MySQL

asturmlechner added a comment. Waiting for @wbauer to confirm it works as well - btw, does openSUSE still provide mysqle to test -DWITH_MYSQL_EMBEDDED=on? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28165 To: vmatare, asturmlechner Cc: jfowkes, asturmlechner, wba

D28165: Fix compatibility with modern MySQL

asturmlechner accepted this revision. asturmlechner added a comment. This revision is now accepted and ready to land. In D28165#634067 , @vmatare wrote: > Please test again, and thanks a lot for the review so far. Successfully tested with:

D28165: Fix compatibility with modern MySQL

asturmlechner added a comment. In D28165#633145 , @wbauer wrote: > The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_version.h): I just went back and installed mariadb-connector-c in Gentoo in mysql

D28165: Fix compatibility with modern MySQL

asturmlechner added a comment. Confirming successful build here as well. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28165 To: vmatare Cc: jfowkes, asturmlechner, wbauer, amarok-devel, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinonei

D28165: Fix compatibility with modern MySQL

asturmlechner added a comment. That diff now looks like a diff in top of your previous diff. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28165 To: vmatare Cc: asturmlechner, wbauer, amarok-devel, jfowkes, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semarei

D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION

asturmlechner edited the summary of this revision. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D18671 To: asturmlechner, #amarok, markey, heikobecker Cc: heikobecker, amarok-devel

D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION

asturmlechner closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D18671 To: asturmlechner, #amarok, markey, heikobecker Cc: heikobecker, amarok-devel

D18674: Add missing QStandardPaths to fix build

asturmlechner closed this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D18674 To: asturmlechner, #amarok, markey, yurchor, heikobecker Cc: heikobecker, yurchor, amarok-devel

D18674: Add missing QStandardPaths to fix build

asturmlechner added a comment. This occurred after switching to ninja by default, maybe related. But I hadn't built amarok before that in a while. REPOSITORY R181 Amarok BRANCH buildfix REVISION DETAIL https://phabricator.kde.org/D18674 To: asturmlechner, #amarok, markey, yurchor, he

D18674: Add missing QStandardPaths to fix build

asturmlechner added a comment. -c /var/tmp/portage/media-sound/amarok-/work/amarok-/src/main.cpp /var/tmp/portage/media-sound/amarok-/work/amarok-/src/main.cpp:101:162: warning: macro "__DATE__" might prevent reproducible builds [-Wdate-time]

D18674: Add missing QStandardPaths to fix build

asturmlechner created this revision. asturmlechner added reviewers: Amarok, markey. Herald added a subscriber: amarok-devel. asturmlechner requested review of this revision. REPOSITORY R181 Amarok BRANCH buildfix REVISION DETAIL https://phabricator.kde.org/D18674 AFFECTED FILES src/main

D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION

asturmlechner created this revision. asturmlechner added reviewers: Amarok, markey. Herald added a subscriber: amarok-devel. asturmlechner requested review of this revision. REVISION SUMMARY Signed-off-by: Andreas Sturmlechner REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https

D10831: Ported some services to Qt5/KF5

asturmlechner added a comment. libmygpo-qt provides a pkgconfig file `libmygpo-qt5.pc` you can check for using `pkg_check_modules` REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10831 To: malteveerman, #amarok Cc: asturmlechner, #amarok, paul, yaohanchen, malteveerm

D10831: Ported some services to Qt5/KF5

asturmlechner added a comment. > gpodder service using mygpo-qt, which is still in a qt4 world Even though it may not be available on every distro out there yet (for lack of consumers), `libmygpo-qt-1.0.9` supports Qt5 already. At least clementine also makes use of it, but only in their

D10831: Ported some services to Qt5/KF5

asturmlechner added a comment. In D10831#213580 , @malteveerman wrote: > I've created this revision against the wrong branch. How do I fix that? If this is one commit, you switch to `kf5` branch and cherry-pick this commit. Alternatively

D10526: Port core application away from kdelibs4

asturmlechner added a comment. fwitw I've build-tested the patch and it builds and starts up fine. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok Cc: asturmlechner, stikonas, kpiwowarski, markey, spettini, #amarok, yaohanchen, malteve

D10526: Port core application away from kdelibs4

asturmlechner added a comment. I guess this was really meant as '...away from kdelibs4support' instead of kdelibs4, hence the confusion. But yes it is targeting the correct branch. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10526 To: malteveerman, #amarok Cc: as