> On Aug. 16, 2012, 12:15 p.m., Ralf Engels wrote:
> > Just going through all the review requests again.
> >
> > With your patch the following auto test is failing:
> > testIdentifyCompilationInMultipleDirectories
>
> Alexey Neyman wrote:
> Which is,
mail. To reply, visit:
http://git.reviewboard.kde.org/r/104294/#review17522
-----------
On March 16, 2012, 12:13 a.m., Alexey Neyman wrote:
>
> ---
> This is an automatically gener
e.org/r/104423/diff/
Testing
---
Thanks,
Alexey Neyman
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
> src/core/meta/support/MetaKeys.h e2227e6
> src/core/meta/support/MetaKeys.cpp 7f8ce7d
>
> Diff: http://git.reviewboard.kde.org/r/104423/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Alexey Neyman
>
>
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
c/core/meta/support/MetaKeys.h e2227e6
src/core/meta/support/MetaKeys.cpp 7f8ce7d
Diff: http://git.reviewboard.kde.org/r/104423/diff/
Testing
---
Thanks,
Alexey Neyman
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
for committing the fix.
> > Also you might want to make a new unit test to prevent somebody later on to
> > change the behaviour for the worse.
>
> Alexey Neyman wrote:
> Ralf,
>
> I wasn't able to run t
for committing the fix.
> > Also you might want to make a new unit test to prevent somebody later on to
> > change the behaviour for the worse.
>
> Alexey Neyman wrote:
> Ralf,
>
> I wasn't able to run t
for committing the fix.
> > Also you might want to make a new unit test to prevent somebody later on to
> > change the behaviour for the worse.
>
> Alexey Neyman wrote:
> Ralf,
>
> I wasn't able to run t
ect iTunes-style compilations
- Alexey
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104294/#review11582
---
On March 16, 2012,
for committing the fix.
> > Also you might want to make a new unit test to prevent somebody later on to
> > change the behaviour for the worse.
>
> Alexey Neyman wrote:
> Ralf,
>
> I wasn't able to run t
was trying to process
[15:54:51] but I'd rather get rid of that code block entirely if
it's not doing anything useful
This addresses bug 295275.
https://bugs.kde.org/show_bug.cgi?id=295275
Diffs
-
src/AmarokMimeData.cpp 226b0fa
Diff: htt
byte characters are inside the XML tags.
Diffs
-
src/core-impl/collections/db/ScanManager.h 5f0d153
src/core-impl/collections/db/ScanManager.cpp 97d0b1c
Diff: http://git.reviewboard.kde.org/r/104310/diff/
Testing
---
Thanks,
Alexey Neyman
__
non-empty artists), this
album is excluded from being merged with other albums to create a "compilation".
Diffs
-
src/core-impl/collections/db/ScanResultProcessor.cpp 4f02a16
Diff: http://git.reviewboard.kde.org/r/104294/diff/
Testi
13 matches
Mail list logo
