rto
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105290/#review31679
---
On April 22, 2013, 5:57 p.m., Alberto Vil
290/#review19651
-------
On April 22, 2013, 5:57 p.m., Alberto Villa wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde
of createIndex() at
> > various places like this (i.e. have createIndex() only in actual index()
> > implementation). Not a big deal though, certainly doesn't block this patch
> > from merging.
>
> Alberto Villa wrote:
> In some methods where no indexes are us
t.reviewboard.kde.org/r/105290/diff/
Testing
---
File Attachments
Toolbar with icons and QToolButtons
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/15/snapshot1.png
New toolbar with latest icons and descriptions.
http://git.reviewboard.kde.org/media/uploaded/fi
is *the* thing on your TODO list):
> >
> > beginInsertRows( QModelIndex(), rowCount(), rowCount() );
> > ...
> > endInsertRows();
>
> Alberto Villa wrote:
> Not that easy, if I understand it correctly. appendChild() isn't as
> simple as adding a result to the bo
t; > endInsertRows();
Not that easy, if I understand it correctly. appendChild() isn't as simple as
adding a result to the bottom; it may add results to each track, or even merge
them (which means that no result is appended).
- Alberto
-
buttons. Now it's wider than
its parent dialog, which is better imho, because it makes it a bit more
recognisable.
- Alberto
-------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105290
> On April 15, 2013, 12:54 p.m., Alberto Villa wrote:
> > src/musicbrainz/MusicBrainzTags.cpp, line 588
> > <http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588>
> >
> > Is this too hacky?
>
> Matěj
d descriptions.
http://git.reviewboard.kde.org/media/uploaded/files/2013/04/18/toolbar_wider.png
Screenshots
---
http://git.reviewboard.kde.org/r/105290/s/605/
Thanks,
Alberto Villa
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
> On April 15, 2013, 12:54 p.m., Alberto Villa wrote:
> > src/musicbrainz/MusicBrainzTags.cpp, line 588
> > <http://git.reviewboard.kde.org/r/105290/diff/3-4/?file=87207#file87207line588>
> >
> > Is this too hacky?
>
> Matěj
ected (but I tested just quickly). This is not yet a
> > complete review, but should be a good start for further work. Anyways,
> > thanks for the *massive* changes!
It's not supposed to work, as I stopped the porting to the proxy model to ask
for that suggestion. I
7;t like this approach, I'd
rather prefer it to refernce only QAbstractItemModel like in other methods. I
could move isChcked() and checkAllFromRelease() to the view (making them a bit
more complex), but I'm not sure they belong there.
Any advice?
- Alberto Villa
On April 15,
--
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105290/#review19651
---
On April 15, 2013, 12:51 p.m., Alberto Villa wrote:
>
> ---
340
src/musicbrainz/MusicBrainzXmlParser.cpp 473d27a
Diff: http://git.reviewboard.kde.org/r/105290/diff/
Testing
---
File Attachments (updated)
Toolbar with icons and QToolButtons
http://git.reviewboard.kde.org/media/uploade
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105290/#review31088
---
- Alberto Villa
On Sept. 26, 2012, 12:26 a.m., Alberto Villa
y, visit:
http://git.reviewboard.kde.org/r/105290/#review15190
---
On June 18, 2012, 10:08 p.m., Alberto Villa wrote:
>
> ---
> This is an automatically generated e-mail.
zXmlParser.cpp 473d27a
Diff: http://git.reviewboard.kde.org/r/105290/diff/
Testing
---
Screenshots
---
http://git.reviewboard.kde.org/r/105290/s/605/
Thanks,
Alberto Villa
___
Amarok-devel mailing list
Amarok-devel@kde.org
https://mail.kde.org/mailman/listinfo/amarok-devel
ainzTags.cpp 08d4fdf
src/musicbrainz/MusicBrainzXmlParser.h 171a340
src/musicbrainz/MusicBrainzXmlParser.cpp 473d27a
Diff: http://git.reviewboard.kde.org/r/105290/diff/
Testing
---
Screenshots
---
http://git.reviewboard.kde.org/r/105290/s/605/
Thanks,
Alberto Villa
___
18 matches
Mail list logo
