Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2016-07-12 Thread Aditya Dev Sharma
LT + F10 -> SLOT(showAbout()) Diagnostics : ALT + F8-> SLOT(slotShowDiagnosticsDialog()) Report bug : ALT + F9 -> SLOT(showReportBug()) Thanks, Aditya Dev Sharma

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2016-07-12 Thread Aditya Dev Sharma
3/#review97320 --- On Sept. 15, 2015, 5:18 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Re: Review Request 125593: removed the Line that deleted m_args

2015-10-12 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125593/#review86716 --- Ship it! Ship It! - Aditya Dev Sharma On Oct. 12, 2015, 1

Re: Review Request 125593: removed the Line that deleted m_args

2015-10-11 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125593/#review86669 --- Comment it rather - Aditya Dev Sharma On Oct. 11, 2015, 1

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-05 Thread Aditya Dev Sharma
marked as submitted. Review request for Amarok, Stefan Derkits and Olivier Churlaud. Changes --- Submitted with commit 79eb948507f4e39e16d0fe8ccdff8cdc477baa28 by Aditya Dev Sharma to branch kf5. Repository: amarok Description --- Replaced the KApplication with QApplication and

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Aditya Dev Sharma
oard.kde.org/r/125519/#review86342 --- On Oct. 4, 2015, 5:44 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Aditya Dev Sharma
/SliderWidget.cpp bf21922 src/widgets/Token.cpp 05a0b78 src/widgets/TokenPool.cpp a13d97b Diff: https://git.reviewboard.kde.org/r/125519/diff/ Testing --- Builds 100 % Fixed the error and changed all stuff to . Commented qApp->setTopWidget() until further information. Thanks, Aditya

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Aditya Dev Sharma
marked as submitted. Review request for Amarok, Stefan Derkits, Olivier Churlaud, and Myriam Schweingruber. Changes --- Submitted with commit bb911e4e65b383b8169c368ce5be5f5cf7c66c4b by Heiko Becker on behalf of Aditya Dev Sharma to branch kf5. Repository: amarok Description

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Aditya Dev Sharma
oard.kde.org/r/125394/#review85961 --- On Sept. 26, 2015, 11:41 a.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-26 Thread Aditya Dev Sharma
Diff: https://git.reviewboard.kde.org/r/125394/diff/ Testing --- Builds 100 % Thanks, Aditya Dev Sharma ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-25 Thread Aditya Dev Sharma
- cmake/modules/FindLibLastFm.cmake 8fa607b Diff: https://git.reviewboard.kde.org/r/125394/diff/ Testing --- Builds 100 % Thanks, Aditya Dev Sharma ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-25 Thread Aditya Dev Sharma
--- On Sept. 25, 2015, 2:30 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125394/ > --

Review Request 125394: CMake shows LibLastFm not found warning on some systems.

2015-09-25 Thread Aditya Dev Sharma
/diff/ Testing --- Builds 100 % Thanks, Aditya Dev Sharma ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-09-15 Thread Aditya Dev Sharma
inside dynamic playlist category About Amarok : ALT + F10 -> SLOT(showAbout()) Diagnostics : ALT + F8-> SLOT(slotShowDiagnosticsDialog()) Report bug : ALT + F9 -> SLOT(showReportBug()) Thanks, Aditya Dev Sharma __

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-09-13 Thread Aditya Dev Sharma
hortcuts or even the ones used before. I'll wait for Mamarok :) - Aditya --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124773/#review85318 ----------

Re: Review Request 125076: fatal error: kdemacros.h: No such file or directory at 2%

2015-09-12 Thread Aditya Dev Sharma
% fatal error: kdemacros.h: No such file or directory Thanks, Aditya Dev Sharma ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 125076: fatal error: kdemacros.h: No such file or directory at 2%

2015-09-11 Thread Aditya Dev Sharma
, visit: https://git.reviewboard.kde.org/r/125076/#review85199 --- On Sept. 6, 2015, 5:28 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. T

Review Request 125076: fatal error: kdemacros.h: No such file or directory at 2%

2015-09-06 Thread Aditya Dev Sharma
. Repository: amarok Description --- KF5 : An error popped up at 2% Diffs - shared/CMakeLists.txt fd96237 Diff: https://git.reviewboard.kde.org/r/125076/diff/ Testing --- An error at 2% fatal error: kdemacros.h: No such file or directory Thanks, Aditya Dev Sharma

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-08-18 Thread Aditya Dev Sharma
LOT(slotShowDiagnosticsDialog()) Report bug : ALT + F9 -> SLOT(showReportBug()) Thanks, Aditya Dev Sharma ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-08-18 Thread Aditya Dev Sharma
Dev Sharma ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-08-18 Thread Aditya Dev Sharma
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124773/#review83969 ----------- On Aug. 17, 2015, 7:26 a.m., Aditya Dev Sharma wrote: > > -

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-08-17 Thread Aditya Dev Sharma
laylist category /* Rev3 */ About Amarok : CTRL + SHIFT + A -> SLOT(showAbout()) Diagnostics : CTRL + ALT + D-> SLOT(slotShowDiagnosticsDialog()) Report bug : ALT + SHIFT + R ---------> SLOT(showReportBug()) Thanks, Aditya Dev Sharma

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-08-17 Thread Aditya Dev Sharma
SLOT(bookmarkCurrentBrowserView() ) Bookmark Playlist Setup : ALT + B ---> bookmarkCurrentPlaylistView() ) Bookmark Context Applets : CTRL + SHIFT + B --> bookmarkCurrentContextView() ) Disable Dynamic Playlist : ALT + SHIFT + D ---> connected inside dynamic playl

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-08-16 Thread Aditya Dev Sharma
+ D ---> connected inside dynamic playlist category Thanks, Aditya Dev Sharma ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-08-16 Thread Aditya Dev Sharma
SLOT(slotShowEqualizer() ) Cover Manager : CTRL + ALT + C ---> SLOT(slotShowCoverManager() ) Synchronize Statistics : CTRL + S ---> SLOT(synchronize() ) Thanks, Aditya Dev Sharma ___ Amarok-devel mailing li