D27949: Conclude porting of Last.fm to Amarok KF5

2020-04-11 Thread Pedro Gomes
This revision was automatically updated to reflect the committed changes. Closed by commit R181:abca65432fce: Conclude porting of Last.fm to Amarok KF5 (authored by pgomes). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27949?vs=78991&id=79869 REVISION DETAIL

D28593: Fix copying and moving files to collection

2020-04-11 Thread Pedro Gomes
pgomes marked an inline comment as done. pgomes added inline comments. INLINE COMMENTS > heikobecker wrote in TokenDropTarget.cpp:211 > Any particular reason to change this? Admittedly it doesn't really matter, > given nothing is promoted as external library. No particular reason. I reverted th

D28593: Fix copying and moving files to collection

2020-04-11 Thread Pedro Gomes
pgomes added a comment. In D28593#645766 , @heikobecker wrote: > Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716 Yes, this seems to be the same issue

D28593: Fix copying and moving files to collection

2020-04-11 Thread Pedro Gomes
This revision was automatically updated to reflect the committed changes. Closed by commit R181:96eaac4fc099: Fix copying and moving files to collection (authored by pgomes). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28593?vs=79405&id=79865#toc REPOSITORY R181 Amarok CHANGES SINC

D28593: Fix copying and moving files to collection

2020-04-11 Thread Heiko Becker
heikobecker added a comment. Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716 REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28593 To: pgomes, #amarok, amarok-devel, heikobecker C

D28593: Fix copying and moving files to collection

2020-04-11 Thread Heiko Becker
heikobecker accepted this revision. heikobecker added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TokenDropTarget.cpp:211 > > -Q_EMIT changed(); > +emit changed(); > } Any particular reason to change this? Admittedly it doesn't really matter, g

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

2020-04-11 Thread Heiko Becker
heikobecker accepted this revision as: heikobecker. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH mysqle-split-for-phab REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, pgomes, ni

D27949: Conclude porting of Last.fm to Amarok KF5

2020-04-11 Thread Heiko Becker
heikobecker accepted this revision as: heikobecker. This revision is now accepted and ready to land. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27949 To: pgomes, amarok-devel, #amarok, heikobecker Cc: heikobecker, asturmlechner, amarok-devel, #amarok, pgomes, nicolam