nicolamori added a comment.
@heikobecker The bindings are extracted from the source of QCad; they are
statically placed in their code base, with one folder for each Qt version; if
there are more Qt versions sharing the same bindings then the bindings are
present only for one version and for
This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R181:cc57275e701c: Removed obsolete PackagePath role from
AppletModel (authored by malteveerman, committed by heikobecker)
heikobecker accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D27369
To: pgomes, #amarok, amarok-devel, heikobecker
Cc: #amarok, pgomes, amarok-devel
heikobecker requested changes to this revision.
heikobecker added a comment.
This revision now requires changes to proceed.
I'm sorry for stepping in soo late, but this has really become too huge to
review and does multiple things at once. Could you please split it up? I'll
push an older diff
heikobecker requested changes to this revision.
heikobecker added a comment.
This revision now requires changes to proceed.
How are those bindings generated? I assume they change depending on the used
Qt version? Could it be feasible to convince cmake to generate them during
build time?
heikobecker added inline comments.
INLINE COMMENTS
> WikipediaEngine.cpp:496
> query.addQueryItem( QLatin1String("srprop"), QLatin1String("size") );
> -query.addQueryItem( QLatin1String("srredirects"), QString::number(1) );
> +//query.addQueryItem( QLatin1String("srredirects"), QStri
heikobecker accepted this revision as: heikobecker.
heikobecker added a comment.
This revision is now accepted and ready to land.
Thanks!
Do you have commit access or should I push this for you?
REPOSITORY
R181 Amarok
REVISION DETAIL
https://phabricator.kde.org/D27370
To: pgomes, #a
