D24413: Fix Increase/Decrease Volume shortcuts

2019-10-21 Thread Wolfgang Bauer
wbauer added a comment. In D24413#550948 , @heikobecker wrote: > I'm always easy to confuse about pointers and const, but isn't ec a const pointer to a const object? So calling ec->increaseVolume() as a non-const function) wouldn't really work

D13438: Removed obsolete PackagePath role from AppletModel

2019-10-21 Thread Malte Veerman
malteveerman updated this revision to Diff 68430. malteveerman added a comment. Herald added a project: Documentation. Herald added a subscriber: kde-doc-english. - Made SvgHandler handle QRC resource files. - Removed "PackagePath" data role from AppletModel. - Moved applet view from ListVi

D24817: Restore scripting functionalities and Qt bindings.

2019-10-21 Thread Nicola Mori
nicolamori added a comment. Hi Heiko, I know that QtScript is EOL but I don't have the knowledge nor spare time to do more than this ATM. I never contributed to Amarok nor any other KDE project, and also my experience with Qt is limited to some simple GUI. Nevertheless, I hope that this work

D24817: Restore scripting functionalities and Qt bindings.

2019-10-21 Thread Heiko Becker
heikobecker added a comment. Nice! I don't want to discourage you, but while QtScript is still there it has been deprecated. Perhaps this still makes sense as a intermediate step, but at some point this should be ported to the QJS* classes from Qt5Qml (e.g. like done for kio https://phabric