D24135: Fix missing directory separators when saving podcasts to disk

This revision was automatically updated to reflect the committed changes. Closed by commit R181:982772be0d06: Fix missing directory separators when saving podcasts to disk (authored by yurchor). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24135?vs=66626&id=6

D24135: Fix missing directory separators when saving podcasts to disk

jyasi added a comment. In D24135#541657 , @heikobecker wrote: > Do you have commit access or should I push this for you? I don't have commit access. Please push for me. Thanks! REPOSITORY R181 Amarok REVISION DETAIL https://phabrica

D24381: Register Play/Pause as global shortcut again

heikobecker accepted this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24381 To: wbauer, #amarok, schweingruber, heikobecker Cc: schweingruber, amarok-devel, #amarok

D24135: Fix missing directory separators when saving podcasts to disk

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. Do you have commit access or should I push this for you? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok, heikobecker Cc: heikobe

Re: Deprecating Old Amarok Versions

On Thu, 3 Oct 2019 at 11:47, Myriam Schweingruber wrote: > Indeed, and some distros have already jumped the gun and ship a master build without notifying their users that they ship a pre-beta version... > About the bugs: those were already there in the Qt4 version, just not that noticeable. What w

D24381: Register Play/Pause as global shortcut again

schweingruber accepted this revision. schweingruber added a comment. This revision is now accepted and ready to land. Looks OK to me, anyone who could test additionally? I am on a phone right now... REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24381 To: wbauer, #a

D24381: Register Play/Pause as global shortcut again

wbauer retitled this revision from "Register Play/Pause global shortcut again" to "Register Play/Pause as global shortcut again". REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24381 To: wbauer, #amarok Cc: amarok-devel, #amarok

D24381: Register Play/Pause global shortcut again

wbauer edited the test plan for this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24381 To: wbauer, #amarok Cc: amarok-devel, #amarok

D24381: Register Play/Pause global shortcut again

wbauer edited the test plan for this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24381 To: wbauer, #amarok Cc: amarok-devel, #amarok

D24135: Fix missing directory separators when saving podcasts to disk

wbauer added a subscriber: Amarok. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok Cc: #amarok, wbauer, yurchor, amarok-devel

D24135: Fix missing directory separators when saving podcasts to disk

wbauer added a comment. +1 from me now as well. The KDE4 code uses `KUrl::toLocalFile( KUrl::AddTrailingSlash )` here, so the additional slash should be correct (and necessary). REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok Cc: wbauer,

D24381: Register Play/Pause global shortcut again

wbauer created this revision. wbauer added a reviewer: Amarok. wbauer added a project: Amarok. Herald removed a project: Amarok. wbauer requested review of this revision. REVISION SUMMARY Commit 0b2b243b removed the ca

D24381: Register Play/Pause global shortcut again

wbauer edited the summary of this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24381 To: wbauer, #amarok Cc: amarok-devel, #amarok