Amarok git and 2.8.90 tarball fail to build

2017-02-04 Thread Emily Fierro
Hi, so I've been testing this out. I'll attach the error log in this email. A fix is going into CMakeLists.txt and commenting the line that says "add_subdirectory( tests )" and then it builds without an error. Performing C++ SOURCE FILE Test COMPLEX_TAGLIB_FILENAME failed with the following output:

Review Request 129920: Replace Deprecated AV Functions

2017-02-04 Thread Dominik Waurenschk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129920/ --- Review request for Amarok. Repository: amarok Description --- Repl

Re: Review Request 100176: Fetch cover for DAAP Albums #240060

2017-02-04 Thread Albert Astals Cid
> On April 5, 2013, 8:33 p.m., Albert Astals Cid wrote: > > If this doesn't get any action before my next janitorial round I'll discard > > the Review Request understanding nooone cares enough to push this forward. > > Matěj Laitl wrote: > Looking at the code, this seems still valuable for

Re: Review Request 123635: Fix minor typo in PlaylistLengthEditWidget.ui

2017-02-04 Thread Robert Marshall
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123635/ --- (Updated Feb. 4, 2017, 8:49 p.m.) Status -- This change has been mar

Re: Review Request 116641: Fixes Bug 302299 - Autoscrolling Lyrics are scrolling down if a song is rated via Context Browser's Current Track

2017-02-04 Thread yash ladia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116641/ --- (Updated Feb. 4, 2017, 10:35 a.m.) Status -- This change has been ma

Re: Review Request 123635: Fix minor typo in PlaylistLengthEditWidget.ui

2017-02-04 Thread Albert Astals Cid
> On May 5, 2015, 12:09 p.m., Myriam Schweingruber wrote: > > Ship It! > > Robert Marshall wrote: > By someone other tham me (I don't have rights). Isn't there still a > string freeze? > > Myriam Schweingruber wrote: > There still is a string freeze, but in this particular case this is