Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-06-19 Thread Matěj Laitl
> On Čer. 19, 2016, 3:53 odp., Matěj Laitl wrote: > > Although I'm not context view expert, this loks good to me, let's merge > > this and let wider user base test it. I forgot: the patch fixes a bug, thuis should contain a ChangeLog entry. - Matěj --

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-06-19 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/#review96718 --- Ship it! Although I'm not context view expert, this loks g

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Olivier Churlaud
> On June 19, 2016, 12:37 p.m., Stefano Pettini wrote: > > I'll review this patch soon. Btw there's a file, > > src/musicbrainz/MusicDNSAudioDecoder.cpp, that is not related to this patch. Oh yes, but I could not compile without this change.I can put that in a second review - Olivier -

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Stefano Pettini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/#review96712 --- I'll review this patch soon. Btw there's a file, src/musicbr

Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-19 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128248/ --- Review request for Amarok and Myriam Schweingruber. Bugs: 349313 http