Re: Changes in SqlQueryMaker.cpp

2015-10-29 Thread RISHABH GUPTA
From: Michael Pyne Date: Thu, Oct 29, 2015 at 7:23 AM Subject: Re: Debug ThreadWeaver::IdDecorator To: kde-de...@kde.org On Wed, October 28, 2015 18:45:40 Olivier Churlaud wrote: > Le 28/10/2015 16:08, Thomas Lübking a écrit : > > On Mittwoch, 28. Oktober 2015 14:33:02 CEST, Olivier Churlaud wro

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/ --- (Updated Oct. 30, 2015, 6:34 a.m.) Review request for Amarok, Stefan Derk

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
> On Oct. 29, 2015, 6:39 p.m., Aroonav Mishra wrote: > > In line 160-164, I will suggest you to not completely remove those > > lines(Memory leaks maybe?) but instead revert it to the way it was before I > > edited it(I don't remember why I changed it). That is, put > > d->worker->deleteLater(

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/ --- (Updated Oct. 30, 2015, 5:56 a.m.) Review request for Amarok, Stefan Derk

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87691 --- Ship it! Ship It! - Olivier Churlaud On oct. 29, 2015, 6:1

Changes in SqlQueryMaker.cpp

2015-10-29 Thread Aroonav Mishra
Hello all, KF5::ThreadWeaver is not very well documented and the docs available for it's porting is inadequate. And due to this, porting this part was tricky & took up quite a bit of my time. I will be explaining all the changes that I made in here

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread Aroonav Mishra
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87689 --- In line 160-164, I will suggest you to not completely remove t

Re: Review Request 125872: threadweaver issue solved

2015-10-29 Thread Aroonav Mishra
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/#review87688 --- In line 160-164, I will suggest you to not completely remove t

Review Request 125872: threadweaver issue solved

2015-10-29 Thread rishabh gupta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125872/ --- Review request for Amarok, Stefan Derkits and Olivier Churlaud. Repositor