[Port KF5] Aditya's commit

2015-10-13 Thread Olivier Churlaud
Hi, Aditya's commit prevent me to compile to 100%, which is a regression. Is it the same for you? Here is my output: https://paste.kde.org/pk9zp5xaj (the beginning is missing, sorry for this) Furthermore, your commit message should be more explicit Aditya: REVIEW: 125519 is not enough. C

[Port KF5] Plugins

2015-10-13 Thread Olivier Churlaud
Hi again, Normally if you run Amarok (after having done a /make install/) you should get a QMessageBox complaning about the SQL plugin. You should be able to read in the trace : Error loading plugin "amarok_storage-mysqlestorage" "La biblioth\u00E8que partag\u00E9e est introuvable." Plugin s

Re: [Port KF5] Aditya's commit

2015-10-13 Thread Aditya Sharma
> > Please forget the message I sent (see below). I wasn't on the good branch. > > @Aditya: Just take in account my advice for the commits. > Sure. Thanks for pointing that out :) > > Cheers, and keep up the good job! > Olivier > > --- > Hi, > > Aditya's commit prevent me to compile to 100%, whi

Fwd: [Port KF5] Aditya's commit

2015-10-13 Thread Olivier Churlaud
Please forget the message I sent (see below). I wasn't on the good branch. @Aditya: Just take in account my advice for the commits. Cheers, and keep up the good job! Olivier --- Hi, Aditya's commit prevent me to compile to 100%, which is a regression. Is it the same for you? Here is my output