Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Olivier Churlaud
Hi, Ship It! Please commit on my behalf. I don't have a dev account :) Then request one ! https://techbase.kde.org/Contribute/Get_a_Contributor_Account#How_to_get_read-write_access_to_git.2Fsvn Cheers, Olivier ___ Amarok-devel mailing li

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Aditya Dev Sharma
> On Oct. 4, 2015, 5:48 p.m., Olivier Churlaud wrote: > > Ship It! Please commit on my behalf. I don't have a dev account :) - Aditya --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/1255

Re: Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125519/#review86342 --- Ship it! Ship It! - Olivier Churlaud On oct. 4, 2015, 7:44

Review Request 125519: KF5 : Amarok gave sessionSaving() run time error on Quiting and did not go to tray.

2015-10-04 Thread Aditya Dev Sharma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125519/ --- Review request for Amarok, Stefan Derkits and Olivier Churlaud. Repositor

Re: Applying Churlaud's patch - KF5/Qt5

2015-10-04 Thread Olivier Churlaud
I commit my patch now, please commit yours afterwards so that we don't mess up everything :) Olivier Olivier CHURLAUD Engineer Student at Ecole Centrale de Lyon in Dual Degree at TU Berlin, M.Sc. Elektrotechnik @: oliv...@churlaud.com tel: +49 (0)1575-2931348 in: http://linkedin.com/in/olivier

Re: Applying Churlaud's patch - KF5/Qt5

2015-10-04 Thread Aditya Sharma
> I'll commit anyway today, so that everyone can work from the same basis... > If at the end, someone thinks it's not well made, the commit can be > reverted > > Changed all includes of KApplication to QApplication. > Changed kapplication.h to qapplication.h > Changed kapp to qApp > Commented

Re: Applying Churlaud's patch - KF5/Qt5

2015-10-04 Thread Olivier Churlaud
Hi there, Le 03/10/2015 22:23, Aditya Sharma a écrit : I applied Olivier's patch from the Review Board. He has still not committed anything so I proceeded anyway with his patch. I'll commit anyway today, so that everyone can work from the same basis... If at the end, someone thinks it's not w