Re: kf5 port(olivier)

2015-09-13 Thread Aditya Sharma
> > Hi, > Hey ! > Then apply the last diff from the review board and see if you can help me > to cgo further and clean it up. ;) > Applied your last diff, using patch -p1 < patch.txt But the Segmentation fault remains the same. The same QHash fault. > Cheers > Olivier >

Re: kf5 port(olivier)

2015-09-13 Thread Olivier Churlaud
Hi, Then apply the last diff from the review board and see if you can help me to cgo further and clean it up. ;) Cheers Olivier Sur 13 sept. 2015 23:33, à 23:33, Aditya Sharma a écrit: >I'd like to add, this is what happens with me. >I haven't applied any diffs. Only the latest KF5 commits.

Re: kf5 port(olivier)

2015-09-13 Thread Aditya Sharma
I'd like to add, this is what happens with me. I haven't applied any diffs. Only the latest KF5 commits. Log -- Regards Aditya ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amar

Re: Kf5port(olivier) rishabh

2015-09-13 Thread Aditya Sharma
> > >>> Today's Topics: >>> >>>1. Re: kf5 port(olivier) (Olivier Churlaud) >>> >>> >>> -- >>> >>> Message: 1 >>> Date: Sun, 13 Sep 2015 11:33:01 +0200 >>> From: Olivier Churlaud >>> To: amarok-devel@kde.org >>> Subject: Re: kf

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-09-13 Thread Aditya Dev Sharma
> On Sept. 13, 2015, 4:59 p.m., Olivier Churlaud wrote: > > Regarding the code, everything seems fine. Now the real question is about > > the shortcuts. Are they really good? Logical? > > > > I'm not the one to judge on this. But a Shift+E for instance might have bad > > repercussions (if you

Re: Review Request 125126: Port of main.cpp and App class

2015-09-13 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125126/ --- (Updated sep. 13, 2015, 7:59 après-midi) Review request for Amarok. Cha

Re: Port KF5

2015-09-13 Thread Olivier Churlaud
Dear Rishabh, I apology, I did the backtrace command in gdb, and had the exact same output as you... The error comes from this code: //We need to set fixed widths initially, just until the main window has been properly laid out. As soon as this has //happened, we will unlock these si

Re: Review Request 124773: JJ Bug - 300979 : Add some shortcuts for various actions in createActions() in MainWindow.

2015-09-13 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124773/#review85318 --- Regarding the code, everything seems fine. Now the real questi

Re:Port KF5

2015-09-13 Thread Olivier Churlaud
Here is my full log : http://pastebin.com/Z28JJERv I think you didn't apply the diff well Le 13/09/2015 18:52, Olivier Churlaud a écrit : Hi Ribash, How come the line was missing? Did you apply the diff to the project ? Didi you use the second one (don't take care of the 1st) Your log i

Re: Amarok-devel Digest, Vol 104, Issue 15

2015-09-13 Thread Olivier Churlaud
Hi Ribash, How come the line was missing? Did you apply the diff to the project ? Didi you use the second one (don't take care of the 1st) Your log is very interesting, what debugger do you use? With gdb, I can't get such a deep description (but I may not know how to use it well). With such

Re: Kf5port(olivier) rishabh

2015-09-13 Thread RISHABH GUPTA
On Sun, Sep 13, 2015 at 5:30 PM, wrote: > >> Send Amarok-devel mailing list submissions to >> amarok-devel@kde.org >> >> To subscribe or unsubscribe via the World Wide Web, visit >> https://mail.kde.org/mailman/listinfo/amarok-devel >> or, via email, send a message with subject or

Re: Amarok-devel Digest, Vol 104, Issue 15

2015-09-13 Thread RISHABH GUPTA
On Sun, Sep 13, 2015 at 5:30 PM, wrote: > Send Amarok-devel mailing list submissions to > amarok-devel@kde.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://mail.kde.org/mailman/listinfo/amarok-devel > or, via email, send a message with subject or body 'h

Re: kf5 port(olivier)

2015-09-13 Thread Olivier Churlaud
here's the output http://pastebin.com/5StyEUth Huuu Wait, it's not possible. My segfault doesn't happen in handleCliArgs() but way after... It means that I left a bug, that works on my system but not yours OR that something is wrong on your side. Please investigate why this happen, I'll d

Re: kf5 port(olivier)

2015-09-13 Thread Olivier Churlaud
Hi, Le 13/09/2015 10:44, RISHABH GUPTA a écrit : Changes --- Work more, and reduce segfaults Repository: amarok Description (updated) --- Port of main.cpp and App It compiles 100%, and there is a segmentation fault after the end of the App::co

kf5 port(olivier)

2015-09-13 Thread RISHABH GUPTA
Changes > --- > > Work more, and reduce segfaults > > > Repository: amarok > > > Description (updated) > --- > Port of main.cpp and App > > It compiles 100%, and there is a segmentation fault after the end of the > App::continueInit(). > I'm not able to trace it further. > > Please h