[KDE Bugtracking System] REMINDER: current Amarok regressions

2015-02-27 Thread bugzilla_noreply
Please find below a list of the current regressions reported for Amarok. This search was scheduled by myr...@kde.org. Amarok regressions (5 bugs) -- Bug 231187: https://bugs.kde.org/show_bug.cgi?id=231187 Severity: normal Priority: NOR Status: CONFIRMED Component

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
> On Feb. 27, 2015, 3:51 p.m., Dan Meltzer wrote: > > I'm a little late to the party, but this seems like it would cause a > > regression for anyone not using plasma workspace... right? Isn't it a kded > > bug that the shortcuts don't get forwarded to the active window? > I'm a little late to

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Dan Meltzer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76726 --- I'm a little late to the party, but this seems like it would c

Jenkins build is back to normal : amarok_master #846

2015-02-27 Thread KDE CI System
See ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 27, 2015, 12:50 p.m.) Status -- This change has been m

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Myriam Schweingruber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76721 --- Ship it! because a) I can't review the code and b) I need to

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
> On Feb. 27, 2015, 1:13 p.m., Myriam Schweingruber wrote: > > I didn't give a ship it yet as I want to get Amarok 2.9 beta out first. I don't get this argument. It would be very important if we get this change into the beta and best also in stable releases. - Martin ---

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
> On Feb. 27, 2015, 11:40 a.m., Vishesh Handa wrote: > > src/ActionClasses.cpp, line 174 > > > > > > Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can > > one just omit it alltogether? > >

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Myriam Schweingruber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76713 --- I didn't give a ship it yet as I want to get Amarok 2.9 beta o

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Klapetek
> On Feb. 27, 2015, 11:40 a.m., Vishesh Handa wrote: > > src/ActionClasses.cpp, line 174 > > > > > > Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can > > one just omit it alltogether? Thi

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76709 --- src/ActionClasses.cpp

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76703 --- ping, anyone? - Martin Gräßlin On Feb. 6, 2015, 9:06 a.m.,